1379508 - <select> dropdowns don't work in OOP popup browsers

Status: RESOLVED FIXED

(WebExtensions :: Frontend, defect, P1)

Description

[Gary [:streetwolf52]]

Attachment: Screenshot of Zoom Page WE menu.

Bug 1357486 has partially broken at least one WE add-on I use.  It is called Zoom Page WE. The drop-down lists on the main menu to change font size and zoom level do not display. The screen shot I provided shows the two areas, when clicked on, should produce a drop-down menu of font sizes and zoom levels.  Setting pref 'extensions.webextensions.remote = false' makes the add-on work correctly.

Comment 1

[Gary [:streetwolf52]]

Found another WE add-on of mine that doesn't produce a drop down list when I click on the down arrow in it's options in the Extensions list.  The add-on is called AutoplayStopper 0.9.8.

Comment 2

[YF (Yang)]

Search Site WE popup don't shows if extensions.webextensions.remote=true. Maybe it is an same problem?

Comment 3

[Gary [:streetwolf52]]

(In reply to YF (Yang) from comment #2)
> Search Site WE popup don't shows if extensions.webextensions.remote=true.
> Maybe it is an same problem?

I'm sure it is as it is by the same developer

Comment 4

[Jim Jeffery not reading bug-mail 1/2/11]

Add ForecastFox 4.1 to the list of broken WE extensions with drop-list.

Comment 5

[John]

I have installed HTTPS Everywhere (webext) on new profile from https://www.eff.org/files/https-everywhere-test/index.html
Popup on clicking extensions button is not showing; in browser console:
"Invalid chrome URI: /".
This is the same problem?


{
  "application": {
    "name": "Firefox",
    "osVersion": "Windows_NT 6.3",
    "version": "56.0a1",
    "buildID": "20170711030203",
    "userAgent": "Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0",
    "safeMode": false,
    "updateChannel": "nightly",
    "supportURL": "https://support.mozilla.org/1/firefox/56.0a1/WINNT/ru/",
    "numTotalWindows": 1,
    "numRemoteWindows": 1,
    "remoteAutoStart": true,
    "autoStartStatus": 1,
    "styloBuild": true,
    "styloDefault": false,
    "styloResult": false,
    "keyGoogleFound": true,
    "keyMozillaFound": true
  },
  "modifiedPreferences": {
    "browser.cache.frecency_experiment": 1,
    "browser.cache.disk.filesystem_reported": 1,
    "browser.cache.disk.smart_size.first_run": false,
    "browser.cache.disk.capacity": 358400,
    "browser.places.smartBookmarksVersion": 8,
    "browser.startup.homepage_override.mstone": "56.0a1",
    "browser.startup.homepage_override.buildID": "20170711030203",
    "browser.urlbar.lastSuggestionsPromptDate": 20170711,
    "browser.urlbar.timesBeforeHidingSuggestionsHint": 1,
    "extensions.lastAppVersion": "56.0a1",
    "media.gmp-widevinecdm.version": "1.4.8.903",
    "media.gmp-manager.buildID": "20170711030203",
    "media.gmp.storage.version.observed": 1,
    "media.gmp-widevinecdm.abi": "x86_64-msvc-x64",
    "media.gmp-gmpopenh264.lastUpdate": 1499785148,
    "media.hardware-video-decoding.failed": false,
    "media.gmp-widevinecdm.lastUpdate": 1499785151,
    "media.gmp-gmpopenh264.version": "1.6",
    "media.gmp-gmpopenh264.abi": "x86_64-msvc-x64",
    "media.gmp-manager.lastCheck": 1499785142,
    "network.predictor.cleaned-up": true,
    "network.cookie.prefsMigrated": true,
    "places.history.expiration.transient_current_max_pages": 104858,
    "plugin.disable_full_page_plugin_for_types": "application/pdf",
    "security.sandbox.content.tempDirSuffix": "{cf923153-fc87-4dc5-8c22-f5eee2319cf9}",
    "services.sync.declinedEngines": ""
  },
  "lockedPreferences": {},
  "javaScript": {
    "incrementalGCEnabled": true
  },
  "accessibility": {
    "isActive": false,
    "forceDisabled": 0,
    "handlerUsed": true
  },
  "libraryVersions": {
    "NSPR": {
      "minVersion": "4.16 Beta",
      "version": "4.16 Beta"
    },
    "NSS": {
      "minVersion": "3.32 Beta",
      "version": "3.32 Beta"
    },
    "NSSUTIL": {
      "minVersion": "3.32 Beta",
      "version": "3.32 Beta"
    },
    "NSSSSL": {
      "minVersion": "3.32 Beta",
      "version": "3.32 Beta"
    },
    "NSSSMIME": {
      "minVersion": "3.32 Beta",
      "version": "3.32 Beta"
    }
  },
  "userJS": {
    "exists": false
  },
  "crashes": {
    "submitted": [
      {
        "id": "bp-540c828b-1ecb-4a88-a8f2-cf06b0170710",
        "date": 1499719855201,
        "pending": false
      },
      {
        "id": "bp-c4eaae2b-f931-44bd-aba3-3e77a0170710",
        "date": 1499645109596,
        "pending": false
      },
      {
        "id": "bp-9b9ad4d9-824e-4d3a-a786-580ba0170709",
        "date": 1499611670199,
        "pending": false
      },
      {
        "id": "bp-a6b0116e-32d6-4438-acc5-3edf40170709",
        "date": 1499590399390,
        "pending": false
      },
      {
        "id": "bp-5b50dbd3-e1a0-4a86-8608-686c80170709",
        "date": 1499590355858,
        "pending": false
      },
      {
        "id": "bp-f6340b16-bf7a-4ff3-83a7-ad2710170709",
        "date": 1499590323356,
        "pending": false
      },
      {
        "id": "bp-e01a6fdd-08c4-4b59-a0f8-fc1020170709",
        "date": 1499590253251,
        "pending": false
      },
      {
        "id": "bp-0ea41d7f-0430-46fe-825e-24dd80170709",
        "date": 1499589943858,
        "pending": false
      },
      {
        "id": "bp-a9943c2f-4319-405c-ac18-175040170708",
        "date": 1499549369755,
        "pending": false
      },
      {
        "id": "bp-06ce766d-da17-46b0-9e1e-f86a90170708",
        "date": 1499541789019,
        "pending": false
      },
      {
        "id": "bp-fae06f22-73b7-40f5-92cd-c50440170708",
        "date": 1499537146740,
        "pending": false
      },
      {
        "id": "bp-b7b34082-29c6-48fd-bd26-ee2740170708",
        "date": 1499536944687,
        "pending": false
      },
      {
        "id": "bp-82d29a51-89c6-4166-88d6-b9d670170708",
        "date": 1499536930426,
        "pending": false
      }
    ],
    "pending": 0
  },
  "sandbox": {
    "contentSandboxLevel": 2,
    "effectiveContentSandboxLevel": 2
  },
  "graphics": {
    "numTotalWindows": 2,
    "numAcceleratedWindows": 2,
    "windowLayerManagerType": "Direct3D 11",
    "windowLayerManagerRemote": true,
    "windowUsingAdvancedLayers": true,
    "currentAudioBackend": "wasapi",
    "adapterDescription": "Intel(R) HD Graphics Family",
    "adapterVendorID": "0x8086",
    "adapterDeviceID": "0x0a16",
    "adapterSubsysID": "131d1043",
    "adapterRAM": "Unknown",
    "adapterDrivers": "igdumdim64 igd10iumd64 igd10iumd64 igdumdim32 igd10iumd32 igd10iumd32",
    "driverVersion": "10.18.10.3308",
    "driverDate": "9-16-2013",
    "adapterDescription2": "NVIDIA GeForce GT 720M",
    "adapterVendorID2": "0x10de",
    "adapterDeviceID2": "0x1140",
    "adapterSubsysID2": "131d1043",
    "adapterRAM2": "2048",
    "adapterDrivers2": "nvd3dumx,nvwgf2umx,nvwgf2umx nvd3dum,nvwgf2um,nvwgf2um",
    "driverVersion2": "21.21.13.7654",
    "driverDate2": "12-29-2016",
    "isGPU2Active": false,
    "direct2DEnabled": true,
    "directWriteEnabled": true,
    "directWriteVersion": "6.3.9600.18696",
    "webgl1Renderer": "Google Inc. -- ANGLE (Intel(R) HD Graphics Family Direct3D11 vs_5_0 ps_5_0)",
    "webgl1Version": "OpenGL ES 2.0 (ANGLE 2.1.0.dec065540d5f)",
    "webgl1DriverExtensions": "GL_ANGLE_depth_texture GL_ANGLE_framebuffer_blit GL_ANGLE_framebuffer_multisample GL_ANGLE_instanced_arrays GL_ANGLE_lossy_etc_decode GL_ANGLE_pack_reverse_row_order GL_ANGLE_request_extension GL_ANGLE_robust_client_memory GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ANGLE_texture_usage GL_ANGLE_translated_shader_source GL_CHROMIUM_bind_generates_resource GL_CHROMIUM_bind_uniform_location GL_CHROMIUM_copy_compressed_texture GL_CHROMIUM_copy_texture GL_CHROMIUM_sync_query GL_EXT_blend_minmax GL_EXT_color_buffer_half_float GL_EXT_debug_marker GL_EXT_discard_framebuffer GL_EXT_disjoint_timer_query GL_EXT_draw_buffers GL_EXT_frag_depth GL_EXT_map_buffer_range GL_EXT_occlusion_query_boolean GL_EXT_read_format_bgra GL_EXT_robustness GL_EXT_sRGB GL_EXT_shader_texture_lod GL_EXT_texture_compression_dxt1 GL_EXT_texture_filter_anisotropic GL_EXT_texture_format_BGRA8888 GL_EXT_texture_rg GL_EXT_texture_storage GL_EXT_unpack_subimage GL_KHR_debug GL_NV_EGL_stream_consumer_external GL_NV_fence GL_NV_pack_subimage GL_NV_pixel_buffer_object GL_OES_EGL_image GL_OES_EGL_image_external GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth32 GL_OES_element_index_uint GL_OES_get_program_binary GL_OES_mapbuffer GL_OES_packed_depth_stencil GL_OES_rgb8_rgba8 GL_OES_standard_derivatives GL_OES_texture_float GL_OES_texture_float_linear GL_OES_texture_half_float GL_OES_texture_half_float_linear GL_OES_texture_npot GL_OES_vertex_array_object ",
    "webgl1Extensions": "ANGLE_instanced_arrays EXT_blend_minmax EXT_color_buffer_half_float EXT_frag_depth EXT_shader_texture_lod EXT_texture_filter_anisotropic EXT_disjoint_timer_query MOZ_debug OES_element_index_uint OES_standard_derivatives OES_texture_float OES_texture_float_linear OES_texture_half_float OES_texture_half_float_linear OES_vertex_array_object WEBGL_color_buffer_float WEBGL_compressed_texture_s3tc WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_depth_texture WEBGL_draw_buffers WEBGL_lose_context MOZ_WEBGL_lose_context MOZ_WEBGL_compressed_texture_s3tc MOZ_WEBGL_depth_texture",
    "webgl1WSIInfo": "EGL_VENDOR: Google Inc. (adapter LUID: 000000000000931c)\nEGL_VERSION: 1.4 (ANGLE 2.1.0.dec065540d5f)\nEGL_EXTENSIONS: EGL_EXT_create_context_robustness EGL_ANGLE_d3d_share_handle_client_buffer EGL_ANGLE_d3d_texture_client_buffer EGL_ANGLE_surface_d3d_texture_2d_share_handle EGL_ANGLE_query_surface_pointer EGL_ANGLE_window_fixed_size EGL_ANGLE_keyed_mutex EGL_ANGLE_surface_orientation EGL_ANGLE_direct_composition EGL_NV_post_sub_buffer EGL_KHR_create_context EGL_EXT_device_query EGL_KHR_image EGL_KHR_image_base EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_get_all_proc_addresses EGL_KHR_stream EGL_KHR_stream_consumer_gltexture EGL_NV_stream_consumer_gltexture_yuv EGL_ANGLE_flexible_surface_compatibility EGL_ANGLE_stream_producer_d3d_texture_nv12 EGL_ANGLE_create_context_webgl_compatibility EGL_CHROMIUM_create_context_bind_generates_resource \nEGL_EXTENSIONS(nullptr): EGL_EXT_client_extensions EGL_EXT_platform_base EGL_EXT_platform_device EGL_ANGLE_platform_angle EGL_ANGLE_platform_angle_d3d EGL_ANGLE_device_creation EGL_ANGLE_device_creation_d3d11 EGL_ANGLE_experimental_present_path EGL_KHR_client_get_all_proc_addresses ",
    "webgl2Renderer": "Google Inc. -- ANGLE (Intel(R) HD Graphics Family Direct3D11 vs_5_0 ps_5_0)",
    "webgl2Version": "OpenGL ES 3.0 (ANGLE 2.1.0.dec065540d5f)",
    "webgl2DriverExtensions": "GL_ANGLE_depth_texture GL_ANGLE_framebuffer_blit GL_ANGLE_framebuffer_multisample GL_ANGLE_instanced_arrays GL_ANGLE_lossy_etc_decode GL_ANGLE_pack_reverse_row_order GL_ANGLE_request_extension GL_ANGLE_robust_client_memory GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ANGLE_texture_usage GL_ANGLE_translated_shader_source GL_CHROMIUM_bind_generates_resource GL_CHROMIUM_bind_uniform_location GL_CHROMIUM_copy_compressed_texture GL_CHROMIUM_copy_texture GL_CHROMIUM_sync_query GL_EXT_blend_minmax GL_EXT_color_buffer_float GL_EXT_color_buffer_half_float GL_EXT_debug_marker GL_EXT_discard_framebuffer GL_EXT_disjoint_timer_query GL_EXT_draw_buffers GL_EXT_frag_depth GL_EXT_map_buffer_range GL_EXT_occlusion_query_boolean GL_EXT_read_format_bgra GL_EXT_robustness GL_EXT_sRGB GL_EXT_shader_texture_lod GL_EXT_texture_compression_dxt1 GL_EXT_texture_filter_anisotropic GL_EXT_texture_format_BGRA8888 GL_EXT_texture_norm16 GL_EXT_texture_rg GL_EXT_texture_storage GL_EXT_unpack_subimage GL_KHR_debug GL_NV_EGL_stream_consumer_external GL_NV_fence GL_NV_pack_subimage GL_NV_pixel_buffer_object GL_OES_EGL_image GL_OES_EGL_image_external GL_OES_EGL_image_external_essl3 GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth32 GL_OES_element_index_uint GL_OES_get_program_binary GL_OES_mapbuffer GL_OES_packed_depth_stencil GL_OES_rgb8_rgba8 GL_OES_standard_derivatives GL_OES_texture_float GL_OES_texture_float_linear GL_OES_texture_half_float GL_OES_texture_half_float_linear GL_OES_texture_npot GL_OES_vertex_array_object ",
    "webgl2Extensions": "EXT_color_buffer_float EXT_texture_filter_anisotropic EXT_disjoint_timer_query MOZ_debug OES_texture_float_linear WEBGL_compressed_texture_s3tc WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_lose_context MOZ_WEBGL_lose_context MOZ_WEBGL_compressed_texture_s3tc",
    "webgl2WSIInfo": "EGL_VENDOR: Google Inc. (adapter LUID: 000000000000931c)\nEGL_VERSION: 1.4 (ANGLE 2.1.0.dec065540d5f)\nEGL_EXTENSIONS: EGL_EXT_create_context_robustness EGL_ANGLE_d3d_share_handle_client_buffer EGL_ANGLE_d3d_texture_client_buffer EGL_ANGLE_surface_d3d_texture_2d_share_handle EGL_ANGLE_query_surface_pointer EGL_ANGLE_window_fixed_size EGL_ANGLE_keyed_mutex EGL_ANGLE_surface_orientation EGL_ANGLE_direct_composition EGL_NV_post_sub_buffer EGL_KHR_create_context EGL_EXT_device_query EGL_KHR_image EGL_KHR_image_base EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_get_all_proc_addresses EGL_KHR_stream EGL_KHR_stream_consumer_gltexture EGL_NV_stream_consumer_gltexture_yuv EGL_ANGLE_flexible_surface_compatibility EGL_ANGLE_stream_producer_d3d_texture_nv12 EGL_ANGLE_create_context_webgl_compatibility EGL_CHROMIUM_create_context_bind_generates_resource \nEGL_EXTENSIONS(nullptr): EGL_EXT_client_extensions EGL_EXT_platform_base EGL_EXT_platform_device EGL_ANGLE_platform_angle EGL_ANGLE_platform_angle_d3d EGL_ANGLE_device_creation EGL_ANGLE_device_creation_d3d11 EGL_ANGLE_experimental_present_path EGL_KHR_client_get_all_proc_addresses ",
    "info": {
      "AzureCanvasBackend (UI Process)": "skia",
      "AzureFallbackCanvasBackend (UI Process)": "cairo",
      "AzureContentBackend (UI Process)": "skia",
      "AzureCanvasBackend": "Direct2D 1.1",
      "AzureContentBackend": "Direct2D 1.1",
      "AzureCanvasAccelerated": 0,
      "ApzWheelInput": 1,
      "ApzDragInput": 1
    },
    "featureLog": {
      "features": [
        {
          "name": "HW_COMPOSITING",
          "description": "Compositing",
          "status": "available",
          "log": [
            {
              "type": "default",
              "status": "available"
            }
          ]
        },
        {
          "name": "D3D11_COMPOSITING",
          "description": "Direct3D11 Compositing",
          "status": "available",
          "log": [
            {
              "type": "default",
              "status": "available"
            }
          ]
        },
        {
          "name": "DIRECT2D",
          "description": "Direct2D",
          "status": "available",
          "log": [
            {
              "type": "default",
              "status": "available"
            }
          ]
        },
        {
          "name": "D3D11_HW_ANGLE",
          "description": "Direct3D11 hardware ANGLE",
          "status": "available",
          "log": [
            {
              "type": "default",
              "status": "available"
            }
          ]
        },
        {
          "name": "GPU_PROCESS",
          "description": "GPU Process",
          "status": "available",
          "log": [
            {
              "type": "default",
              "status": "available"
            }
          ]
        },
        {
          "name": "WEBRENDER",
          "description": "WebRender",
          "status": "opt-in",
          "log": [
            {
              "type": "default",
              "status": "opt-in",
              "message": "WebRender is an opt-in feature"
            }
          ]
        },
        {
          "name": "ADVANCED_LAYERS",
          "description": "Advanced Layers",
          "status": "available",
          "log": [
            {
              "type": "default",
              "status": "available"
            }
          ]
        }
      ],
      "fallbacks": []
    },
    "crashGuards": []
  },
  "experiments": [],
  "extensions": [
    {
      "name": "HTTPS Everywhere",
      "version": "2017.6.9.1337",
      "isActive": true,
      "id": "[e-mail]"
    }
  ],
  "features": [
    {
      "name": "Activity Stream",
      "version": "0.0.0",
      "id": "[e-mail]"
    },
    {
      "name": "Application Update Service Helper",
      "version": "2.0",
      "id": "[e-mail]"
    },
    {
      "name": "Click-to-Play staged rollout",
      "version": "1.2",
      "id": "[e-mail]"
    },
    {
      "name": "Firefox Screenshots",
      "version": "10.3.0",
      "id": "[e-mail]"
    },
    {
      "name": "FlyWeb",
      "version": "1.0.0",
      "id": "[e-mail]"
    },
    {
      "name": "Follow-on Search Telemetry",
      "version": "0.9.1",
      "id": "[e-mail]"
    },
    {
      "name": "Form Autofill",
      "version": "1.0",
      "id": "[e-mail]"
    },
    {
      "name": "Multi-process staged rollout",
      "version": "1.70",
      "id": "[e-mail]"
    },
    {
      "name": "Photon onboarding",
      "version": "0.1",
      "id": "[e-mail]"
    },
    {
      "name": "Pocket",
      "version": "1.0.5",
      "id": "[e-mail]"
    },
    {
      "name": "Presentation",
      "version": "1.0.0",
      "id": "[e-mail]"
    },
    {
      "name": "Shield Recipe Client",
      "version": "55",
      "id": "[e-mail]"
    },
    {
      "name": "Web Compat",
      "version": "1.1",
      "id": "[e-mail]"
    },
    {
      "name": "WebCompat Reporter",
      "version": "1.0.0",
      "id": "[e-mail]"
    }
  ]
}

Comment 6

[Gary [:streetwolf52]]

Folks, no need to spam this report.  It appears all WE add-ons with dropdown menus are broken.  Adding your particular add-on just adds to the clutter.

btw... what is the priority for this report?

Comment 7

[Tomislav Jovanovic :zombie]

Yes, as Gary said, no need to me-too this bug.

And I'd say this is P1 as well, considering it's blocking bug 1357486.

Comment 8

[Gary [:streetwolf52]]

Is the patch to fix this issue going to be released soon?  I ask as a Nighty Tester who needs some of my broken add-ons to be fully functional.  No spam intended.

Comment 9

[Kris Maglione [:kmag]]

Attachment: Bug 1379508: Part 1 - Apply the correct client offsets to remote frameloaders in popup widgets.

On-screen coordinates for points in remote frameloads are calculated relative
to the screen origin of the top-level window, while event coordinates are
calculated relative to the nearest widget. Since popups have their own widgets
separate from the top-level window, their native client offsets have no
particular relation to the origin of the top-level window, and we need to
manually calculate them relative to the origin of the top-level widget
instead.

Review commit: https://reviewboard.mozilla.org/r/157216/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157216/

Comment 10

[Kris Maglione [:kmag]]

Attachment: Bug 1379508: Part 2 - Ignore transforms when calculating child process offsets.

The current code is wrong in several ways when transforms are applied, but
even if it were correct, it would give the wrong behavior. See comment in
patch for more details.

Review commit: https://reviewboard.mozilla.org/r/157218/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157218/

Comment 11

[Kris Maglione [:kmag]]

Attachment: Bug 1379508: Part 3 - Support <select> popups in OOP popup browsers.

Review commit: https://reviewboard.mozilla.org/r/157220/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157220/

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8886417 [details]
Bug 1379508: Part 1 - Apply the correct client offsets to remote frameloaders in popup widgets.

https://reviewboard.mozilla.org/r/157216/#review162504

::: dom/ipc/TabParent.cpp:2005
(Diff revision 1)
> +  return (docWidget->GetClientOffset() -
> +          nsLayoutUtils::WidgetToWidgetOffset(docWidget, widget));

minor nit: I would find this slightly easier to read if you swapped the order of arguments to WidgetToWidgetOffset and changed the minus to a plus. That way WidgetToWidgetOffset returns a (likely positive) distance from widget to docWidget, which you are then adding to docWidget's existing client offset.

Comment 13

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8886418 [details]
Bug 1379508: Part 2 - Ignore transforms when calculating child process offsets.

https://reviewboard.mozilla.org/r/157218/#review162508

I'll give this an r+ if it's green on try, but I'll be honest - my understanding of this is pretty shaky. I don't know if anybody fully understands all of this though. smaug or jimm might be good bets if you want a second review.

::: dom/ipc/TabParent.cpp:1989
(Diff revision 1)
> -  nsPoint pt = nsLayoutUtils::GetEventCoordinatesRelativeTo(widget,
> -                                                            LayoutDeviceIntPoint(0, 0),
> -                                                            targetFrame);
>  
> -  return LayoutDeviceIntPoint::FromAppUnitsToNearest(
> -           pt, targetFrame->PresContext()->AppUnitsPerDevPixel());
> +  nsPresContext* presContext = targetFrame->PresContext();
> +  nsIFrame* rootFrame = presContext->PresShell()->FrameManager()->GetRootFrame();

can rootFrame be null here? Usually stuff returned by "Get" functions (GetRootFrame() in this case) is allowed to be null. If so you might need a guard.

Comment 14

[Kris Maglione [:kmag]]

Comment on attachment 8886418 [details]
Bug 1379508: Part 2 - Ignore transforms when calculating child process offsets.

https://reviewboard.mozilla.org/r/157218/#review162508

> can rootFrame be null here? Usually stuff returned by "Get" functions (GetRootFrame() in this case) is allowed to be null. If so you might need a guard.

It shouldn't be possible for it to be null in this case, since already have a frame in the same presContext, and there needs to be a root frame for it to inherit from. I'm not opposed to adding a guard, though.

Comment 15

[Tomislav Jovanovic :zombie]

Comment on attachment 8886419 [details]
Bug 1379508: Part 3 - Support <select> popups in OOP popup browsers.

https://reviewboard.mozilla.org/r/157220/#review162660

::: browser/components/extensions/test/browser/browser-remote.ini:12
(Diff revision 1)
>  # whether we're running from that directory from head.js
>  install-to-subdir = test-oop-extensions
>  tags = webextensions remote-webextensions
>  skip-if = !e10s
>  
> +[browser_ext_popup_select.js]

What's the reason for this only running in OOP mode?

::: browser/components/extensions/test/browser/browser_ext_popup_select.js:8
(Diff revision 1)
> +"use strict";
> +
> +add_task(async function testPopupSelectPopup() {
> +  let extension = ExtensionTestUtils.loadExtension({
> +    background() {
> +      browser.tabs.query({active: true, currentWindow: true}, tabs => {

nit: async

::: browser/components/extensions/test/browser/browser_ext_popup_select.js:63
(Diff revision 1)
> +    });
> +
> +    let {boxObject} = browser;
> +    let popupRect = selectPopup.getOuterScreenRect();
> +
> +    is(Math.floor(boxObject.screenX + elemRect.left), popupRect.left,

Are all of these coordinates affected by `devicePixelRatio` in the same way?

::: browser/components/extensions/test/browser/browser_ext_popup_select.js:73
(Diff revision 1)
> +    clickBrowserAction(extension);
> +    let browser = await awaitExtensionPanel(extension);

This always looks like a race condition to me :/

Comment 16

[Kris Maglione [:kmag]]

Comment on attachment 8886419 [details]
Bug 1379508: Part 3 - Support <select> popups in OOP popup browsers.

https://reviewboard.mozilla.org/r/157220/#review162660

> What's the reason for this only running in OOP mode?

In-process select popups work differently. They don't use a XUL popup.

> Are all of these coordinates affected by `devicePixelRatio` in the same way?

They all use the same coordinate system, yes.

> This always looks like a race condition to me :/

It's not. The WebExtPopupLoaded event is always dispatched asynchronously.

Comment 17

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/61913ebf8097a519e90c16c3a299858a462d10ab
Bug 1379508: Part 1 - Apply the correct client offsets to remote frameloaders in popup widgets. r=kats

https://hg.mozilla.org/integration/mozilla-inbound/rev/58e9c32d5e53f119a3a909b836496efaf073298b
Bug 1379508: Part 2 - Ignore transforms when calculating child process offsets. r=kats

https://hg.mozilla.org/integration/mozilla-inbound/rev/709cedd7f1bafd43c0be6e6c642d3d497e65c108
Bug 1379508: Part 3 - Support <select> popups in OOP popup browsers. r=zombie

Comment 18

[Kris Maglione [:kmag]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #13)
> I'll give this an r+ if it's green on try, but I'll be honest - my
> understanding of this is pretty shaky. I don't know if anybody fully
> understands all of this though. smaug or jimm might be good bets if you want
> a second review.

Landing now with just your review, since it fixes problems for nightly users, but leaving the review flag for jimm in case it needs a follow-up.

Comment 19

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/41b75de6ceb270bf87f1b965052d37cdc64f511a
Bug 1379508: Follow-up: Disable select popup test on OS-X for alignment issues.

Comment 20

[Gary [:streetwolf52]]

Attachment: Zoom Page WE after this patch

Getting close but no cigar as they say.  As seen in the screenshot there is a small popup 'above' the zoom percentage.  Same thing happens to the font size.

The other add-on I have does seem to work however, Textarea Cache Lite.  It doesn't having the same sort of dropdown menu but it does work now.

Comment 21

[Gary [:streetwolf52]]

Another WE add-on, AutoplayStopper, doesn't display it's dropdown lists at all when the down arrow is clicked.

Comment 22

[Kris Maglione [:kmag]]

(In reply to Gary [:streetwolf] from comment #20)
> Getting close but no cigar as they say.  As seen in the screenshot there is
> a small popup 'above' the zoom percentage.  Same thing happens to the font
> size.

That's expected. Select popups for remote frames are constrained to the viewport of the page. Feel free to file a separate bug if you think that should be changed.

Comment 23

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/43676eab0672b3e86b33dcad9d672ac07e4c562f
Bug 1379508: Follow-up: Disable select popup test on Linux for frequent intermittent failures.

Comment 24

[Gary [:streetwolf52]]

Kris.

It also appears your fix screws up resizing windows for the WE add-ons I use. One window just disappears when I try to drag the resize icon on the bottom right.  Another one, on it's Extensions page, makes the window one line. Is this expected behavior too?

Comment 25

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/61913ebf8097
https://hg.mozilla.org/mozilla-central/rev/58e9c32d5e53
https://hg.mozilla.org/mozilla-central/rev/709cedd7f1ba
https://hg.mozilla.org/mozilla-central/rev/41b75de6ceb2
https://hg.mozilla.org/mozilla-central/rev/43676eab0672

Comment 26

[Jim Jeffery not reading bug-mail 1/2/11]

Just tested the latest m-c win32 build with this patch and ForecastFox is still not showing drop-down.

Comment 27

[YF (Yang)]

(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #26)
> Just tested the latest m-c win32 build with this patch and ForecastFox is
> still not showing drop-down.

You should try the tomorrow Nightly (m-c). Check the push date on about:buildconfig and comment 25.

Comment 28

[Gary [:streetwolf52]]

I'm on inbound with the patch and as I said in a previous comment things are not as they were.  The dropdown looks different in some instances or they still don't work.

Comment 31

[Jim Mathies [:jimm]]

Comment on attachment 8886418 [details]
Bug 1379508: Part 2 - Ignore transforms when calculating child process offsets.

https://reviewboard.mozilla.org/r/157218/#review163088

Comment 32

[Jim Mathies [:jimm]]

Comment on attachment 8886418 [details]
Bug 1379508: Part 2 - Ignore transforms when calculating child process offsets.

https://reviewboard.mozilla.org/r/157218/#review162508

I know very little about the transforms stuff tbh. I know about widget offsets but that's not relevant here. sorry.

Comment 33

[Liz Henry (:lizzard) (relman/hg->git project)]

Setting the status flag back to affected and reopening the bug, since there were reports of the issue still existing and there's now a new patch to land.

Comment 34

[Kris Maglione [:kmag]]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #33)
> Setting the status flag back to affected and reopening the bug, since there
> were reports of the issue still existing and there's now a new patch to land.

The reports were of other issues. This issue is fixed. And the follow-up has landed, in any case.

Comment 35

[CosminB]

Attachment: TooltipIssue.gif

Hello guys, 

It seems I encountered the Bug 1380294 on Firefox 56.0a1 (2017-07-20) under Win7 64-bit , please have a look at the attached video.

Comment 36

[CosminB]

Attachment: Videos.zip

I tested some WebExtensions like: Forecastfox (fix version), Search Site WE, Zoom Page WE on Firefox 56.0a1(2017-07-24) on Wind 7 64-bit, Wind 10 32-bit, Wind 10 64-bit, Ubuntu 16.04 32-bit and Mac OS X 10.12.3.

Forecastfox (fix version) is not working on Wind 10 32-bit, Wind 10 64-bit, Ubuntu 16.04 32-bit and Mac OS X 10.12.3

At some point the extension will crash on Wind 10 32-bit 
https://crash-stats.mozilla.com/report/index/d780985d-3741-4d61-9c4d-13ceb0170724

Zoom Page WE, does not display the selected value correctly in the drop-down list after reset.

Do you have any opinion about these issues Kris?

Please see the attached videos.

Comment 37

[dw-dev]

(In reply to Kris Maglione [:kmag] from comment #22)
> (In reply to Gary [:streetwolf] from comment #20)
> > Getting close but no cigar as they say.  As seen in the screenshot there is
> > a small popup 'above' the zoom percentage.  Same thing happens to the font
> > size.
> 
> That's expected. Select popups for remote frames are constrained to the
> viewport of the page. Feel free to file a separate bug if you think that
> should be changed.

Kris,

I'm fairly sure that this fix does not work correctly and has introduced new problems.

Specifically, I am experiencing problems with the select drop-downs in two of my WebExtensions add-ons: Zoom Page WE and Tile Pages WE.

In the case of Zoom Page WE, the select element is inside the browserAction popup. With Firefox 54, the select drop-down is allowed to extend outside the browserAction popup window. With Nightly 56, I understand that the select drop-down should be constrained to the browserAction popup window. However, the select drop-down is NOT displayed at all, and even if I make the browserAction popup window big enough to contain the entire select drop-down, it still is NOT displayed.

In the case of Tile Pages WE, the select elements are inside the add-on Options window. With Firefox 54, the select drop-downs are displayed correctly.  With Nightly 56, the select drop-downs are NOT displayed, even though the add-on Options window is definitely big enough to contain the select drop-downs.

I cannot believe that this is the new expected behaviour.

Do I need to raise a new bug?

Comment 38

[dw-dev]

Kris,

Separately to the bugs reported in Comment 37, there one question I forgot to ask ... 

Is there a technical reason why select drop-downs (and popups in general) are not allowed to extend outside the parent page/window?  Or is it a user interface design decision?

Either way, is there any chance of getting this decision changed?

Comment 39

[dw-dev]

I've looked through a few more WebExtenions add-ons and very quickly found two more add-ons where the select drop-downs do not display in the add-ons Options window: 'LanguageTool Grammar Checker' and 'Page Translator'.

Comment 41

[Kris Maglione [:kmag]]

(In reply to dw-dev from comment #38)
> Is there a technical reason why select drop-downs (and popups in general)
> are not allowed to extend outside the parent page/window?  Or is it a user
> interface design decision?

Not a technical reason, no.

> Either way, is there any chance of getting this decision changed?

Feel free to file a separate bug.