Closed
Bug 1381355
Opened 7 years ago
Closed 7 years ago
Fx 56 tour notifications use the wrong icons
Categories
(Firefox :: General, enhancement, P1)
Tracking
()
VERIFIED
FIXED
Firefox 56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: verdi, Assigned: rexboy)
References
Details
(Whiteboard: [photon-onboarding])
Attachments
(2 files)
The new user onboarding notifications for Firefox 56 use the overlay navigation icons instead of the icons from the spec (bug 1357668). We should be using these icons - attachment 8877012 [details]
Assignee | ||
Updated•7 years ago
|
Whiteboard: [photon-onboarding] → [photon-onboarding][triage]
Assignee | ||
Comment 1•7 years ago
|
||
This is because icons used to be the same for overlay and notification in a period; I can change it then.
Flags: qe-verify+
Priority: -- → P1
Whiteboard: [photon-onboarding][triage] → [photon-onboarding]
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → rexboy
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•7 years ago
|
||
It's a trivial one with simple image adding & css rule changes.
Fischer and Mossop would take a look on it?
Assignee | ||
Updated•7 years ago
|
Target Milestone: --- → Firefox 56
Updated•7 years ago
|
Status: NEW → ASSIGNED
QA Contact: jwilliams
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8886940 [details]
Bug 1381355 - Use individual icons for Fx 56 tour notifications.
https://reviewboard.mozilla.org/r/157706/#review162964
Attachment #8886940 -
Flags: review?(dtownsend) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•7 years ago
|
Attachment #8886940 -
Flags: review?(fliu)
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/bbbc2d36f43e
Use individual icons for Fx 56 tour notifications. r=mossop
Keywords: checkin-needed
Comment 6•7 years ago
|
||
bugherder |
You need to log in
before you can comment on or make changes to this bug.
Description
•