1381355 - Fx 56 tour notifications use the wrong icons

Status: VERIFIED FIXED

(Firefox :: General, enhancement, P1)

Description

[Verdi [:verdi] Best to slack me]

Attachment: notification-uses-wrong-icon.png

The new user onboarding notifications for Firefox 56 use the overlay navigation icons instead of the icons from the spec (bug 1357668). We should be using these icons -  attachment 8877012 [details]

Comment 1

[KM Lee [:rexboy] (inactivate after Sep. 22)]

This is because icons used to be the same for overlay and notification in a period; I can change it then.

Comment 2

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: Bug 1381355 - Use individual icons for Fx 56 tour notifications.

Review commit: https://reviewboard.mozilla.org/r/157706/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157706/

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

It's a trivial one with simple image adding & css rule changes.
Fischer and Mossop would take a look on it?

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 8886940 [details]
Bug 1381355 - Use individual icons for Fx 56 tour notifications.

https://reviewboard.mozilla.org/r/157706/#review162964

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbbc2d36f43e
Use individual icons for Fx 56 tour notifications. r=mossop

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bbbc2d36f43e

Comment 7

[Justin [:JW_SoftvisionQA]]

I have verified this issue has been fixed.