Fx 56 tour notifications use the wrong icons

VERIFIED FIXED in Firefox 56

Status

()

P1
normal
VERIFIED FIXED
a year ago
a year ago

People

(Reporter: verdi, Assigned: rexboy)

Tracking

53 Branch
Firefox 56
Points:
---
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [photon-onboarding])

Attachments

(2 attachments)

(Reporter)

Description

a year ago
Created attachment 8886898 [details]
notification-uses-wrong-icon.png

The new user onboarding notifications for Firefox 56 use the overlay navigation icons instead of the icons from the spec (bug 1357668). We should be using these icons -  attachment 8877012 [details]
Whiteboard: [photon-onboarding] → [photon-onboarding][triage]
This is because icons used to be the same for overlay and notification in a period; I can change it then.
Flags: qe-verify+
Priority: -- → P1
Whiteboard: [photon-onboarding][triage] → [photon-onboarding]
Assignee: nobody → rexboy
Comment hidden (mozreview-request)
It's a trivial one with simple image adding & css rule changes.
Fischer and Mossop would take a look on it?
Target Milestone: --- → Firefox 56

Updated

a year ago
Status: NEW → ASSIGNED
QA Contact: jwilliams

Comment 4

a year ago
mozreview-review
Comment on attachment 8886940 [details]
Bug 1381355 - Use individual icons for Fx 56 tour notifications.

https://reviewboard.mozilla.org/r/157706/#review162964
Attachment #8886940 - Flags: review?(dtownsend) → review+
Keywords: checkin-needed
Attachment #8886940 - Flags: review?(fliu)

Comment 5

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/bbbc2d36f43e
Use individual icons for Fx 56 tour notifications. r=mossop
Keywords: checkin-needed

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bbbc2d36f43e
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Depends on: 1386454
I have verified this issue has been fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.