1381366 - The onboarding tour notifications and tour dialog close buttons should have a tooltip

Status: VERIFIED FIXED

(Firefox :: General, defect, P3)

Description

[Verdi [:verdi] Best to slack me]

Attachment: tooltip.png

I inadvertently left out a tooltip to be shown on hover of the close button in the Firefox 56 tour notifications. It should read, "Don't show this again"

Comment 1

[Fischer [:Fischer]]

(In reply to Verdi [:verdi] from comment #0)
> Created attachment 8886905 [details]
> tooltip.png
> 
> I inadvertently left out a tooltip to be shown on hover of the close button
> in the Firefox 56 tour notifications. It should read, "Don't show this again"
Hi Verdi,
Just afraid that "Don't show this again" may cause some confusion because the next notification for next tour would still be prompted after click it. Not sure if user would think why this notification is showing again. Let's have a discussion on the next con-call meeting.

Comment 2

[Francis Lee [:frlee]]

based on discussion happened in the weekly meeting with PM/UX, we should see user's feedback before making any further change on the existing design. change it to P3 and it will be revised in Fx57 nightly.

Comment 4

[Verdi [:verdi] Best to slack me]

(In reply to Fischer [:Fischer] from comment #1)
> (In reply to Verdi [:verdi] from comment #0)
> > Created attachment 8886905 [details]
> > tooltip.png
> > 
> > I inadvertently left out a tooltip to be shown on hover of the close button
> > in the Firefox 56 tour notifications. It should read, "Don't show this again"
> Hi Verdi,
> Just afraid that "Don't show this again" may cause some confusion because
> the next notification for next tour would still be prompted after click it.
> Not sure if user would think why this notification is showing again. Let's
> have a discussion on the next con-call meeting.

Michelle and I talked this over and decided we should use "Dismiss" instead.

Comment 5

[Fischer [:Fischer]]

Per the bug 1377283 comment 3, the tour dialog close button's tooltip is "Close".

Comment 6

[Fischer [:Fischer]]

Attachment: Bug 1381366 - The onboarding tour notifications and tour dialog close buttons should have a tooltip,

Review commit: https://reviewboard.mozilla.org/r/161878/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/161878/

Comment 7

[Dave Townsend [:mossop]]

Comment on attachment 8890693 [details]
Bug 1381366 - The onboarding tour notifications and tour dialog close buttons should have a tooltip,

https://reviewboard.mozilla.org/r/161878/#review167600

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8d5f44ef5eb
The onboarding tour notifications and tour dialog close buttons should have a tooltip, r=mossop

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e8d5f44ef5eb

Comment 10

[Justin [:JW_SoftvisionQA]]

I can confirm that this is fixed.

Comment 11

[Justin [:JW_SoftvisionQA]]

I have verified that the x on the notification has a tooltip on Win 10 x64, Win 7 x32, Ubuntu 16.04 x32, and Mac 10.12 with Firefox 58.