1377496 - Tours(onboarding-notification-bar) re-appears when open about:home despite having closed it with a close button in the past

Status: RESOLVED DUPLICATE of bug 1381366

(Firefox :: General, defect, P1)

Description

[Alice0775 White]

Reproducible : always

Steps To Reproduce:
1. Close tours(onboarding-notification-bar) with [x] close button
   --- observe the notification disappears as expected
2. Open about:home with middle mouse click on Home toolbutton
   --- observe the notification bar
3. Repeat from step1

Actual Results:
The notification bar pops up again and again

Expected results:
Once you have closed the notification bar, the notification bar should not pop up again.

Comment 1

[Francis Lee [:frlee]]

its by design.
if you do not wish to see any tour notification, you can click the top-left firefox head icon and choose 'marks all as completed, and hide the tour'. then the tour notification won't show up when you open new tab anymore.

thank you very much

Comment 2

[:Gijs (he/him)]

(In reply to Francis Lee [:frlee] from comment #1)
> its by design.
> if you do not wish to see any tour notification, you can click the top-left
> firefox head icon and choose 'marks all as completed, and hide the tour'.
> then the tour notification won't show up when you open new tab anymore.

If you don't want to engage with the tour, this is completely unintuitive - you have no reason to click the fox. A fox doesn't mean 'close' or 'go away', the [x] does.

Can we consider making the second click on the [x] do the same thing, or prompt to do it, or something?

Comment 4

[Marco Castelluccio [:marco]]

(In reply to Francis Lee [:frlee] from comment #1)
> if you do not wish to see any tour notification, you can click the top-left
> firefox head icon and choose 'marks all as completed, and hide the tour'.
> then the tour notification won't show up when you open new tab anymore.

Honestly, it was very hard to find this out. I can see a lot of people never finding this out and always being annoyed by the onboarding bar.

Comment 6

[Dão Gottwald [:dao]]

<dao> Is it intentional that the "new to nightly?" banner pops up every time you open a new tab?
it's kind of annoying
and by kind of I mean very
<Gijs> dao: there is a way to dismiss it
dao: https://bugzilla.mozilla.org/show_bug.cgi?id=1377496#c2
<firebot> Bug 1377496 — INVALID, [e-mail] — Tours(onboarding-notification-bar)  re-appears when open about:home despite having closed it with a 
<Gijs> dao: but the fact that nobody is finding it, I think pretty much means it's not obvious enough.
<dao> also, not sure why we ask "new to nightly?" in the first place in years old profiles. I assume or hope that's temporary
<dao> the tour also suggests making nightly my default browser and setting up sync, both of which I have already done

Re-nominating for triage to make sure this gets proper attention from the team.

Actually I don't see the onboarding tour anymore in the latest nightly with my default profile. Has either this or the fact that we show the bar in used profiles been fixed elsewhere?

Comment 7

[:Gijs (he/him)]

I mid-aired with Dão, but was going to do the same thing. This has now repeatedly come up on IRC, slack and here, from experienced Firefox users/developers. If they/we can't figure it out, I don't see how users would.

Comment 8

[[e-mail]]

> <Gijs> dao: there is a way to dismiss it
> dao: https://bugzilla.mozilla.org/show_bug.cgi?id=1377496#c2
> <firebot> Bug 1377496 — INVALID, [e-mail] —
> Tours(onboarding-notification-bar)  re-appears when open about:home despite
> having closed it with a 
> <Gijs> dao: but the fact that nobody is finding it, I think pretty much
> means it's not obvious enough.

I've passed the issue to UX/PM and hope they could find a better way to addess that.
By design the same notification should shown 8 times or 5 days when user does not interact with it.(not implemented yet, now it will keep showing the same notification if the tour does not been marked as completed) 

> <dao> also, not sure why we ask "new to nightly?" in the first place in
> years old profiles. I assume or hope that's temporary
> <dao> the tour also suggests making nightly my default browser and setting
> up sync, both of which I have already done
> 
> 
> Actually I don't see the onboarding tour anymore in the latest nightly with
> my default profile. Has either this or the fact that we show the bar in used
> profiles been fixed elsewhere?

Yes its been fixed in Bug 1367696 - show new user/update user, the `new user tour` and the notification should now only shown to user with the new profile.

Comment 9

[Mats Palmgren (inactive)]

Fred, the main issue with this notification bar is that keeps coming back
in new tabs even after clicking the X button to close it.  Clicking the
X button once should be enough to hide it *permanently*.  Please make that
clear to UX.  Thanks.

Comment 10

[[e-mail]]

Copy Verdi's comment from slack
https://mozilla.slack.com/archives/C5YTS7GMD/p1499361906794772

"Thanks for testing the onboarding tour and sorry it's so annoying right now. The issues with the notifications are things we're working on. If you click the X on a notification, that notification is supposed to go away forever. We'll also be getting rid of the slide up animation. Let us know if you run into other issues. "

Comment 11

[[e-mail]]

remove notification animation is deal in bug 1377433

Comment 12

[Fischer [:Fischer]]

(In reply to Alice0775 White from comment #0)
> Reproducible : always
> 
> Steps To Reproduce:
> 1. Close tours(onboarding-notification-bar) with [x] close button
>    --- observe the notification disappears as expected
> 2. Open about:home with middle mouse click on Home toolbutton
>    --- observe the notification bar
> 3. Repeat from step1
> 
> Actual Results:
> The notification bar pops up again and again
> 
> Expected results:
> Once you have closed the notification bar, the notification bar should not
> pop up again.
Once the bug 1372067 is landed, this issue should be mitigated a bit.
There are 6 tours and each tour is having its own notification.
After the bug 1372067, tour notification would be removed forever if clicking the X close button.
However, there are 6 tours so at least 6 times of notification would appear.

Comment 13

[Mats Palmgren (inactive)]

> However, there are 6 tours so at least 6 times of notification would appear.

Honestly, I don't think that's good enough.  You'll still make a lot of people
raging mad about having to "click away" this Clippy multiple times...
https://en.wikipedia.org/wiki/Clippy

Comment 14

[Verdi [:verdi] Best to slack me]

There are(In reply to Fred Lin [:gasolin] from comment #10)
> Copy Verdi's comment from slack
> https://mozilla.slack.com/archives/C5YTS7GMD/p1499361906794772
> 
> "Thanks for testing the onboarding tour and sorry it's so annoying right
> now. The issues with the notifications are things we're working on. If you
> click the X on a notification, that notification is supposed to go away
> forever. We'll also be getting rid of the slide up animation. Let us know if
> you run into other issues. "

There are also a couple of other missing pieces here. The notification close button needs a tool tip and the Fox that opens the overlay needs a speech bubble to help you understand it's connected to those notifications. We should fix all of these things and do some user testing.

Comment 15

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Verdi [:verdi] from comment #14)
> There are(In reply to Fred Lin [:gasolin] from comment #10)
> > Copy Verdi's comment from slack
> > https://mozilla.slack.com/archives/C5YTS7GMD/p1499361906794772
> > 
> > "Thanks for testing the onboarding tour and sorry it's so annoying right
> > now. The issues with the notifications are things we're working on. If you
> > click the X on a notification, that notification is supposed to go away
> > forever. We'll also be getting rid of the slide up animation. Let us know if
> > you run into other issues. "
> 
> There are also a couple of other missing pieces here. The notification close
> button needs a tool tip and the Fox that opens the overlay needs a speech
> bubble to help you understand it's connected to those notifications. We
> should fix all of these things and do some user testing.

According to Fischer this either comment 10 or comment 14 was in the original spec. We are not in a position of adding more feature into the scope. I tend to think we should only address this bug with comment 10 and *not* anything in comment 14. Verdi, is that ok to you?

You would still need to update the spec so that QA can properly verify this behavior. Thanks.

Comment 16

[Verdi [:verdi] Best to slack me]

(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #15) 
> According to Fischer this either comment 10 or comment 14 was in the
> original spec. We are not in a position of adding more feature into the
> scope. I tend to think we should only address this bug with comment 10 and
> *not* anything in comment 14. Verdi, is that ok to you?
> 

To make sure we're talking about the same things...

Items in comment 10:
* If you click the X on a notification, that notification is supposed to go away forever. 
* We'll also be getting rid of the slide up animation.

Yes, let's please do these two things.

Items in comment 14:
* The notification close button needs a tool tip - this is indeed not in the spec, that was my oversight.
* The Fox that opens the overlay needs a speech bubble to help you understand it's connected to those notifications. - this is in the original spec (it was one of the clean up items I mentioned in our last meeting)

I hope we can fit the speech bubble in. We should do user testing on the notification. I'm worried that people will not understand that clicking the X on the notification will only remove that one notification and not all notifications. 

> You would still need to update the spec so that QA can properly verify this
> behavior. Thanks.

Will do.

Comment 17

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Verdi [:verdi] from comment #16)
> To make sure we're talking about the same things...
> 
> Items in comment 10:
> * If you click the X on a notification, that notification is supposed to go
> away forever. 
> * We'll also be getting rid of the slide up animation.
>
> Yes, let's please do these two things.
>

Cool. Fisher, are these works represented in this bug or there are other bugs already covering these?
 
> Items in comment 14:
> * The notification close button needs a tool tip - this is indeed not in the
> spec, that was my oversight.

Could you provide the string? It's fine if we are looking at generic <button title="foobar"> tool tip which involves no UI work.

> * The Fox that opens the overlay needs a speech bubble to help you
> understand it's connected to those notifications. - this is in the original
> spec (it was one of the clean up items I mentioned in our last meeting)

Sure. Given it's already in the spec let's get it done also.

> I hope we can fit the speech bubble in. We should do user testing on the
> notification. I'm worried that people will not understand that clicking the
> X on the notification will only remove that one notification and not all
> notifications.

As long as user testing does not result late change on Fx56 behavior, cool.

Comment 18

[Fischer [:Fischer]]

(In reply to Verdi [:verdi] from comment #16)
> To make sure we're talking about the same things...
> 
> Items in comment 10:
> * If you click the X on a notification, that notification is supposed to go away forever. 
This is addressed by bug 1372067 which is about to land.

> * We'll also be getting rid of the slide up animation.
This is addressed by bug 1377433

> * The Fox that opens the overlay needs a speech bubble to help you understand it's connected to those notifications. - this is in the original spec (it was one of the clean up items I mentioned in our last meeting)
Bug 1357017 is in charge of this speech bubble.

> We should do user testing on the notification. I'm worried that people will not understand that clicking the
> X on the notification will only remove that one notification and not all notifications. 
Yes, this is a concern. See the comment 13.

Comment 19

[Fischer [:Fischer]]

(In reply to Fischer [:Fischer] from comment #18)
> (In reply to Verdi [:verdi] from comment #16)
> > We should do user testing on the notification. I'm worried that people will not understand that clicking the
> > X on the notification will only remove that one notification and not all notifications. 
> Yes, this is a concern. See the comment 13.
The bug 1381366 is handling the notification close button tooltip so duplicate it.