stylo: panic "Restyle damage should be empty if the element was not restyled" on FastMail

ASSIGNED
Assigned to

Status

()

Core
CSS Parsing and Computation
P1
normal
ASSIGNED
7 days ago
4 days ago

People

(Reporter: heycam, Assigned: hiro)

Tracking

(Blocks: 1 bug, {crash})

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

7 days ago
Switching between mail folders on FastMail, with Hiro's patches from bug 1378064 applied, I sometimes run into this assertion:

thread '<unnamed>' panicked at 'Restyle damage should be empty if the element was not restyled', /z/moz/d/servo/ports/geckolib/glue.rs:2745

in Servo_TakeChangeHint.
Keywords: crash
Priority: -- → P1
(Assignee)

Updated

6 days ago
Blocks: 1380897
(Assignee)

Updated

6 days ago
Assignee: nobody → hikezoe
Status: NEW → ASSIGNED
(Assignee)

Comment 1

6 days ago
I noticed that the damage comes from ServoRestyleManager::AttributeChanged() (thanks Cameron for the confirmation).
I don't yet have any good ideas to preserve these restyle hints and change hints during animation-only restyle for throttled animations.
(Assignee)

Comment 2

6 days ago
(In reply to Hiroyuki Ikezoe (:hiro) from comment #1)
> I noticed that the damage comes from ServoRestyleManager::AttributeChanged()
> (thanks Cameron for the confirmation).
> I don't yet have any good ideas to preserve these restyle hints and change
> hints during animation-only restyle for throttled animations.

Err, we don't need to care about those restyle hints, we have already preserved restyle hints other than animation hints.
No longer blocks: 1380897
You need to log in before you can comment on or make changes to this bug.