1381501 - 0.9% installer size (android-4-0-armv7-api15) regression on push 2b56008c121a2b56a10a4de404626b286513d6a5 (Fri Jul 14 2017)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[William Lachance (:wlach)]

:jwu, your push for bug 1366669 caused the apk size to noticeably increase. Is there anything that can be done to mitigate this? Maybe re-compress some of the new image resources?

--

We have detected a build metrics regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=2b56008c121a2b56a10a4de404626b286513d6a5

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

  1%  installer size summary android-4-0-armv7-api15 opt      36,529,347.67 -> 36,858,752.08


You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=8006

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Build_Metrics

Comment 1

[Jing-wei Wu [:jwu]]

Looks like the apk size is increased because of the following 4 images:

    - australis/res/drawable-hdpi/firefox_logo.png
    - australis/res/drawable-xhdpi/firefox_logo.png
    - australis/res/drawable-xxhdpi/firefox_logo.png
    - australis/res/drawable-xxxhdpi/firefox_logo.png

They are redundant and need to be removed since we already have up-to-date logo icons in different branding folders.

Comment 2

[Jing-wei Wu [:jwu]]

Attachment: Bug 1381501 - Remove redundant logo icons in australis resource folders.

We already have logo icons in different branding folders, the following 4 icons are redundant and
should be removed to prevent increasing APK size.

  - australis/res/drawable-hdpi/firefox_logo.png
  - australis/res/drawable-xhdpi/firefox_logo.png
  - australis/res/drawable-xxhdpi/firefox_logo.png
  - australis/res/drawable-xxxhdpi/firefox_logo.png

Review commit: https://reviewboard.mozilla.org/r/158672/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158672/

Comment 3

[Julian Chu [:walkingice]]

Comment on attachment 8887750 [details]
Bug 1381501 - Remove redundant logo icons in australis resource folders.

https://reviewboard.mozilla.org/r/158672/#review163928

Comment 4

[Nevin Chen(Not active on Bugzilla)]

Oh I've already done it in Bug 1378175 and it's landed. Maybe that should be fine?

Comment 5

[Jing-wei Wu [:jwu]]

The patch for Bug 1378175 removed logo images in photon resource folders, but this one removes logo images in australis resource folders. Both patches are necessarily needed.

Comment 6

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8887750 [details]
Bug 1381501 - Remove redundant logo icons in australis resource folders.

https://reviewboard.mozilla.org/r/158672/#review163998

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ba83cd42407
Remove redundant logo icons in australis resource folders. r=nechen,walkingice

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7ba83cd42407

Comment 9

[William Lachance (:wlach)]

Hooray the regression was fixed:

== Change summary for alert #8066 (as of July 19 2017 13:38 UTC) ==

Improvements:

  1%  installer size summary android-4-0-armv7-api15 opt      36,824,931.50 -> 36,493,032.83

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=8066