Closed
Bug 1381511
Opened 7 years ago
Closed 7 years ago
Autophone - do not consider treeherder client id to be sensitive data
Categories
(Testing Graveyard :: Autophone, enhancement)
Testing Graveyard
Autophone
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bc, Assigned: bc)
References
Details
Attachments
(1 file)
|
723 bytes,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
https://github.com/mozilla/autophone/blob/master/options.py#L48 defines the data items which are considered sensitive. These are used to exclude messages which contain sensitive data from being logged and made public in https://github.com/mozilla/autophone/blob/master/sensitivedatafilter.py#L19 This is a problem due to the simple means by which we test for inclusion of the sensitive data. We use a simple |data in message| test which results in false positives if the data is a generic enough string. Unless we change the user names etc to be completely unique, I intend to just remove the items which aren't that sensitive and only keep the passwords.
|
Assignee | |
Comment 1•7 years ago
|
||
It's really the treeherder client id that is the problem.
Summary: Autophone - do not consider user account names to be sensitive data → Autophone - do not consider treeherder client id to be sensitive data
|
|
Assignee | |
Comment 2•7 years ago
|
||
Attachment #8887085 -
Flags: review?(jmaher)
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8887085 [details] [diff] [review] bug-1381511-v1.patch Review of attachment 8887085 [details] [diff] [review]: ----------------------------------------------------------------- face palm
Attachment #8887085 -
Flags: review?(jmaher) → review+
|
|
Assignee | |
Comment 4•7 years ago
|
||
https://github.com/mozilla/autophone/commit/95fcfe077e50442527b5592c13e7a517ecc968d3 deployed 2017-07-17 08:36
|
||
Updated•2 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•