1381520 - we run talos on mozilla-beta for win10 opt and win10 pgo, we should only run on pgo

Status: RESOLVED FIXED

(Testing :: Talos, enhancement)

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

we run talos twice:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=1d9f391a6ccfee8508d744ab19c5164ecf55da76&filter-searchStr=win%20x64%20talos&selectedJob=114398984

we reference two different builds for opt and pgo (which sounds right), but the numbers are identical, so is the frequency.  Inspecting the builds, I see they are coming from a taskcluster task:
Downloading https://queue.taskcluster.net/v1/task/Ma6VylREStSWYijw4ImZvw/artifacts/public/build/firefox-55.0.en-US.win64.zip to C:\slave\test\build\firefox-55.0.en-US.win64.zip

but that task is a buildbot s3 upload, not a build.  Given that we are duplicating tests and data, we really need to turn off the 'opt' version of these.

now to figure out where in buildbot-configs this is located at.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

:Callek, would you know where inside of buildbot_configs we would be setting pgo tests for mozilla-beta?  I am not having any luck finding out where to specify to turn off opt tests on mozilla-beta and leave pgo on.

Comment 3

[Chris AtLee [:catlee]]

The PGO data is from the devedition build. I'm not sure why it's reporting as PGO here.

Comment 4

[Chris AtLee [:catlee]]

Given that the BB jobs are going away next cycle (in a few weeks), we should make sure this is fixed as part of our migration work. I don't think it's worth it for the 55 cycle.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

this is still occurring today after we have started 56 on mozilla-beta, :catlee, is this something we should be working on, or the work of running talos on pgo only?

Comment 6

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1381520 - Stop making duplicated builds on beta for win{32,64} + mac

Review commit: https://reviewboard.mozilla.org/r/164486/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/164486/

Comment 7

[Justin Wood (:Callek)]

Comment on attachment 8893381 [details]
Bug 1381520 - Stop making duplicated builds on beta for win{32,64} + mac

https://reviewboard.mozilla.org/r/164486/#review169766

::: taskcluster/taskgraph/target_tasks.py:266
(Diff revision 1)
>              return False
>          platform = task.attributes.get('build_platform')
> -        if platform in ('linux64-pgo', 'linux-pgo', 'android-api-15-nightly',
> -                        'android-x86-nightly'):
> +        if platform in (
> +                # On beta, Nightly builds are already PGOs
> +                'linux-pgo', 'linux64-pgo',
> +                'win32-pgo', 'win64-pgo',

also osx

::: taskcluster/taskgraph/target_tasks.py:271
(Diff revision 1)
> +                'win32-pgo', 'win64-pgo',
> +                'android-api-15-nightly', 'android-x86-nightly'
> +                ):
>              return False
> +
>          if platform in ('linux64', 'linux'):

Also win/osx here

Comment 8

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8893381 [details]
Bug 1381520 - Stop making duplicated builds on beta for win{32,64} + mac

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/164486/diff/1-2/

Comment 9

[Johan Lorenzo [:jlorenzo]]

Attachment: Deleted jobs (diff)

Comment 10

[Justin Wood (:Callek)]

Comment on attachment 8893381 [details]
Bug 1381520 - Stop making duplicated builds on beta for win{32,64} + mac

https://reviewboard.mozilla.org/r/164486/#review169786

Comment 11

[Justin Wood (:Callek)]

Comment on attachment 8893381 [details]
Bug 1381520 - Stop making duplicated builds on beta for win{32,64} + mac

https://reviewboard.mozilla.org/r/164486/#review169766

> also osx

This actually wasn't an issue afterall (we don't do pgo build jobs on OSX)

Comment 12

[Johan Lorenzo [:jlorenzo]]

Release promotion will fail if attachment 8893381 [details] lands on beta before bug 1382240 is merged.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d9b4108bf57
Stop making duplicated builds on beta for win{32,64} + mac r=Callek

Comment 14

[Joel Maher ( :jmaher ) (UTC -8)]

I see the latest push only has opt builds on beta!  I know previously linux64-opt was really pgo, I assume win7/win10 opt is also pgo as well?  If this is the case, then I think our work is done

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0d9b4108bf57

Comment 16

[Johan Lorenzo [:jlorenzo]]

(In reply to Joel Maher ( :jmaher) (UTC-9) from comment #14)
> I know previously linux64-opt was really pgo, I assume win7/win10 opt is also pgo as well?  If
> this is the case, then I think our work is done

{win7,win10}-opt on beta are nightly PGO's, just like Linux. So we're good here! 

Patch was landed on beta at https://hg.mozilla.org/releases/mozilla-beta/rev/2b7b0fd96fce