1382240 - release promotion changes for TC mac and win builds required for 56.0b1

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, enhancement)

Description

[Rail Aliiev [:rail]]

Hopefully just one patch

Comment 1

[Rail Aliiev [:rail]]

Attachment: beta1.diff

Basically this is a copy paste from jamun. To be landed before 560.b1.

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8887961 [details] [diff] [review]
beta1.diff

Review of attachment 8887961 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla/config.py
@@ +2384,4 @@
>              "ci_system": "tc",
>          },
>          "macosx64": {
> +            "unsigned": "gecko.v2.mozilla-beta.nightly.revision.{rev}.firefox.macosx64-opt",

Are you sure:
a) it's not "[...]mozilla-beta.revision.{rev}[...]" instead of "[...]mozilla-beta.nightly.{rev}[...]"? 
b) should we have that "-l10n" there or not?
c) do we have the "en-US" as suffix?

@@ +2385,5 @@
>          },
>          "macosx64": {
> +            "unsigned": "gecko.v2.mozilla-beta.nightly.revision.{rev}.firefox.macosx64-opt",
> +            "signed": "gecko.v2.mozilla-beta.signed-nightly.revision.{rev}.firefox-l10n.macosx64-opt.en-US",
> +            "repackage": "gecko.v2.mozilla-beta.nightly.revision.{rev}.firefox.macosx64-nightly-repackage",

en-US suffix?

@@ +2386,5 @@
>          "macosx64": {
> +            "unsigned": "gecko.v2.mozilla-beta.nightly.revision.{rev}.firefox.macosx64-opt",
> +            "signed": "gecko.v2.mozilla-beta.signed-nightly.revision.{rev}.firefox-l10n.macosx64-opt.en-US",
> +            "repackage": "gecko.v2.mozilla-beta.nightly.revision.{rev}.firefox.macosx64-nightly-repackage",
> +            "repackage-signing": "gecko.v2.mozilla-beta.nightly.revision.{rev}.firefox.macosx64-nightly-repackage-signing",

en-US suffix?

@@ +2415,3 @@
>              "ci_system": "tc",
>          },
>          "macosx64": {

The same as above, but for devedition.

Comment 3

[Rail Aliiev [:rail]]

(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #2)
> Are you sure:
> a) it's not "[...]mozilla-beta.revision.{rev}[...]" instead of
> "[...]mozilla-beta.nightly.{rev}[...]"? 
> b) should we have that "-l10n" there or not?
> c) do we have the "en-US" as suffix?

Some routes have en-US (aka l10n) routes, some don't. I prefer to be explicit with the locale when it's possible.
 
> > +            "repackage": "gecko.v2.mozilla-beta.nightly.revision.{rev}.firefox.macosx64-nightly-repackage",
> 
> en-US suffix?

This one doesn't have it. :/
 
It was tested on jamun, so it should just work (TM).

Comment 4

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to Rail Aliiev [:rail] ⌚️ET from comment #3)
> (In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #2)
> > Are you sure:
> > a) it's not "[...]mozilla-beta.revision.{rev}[...]" instead of
> > "[...]mozilla-beta.nightly.{rev}[...]"? 
> > b) should we have that "-l10n" there or not?
> > c) do we have the "en-US" as suffix?
> 
> Some routes have en-US (aka l10n) routes, some don't. I prefer to be
> explicit with the locale when it's possible.
>  
> > > +            "repackage": "gecko.v2.mozilla-beta.nightly.revision.{rev}.firefox.macosx64-nightly-repackage",
> > 
> > en-US suffix?
> 
> This one doesn't have it. :/
>  
> It was tested on jamun, so it should just work (TM).

Sounds good then. Ship-it!

Comment 5

[Mihai Tabara [:mtabara]⌚️GMT]

Note to self for 31 July 2017 merge day. We need to land this after merging is complete, before the RC is submitted.

Comment 6

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #5)
> Note to self for 31 July 2017 merge day. We need to land this after merging
> is complete, before the RC is submitted.

Bah, wrong bug. This comment is for bug 1372491.

Comment 7

[Mihai Tabara [:mtabara]⌚️GMT]

Changes for this bug need to land after merging is complete and we have nightly 57 and beta 56.

Comment 8

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8887961 [details] [diff] [review]
beta1.diff

https://hg.mozilla.org/build/buildbot-configs/rev/3c7a94990487
https://hg.mozilla.org/build/buildbot-configs/rev/74b864589f22

+ reconfig done.

Comment 9

[Mihai Tabara [:mtabara]⌚️GMT]

Closing this. Will reopen if follow-ups are needed.
We don't need to copy-paste to jamun as we got this stuff from there in the first place :)