1381577 - Land date changes to support windows nightlies onto central

Status: RESOLVED FIXED

(Release Engineering :: General, enhancement)

Description

[Justin Wood (:Callek)]

This patch set may not enable tier 1, that could be a seperate bug (depending mostly on how long it takes for review passes and this to land).

Comment 1

[Justin Wood (:Callek)]

Attachment: Bug XXXXXX - DO NOT LAND - changes applied only to date branch

Review commit: https://reviewboard.mozilla.org/r/157938/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157938/

Comment 2

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part A; Support mozharness actions on windows generic worker

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/157940/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157940/

Comment 3

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part B; Rename the nightly win64 hook to just nightly, support win32.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/157942/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157942/

Comment 4

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part C; Add support for not passing MOZ_SIMPLE_PACKAGE_NAME to windows workers.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/157944/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157944/

Comment 5

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part D; Add support for not passing --branch and --skip-buildbot-actions to mozharness tasks on windows workers.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/157946/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157946/

Comment 6

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part E; Add assertion that there is no space in each action or option passed to mozharness tests.

Land date changes to support windows nightlies onto central

This is needed because on Linux these arrays are joined by a space then passed to the shell as 'for foo in $bar' which will treat spaces as valid delimiters, whereas for windows workers the structure is evaluated completely in python, which means a single value with spaces won't generate the correct command output. Enforcing this prevents mistakes with yaml syntax going unnoticed.

Review commit: https://reviewboard.mozilla.org/r/157948/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157948/

Comment 7

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part F; Make artifact path setting more generic for windows worker.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/157950/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157950/

Comment 8

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part G; Add win32 nightlies as well.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/157962/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157962/

Comment 9

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part H; Upload Symbols for win32.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/157964/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157964/

Comment 10

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part I; Win nightlies should generate and upload balrog_props.json.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/157966/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157966/

Comment 11

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8887184 [details]
Bug 1381577 - Part A; Support mozharness actions on windows generic worker

https://reviewboard.mozilla.org/r/157940/#review163116

Comment 12

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8887185 [details]
Bug 1381577 - Part B; Rename the nightly win64 hook to just nightly, support win32.

https://reviewboard.mozilla.org/r/157942/#review163118

Comment 13

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8887186 [details]
Bug 1381577 - Part C; Add support for not passing MOZ_SIMPLE_PACKAGE_NAME to windows workers.

https://reviewboard.mozilla.org/r/157944/#review163120

::: taskcluster/taskgraph/transforms/job/mozharness.py:213
(Diff revision 1)
>          'MOZ_BUILD_DATE': config.params['moz_build_date'],
>          'MOZ_SCM_LEVEL': config.params['level'],
> -        'MOZ_SIMPLE_PACKAGE_NAME': 'target',
>          'MOZ_AUTOMATION': '1',
>      })
> +    if not env.get('DISABLE_SIMPLE_PACKAGE', False):

This feels a little weird to be passing configuration from transform to transform with environment variables.  I don't see where `DISABLE_SIMPLE_PACKAGE` is set, so I assume that's what's happening here..

Comment 14

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8887187 [details]
Bug 1381577 - Part D; Add support for not passing --branch and --skip-buildbot-actions to mozharness tasks on windows workers.

https://reviewboard.mozilla.org/r/157946/#review163122

::: taskcluster/taskgraph/transforms/job/mozharness.py:227
(Diff revision 1)
>      mh_command.append('\\'.join([r'.\build\src\testing', run['script'].replace('/', '\\')]))
>      for cfg in run['config']:
>          mh_command.append('--config ' + cfg.replace('/', '\\'))
> +    if 'NO_MAGIC_MH_BUILD_ARGS' not in env:
> +        # XXXCallek this is a hack to genericize the mozharness run to not
> +        # force the passing of these params

Another one.. these could be job properties, even if they're only temporary..

Comment 15

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8887188 [details]
Bug 1381577 - Part E; Add assertion that there is no space in each action or option passed to mozharness tests.

https://reviewboard.mozilla.org/r/157948/#review163124

Comment 16

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8887189 [details]
Bug 1381577 - Part F; Make artifact path setting more generic for windows worker.

https://reviewboard.mozilla.org/r/157950/#review163128

Comment 17

[Kim Moir [:kmoir] ET]

Comment on attachment 8887198 [details]
Bug 1381577 - Part G; Add win32 nightlies as well.

https://reviewboard.mozilla.org/r/157962/#review163508

Comment 18

[Kim Moir [:kmoir] ET]

Comment on attachment 8887199 [details]
Bug 1381577 - Part H; Upload Symbols for win32.

https://reviewboard.mozilla.org/r/157964/#review163512

Comment 19

[Kim Moir [:kmoir] ET]

Comment on attachment 8887200 [details]
Bug 1381577 - Part I; Win nightlies should generate and upload balrog_props.json.

https://reviewboard.mozilla.org/r/157966/#review163516

Comment 20

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part K; Stop using the property 'use-funsize-routes' since we can determine if we want those routes in better ways.

Land date changes to support windows nightlies onto central

This change has the side affect of removing accidentally present funsize routes on android and on windows-on-change-signing.

Review commit: https://reviewboard.mozilla.org/r/158398/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158398/

Comment 21

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part L; Support signing windows nightlies.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/158400/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158400/

Comment 22

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part M; Refactor repackage taskgraph code to be more readable and make it easier to add windows.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/158402/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158402/

Comment 23

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part N; Make repackage task output its artifact to a locale included subdirectory, rather than rely on worker to publish there.

Land date changes to support windows nightlies onto central

This will be needed for windows, because if the artifact is output to a folder that is, itself, an artifact folder, we'll end up publishing the named artifact twice. Which is unhelpful.

Review commit: https://reviewboard.mozilla.org/r/158404/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158404/

Comment 24

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part O; Run mach repackage for windows nightlies.

Land date changes to support windows nightlies onto central

This patch also allows us to not reconfigure to run repackage on windows, which saves us both in potential pain points and execution time.

Review commit: https://reviewboard.mozilla.org/r/158406/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158406/

Comment 25

[Justin Wood (:Callek)]

Comment on attachment 8887534 [details]
Bug 1381577 - Part L; Support signing windows nightlies.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/158400/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158400/

Comment 26

[Justin Wood (:Callek)]

Comment on attachment 8887535 [details]
Bug 1381577 - Part M; Refactor repackage taskgraph code to be more readable and make it easier to add windows.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/158402/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158402/

Comment 27

[Justin Wood (:Callek)]

Comment on attachment 8887536 [details]
Bug 1381577 - Part N; Make repackage task output its artifact to a locale included subdirectory, rather than rely on worker to publish there.

Land date changes to support windows nightlies onto central

This will be needed for windows, because if the artifact is output to a folder that is, itself, an artifact folder, we'll end up publishing the named artifact twice. Which is unhelpful.

Review commit: https://reviewboard.mozilla.org/r/158404/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158404/

Comment 28

[Justin Wood (:Callek)]

Comment on attachment 8887537 [details]
Bug 1381577 - Part O; Run mach repackage for windows nightlies.

Land date changes to support windows nightlies onto central

This patch also allows us to not reconfigure to run repackage on windows, which saves us both in potential pain points and execution time.

Review commit: https://reviewboard.mozilla.org/r/158406/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158406/

Comment 29

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part P; Sign repackaged win artifacts.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/158462/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158462/

Comment 30

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part Q; Enable funsize routes for windows nightly.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/158464/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158464/

Comment 31

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part R; Build system changes to support taskcluster backed windows l10n repacks.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/158466/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158466/

Comment 32

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part S; Support Taskcluster win l10n repacks in mozharness scripts.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/158468/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158468/

Comment 33

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part T; Add mozharness configs for Taskcluster win l10n repacks.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/158470/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158470/

Comment 34

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part U; Add tc win l10n to the taskgraph, and don't try to sign it yet.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/158472/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158472/

Comment 35

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part V; Remove target.complete.mar from OSX l10n signing (its signed as part of repackage) and error out if an unknown platform attempts to get signed from l10n.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/158474/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158474/

Comment 36

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part W; Sign windows l10n repacks.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/158476/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158476/

Comment 37

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part X; Run mach repackage for windows l10n, and sign results of windows mach repackage.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/158478/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158478/

Comment 38

[Justin Wood (:Callek)]

Comment on attachment 8887537 [details]
Bug 1381577 - Part O; Run mach repackage for windows nightlies.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158406/diff/1-2/

Comment 39

[Aki Sasaki (not active)]

Comment on attachment 8887602 [details]
Bug 1381577 - Part S; Support Taskcluster win l10n repacks in mozharness scripts.

https://reviewboard.mozilla.org/r/158468/#review163726

Comment 40

[Aki Sasaki (not active)]

Comment on attachment 8887603 [details]
Bug 1381577 - Part T; Add mozharness configs for Taskcluster win l10n repacks.

https://reviewboard.mozilla.org/r/158470/#review163732

Comment 41

[Kim Moir [:kmoir] ET]

Comment on attachment 8887537 [details]
Bug 1381577 - Part O; Run mach repackage for windows nightlies.

https://reviewboard.mozilla.org/r/158406/#review163772

Comment 42

[Kim Moir [:kmoir] ET]

Comment on attachment 8887534 [details]
Bug 1381577 - Part L; Support signing windows nightlies.

https://reviewboard.mozilla.org/r/158400/#review163774

Comment 43

[Kim Moir [:kmoir] ET]

Comment on attachment 8887599 [details]
Bug 1381577 - Part P; Sign repackaged win artifacts.

https://reviewboard.mozilla.org/r/158462/#review163778

Comment 44

[Kim Moir [:kmoir] ET]

Comment on attachment 8887604 [details]
Bug 1381577 - Part U; Add tc win l10n to the taskgraph, and don't try to sign it yet.

https://reviewboard.mozilla.org/r/158472/#review163784

nice job! much more readable

Comment 45

[Kim Moir [:kmoir] ET]

Comment on attachment 8887606 [details]
Bug 1381577 - Part W; Sign windows l10n repacks.

https://reviewboard.mozilla.org/r/158476/#review163798

Comment 46

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part Y; Don't list host/bin/{mar,mbsdiff} in global list since windows will need the filenames with .exe appended.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/158522/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158522/

Comment 47

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part Z; Slight refactor to beetmover-repackage to make windows additions clearer.

Land date changes to support windows nightlies onto central

Supports beetmoving from the build-signing task, as well as ignoring dependencies if we have nothing to beetmove in them (e.g. build-signing for OSX)

Review commit: https://reviewboard.mozilla.org/r/158524/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158524/

Comment 48

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part AA; Enable windows beetmover for en-US and l10n, side affect of enabling balrog for windows nightlies.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/158526/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158526/

Comment 49

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Prepare release beetmover stuff (no reviewer pending rail's tests)

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/158528/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158528/

Comment 50

[Kim Moir [:kmoir] ET]

Comment on attachment 8887639 [details]
Bug 1381577 - Part Z; Slight refactor to beetmover-repackage to make windows additions clearer.

https://reviewboard.mozilla.org/r/158524/#review164174

Comment 51

[Kim Moir [:kmoir] ET]

Comment on attachment 8887640 [details]
Bug 1381577 - Part AA; Enable windows beetmover for en-US and l10n, side affect of enabling balrog for windows nightlies.

https://reviewboard.mozilla.org/r/158526/#review164178

Comment 52

[Michael Shal [:mshal]]

Comment on attachment 8887601 [details]
Bug 1381577 - Part R; Build system changes to support taskcluster backed windows l10n repacks.

https://reviewboard.mozilla.org/r/158466/#review164188

LGTM!

::: commit-message-9b8d2:2
(Diff revision 1)
> +Bug 1381577 - Build system changes to support taskcluster backed windows l10n repacks. r=mshal
> +Land date changes to support windows nightlies onto central

I think it would be helpful if the commit message included the rationale for why we need a separate installer URL.

::: toolkit/mozapps/installer/upload-files.mk:415
(Diff revision 1)
>    $(call QUOTED_WILDCARD,$(topobjdir)/browser/installer/windows/instgen/setup-stub.exe) \
>    $(if $(UPLOAD_EXTRA_FILES), $(foreach f, $(UPLOAD_EXTRA_FILES), $(wildcard $(DIST)/$(f))))
>  
> +ifneq ($(AB_CD),x-test)
> +  UPLOAD_FILES += \
> +    $(call QUOTED_WILDCARD,$(topobjdir)/browser/installer/windows/l10ngen/setup.exe) \

Not something to fix for now, but maybe these can be  combined with the instgen/setup.exe & setup-stub.exe lines somehow in the future? I suspect once we have the full installer repackaging toolchain as the only method of generating the installer, we'll want to rewrite how those exes are generated.

Comment 53

[Kim Moir [:kmoir] ET]

Comment on attachment 8887533 [details]
Bug 1381577 - Part K; Stop using the property 'use-funsize-routes' since we can determine if we want those routes in better ways.

https://reviewboard.mozilla.org/r/158398/#review164202

Comment 54

[Kim Moir [:kmoir] ET]

Comment on attachment 8887535 [details]
Bug 1381577 - Part M; Refactor repackage taskgraph code to be more readable and make it easier to add windows.

https://reviewboard.mozilla.org/r/158402/#review164206

Comment 55

[Kim Moir [:kmoir] ET]

Comment on attachment 8887536 [details]
Bug 1381577 - Part N; Make repackage task output its artifact to a locale included subdirectory, rather than rely on worker to publish there.

https://reviewboard.mozilla.org/r/158404/#review164212

Comment 56

[Kim Moir [:kmoir] ET]

Comment on attachment 8887600 [details]
Bug 1381577 - Part Q; Enable funsize routes for windows nightly.

https://reviewboard.mozilla.org/r/158464/#review164216

Comment 57

[Kim Moir [:kmoir] ET]

Comment on attachment 8887638 [details]
Bug 1381577 - Part Y; Don't list host/bin/{mar,mbsdiff} in global list since windows will need the filenames with .exe appended.

https://reviewboard.mozilla.org/r/158522/#review164220

Comment 58

[Kim Moir [:kmoir] ET]

Comment on attachment 8887607 [details]
Bug 1381577 - Part X; Run mach repackage for windows l10n, and sign results of windows mach repackage.

https://reviewboard.mozilla.org/r/158478/#review164222

Comment 59

[Kim Moir [:kmoir] ET]

Comment on attachment 8887605 [details]
Bug 1381577 - Part V; Remove target.complete.mar from OSX l10n signing (its signed as part of repackage) and error out if an unknown platform attempts to get signed from l10n.

https://reviewboard.mozilla.org/r/158474/#review164226

Comment 60

[Justin Wood (:Callek)]

Comment on attachment 8887183 [details]
Bug XXXXXX - DO NOT LAND - changes applied only to date branch

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157938/diff/1-2/

Comment 61

[Justin Wood (:Callek)]

Comment on attachment 8887184 [details]
Bug 1381577 - Part A; Support mozharness actions on windows generic worker

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157940/diff/1-2/

Comment 62

[Justin Wood (:Callek)]

Comment on attachment 8887185 [details]
Bug 1381577 - Part B; Rename the nightly win64 hook to just nightly, support win32.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157942/diff/1-2/

Comment 63

[Justin Wood (:Callek)]

Comment on attachment 8887186 [details]
Bug 1381577 - Part C; Add support for not passing MOZ_SIMPLE_PACKAGE_NAME to windows workers.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157944/diff/1-2/

Comment 64

[Justin Wood (:Callek)]

Comment on attachment 8887187 [details]
Bug 1381577 - Part D; Add support for not passing --branch and --skip-buildbot-actions to mozharness tasks on windows workers.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157946/diff/1-2/

Comment 65

[Justin Wood (:Callek)]

Comment on attachment 8887188 [details]
Bug 1381577 - Part E; Add assertion that there is no space in each action or option passed to mozharness tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157948/diff/1-2/

Comment 66

[Justin Wood (:Callek)]

Comment on attachment 8887189 [details]
Bug 1381577 - Part F; Make artifact path setting more generic for windows worker.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157950/diff/1-2/

Comment 67

[Justin Wood (:Callek)]

Comment on attachment 8887198 [details]
Bug 1381577 - Part G; Add win32 nightlies as well.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157962/diff/1-2/

Comment 68

[Justin Wood (:Callek)]

Comment on attachment 8887199 [details]
Bug 1381577 - Part H; Upload Symbols for win32.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157964/diff/1-2/

Comment 69

[Justin Wood (:Callek)]

Comment on attachment 8887200 [details]
Bug 1381577 - Part I; Win nightlies should generate and upload balrog_props.json.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157966/diff/1-2/

Comment 70

[Justin Wood (:Callek)]

Comment on attachment 8887533 [details]
Bug 1381577 - Part K; Stop using the property 'use-funsize-routes' since we can determine if we want those routes in better ways.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158398/diff/1-2/

Comment 71

[Justin Wood (:Callek)]

Comment on attachment 8887534 [details]
Bug 1381577 - Part L; Support signing windows nightlies.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158400/diff/1-2/

Comment 72

[Justin Wood (:Callek)]

Comment on attachment 8887535 [details]
Bug 1381577 - Part M; Refactor repackage taskgraph code to be more readable and make it easier to add windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158402/diff/1-2/

Comment 73

[Justin Wood (:Callek)]

Comment on attachment 8887536 [details]
Bug 1381577 - Part N; Make repackage task output its artifact to a locale included subdirectory, rather than rely on worker to publish there.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158404/diff/1-2/

Comment 74

[Justin Wood (:Callek)]

Comment on attachment 8887537 [details]
Bug 1381577 - Part O; Run mach repackage for windows nightlies.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158406/diff/2-3/

Comment 75

[Justin Wood (:Callek)]

Comment on attachment 8887599 [details]
Bug 1381577 - Part P; Sign repackaged win artifacts.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158462/diff/1-2/

Comment 76

[Justin Wood (:Callek)]

Comment on attachment 8887600 [details]
Bug 1381577 - Part Q; Enable funsize routes for windows nightly.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158464/diff/1-2/

Comment 77

[Justin Wood (:Callek)]

Comment on attachment 8887601 [details]
Bug 1381577 - Part R; Build system changes to support taskcluster backed windows l10n repacks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158466/diff/1-2/

Comment 78

[Justin Wood (:Callek)]

Comment on attachment 8887602 [details]
Bug 1381577 - Part S; Support Taskcluster win l10n repacks in mozharness scripts.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158468/diff/1-2/

Comment 79

[Justin Wood (:Callek)]

Comment on attachment 8887603 [details]
Bug 1381577 - Part T; Add mozharness configs for Taskcluster win l10n repacks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158470/diff/1-2/

Comment 80

[Justin Wood (:Callek)]

Comment on attachment 8887604 [details]
Bug 1381577 - Part U; Add tc win l10n to the taskgraph, and don't try to sign it yet.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158472/diff/1-2/

Comment 81

[Justin Wood (:Callek)]

Comment on attachment 8887605 [details]
Bug 1381577 - Part V; Remove target.complete.mar from OSX l10n signing (its signed as part of repackage) and error out if an unknown platform attempts to get signed from l10n.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158474/diff/1-2/

Comment 82

[Justin Wood (:Callek)]

Comment on attachment 8887606 [details]
Bug 1381577 - Part W; Sign windows l10n repacks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158476/diff/1-2/

Comment 83

[Justin Wood (:Callek)]

Comment on attachment 8887607 [details]
Bug 1381577 - Part X; Run mach repackage for windows l10n, and sign results of windows mach repackage.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158478/diff/1-2/

Comment 84

[Justin Wood (:Callek)]

Comment on attachment 8887638 [details]
Bug 1381577 - Part Y; Don't list host/bin/{mar,mbsdiff} in global list since windows will need the filenames with .exe appended.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158522/diff/1-2/

Comment 85

[Justin Wood (:Callek)]

Comment on attachment 8887639 [details]
Bug 1381577 - Part Z; Slight refactor to beetmover-repackage to make windows additions clearer.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158524/diff/1-2/

Comment 86

[Justin Wood (:Callek)]

Comment on attachment 8887640 [details]
Bug 1381577 - Part AA; Enable windows beetmover for en-US and l10n, side affect of enabling balrog for windows nightlies.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158526/diff/1-2/

Comment 87

[Justin Wood (:Callek)]

Comment on attachment 8887641 [details]
Bug 1381577 - Prepare release beetmover stuff (no reviewer pending rail's tests)

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158528/diff/1-2/

Comment 88

[Justin Wood (:Callek)]

c#60 to c#87 requests are simply from me rebasing the patchset onto latest m-c. And can be ignored (I'm going in to clear the re-added review to dustin, now)

Comment 89

[Justin Wood (:Callek)]

Comment on attachment 8887601 [details]
Bug 1381577 - Part R; Build system changes to support taskcluster backed windows l10n repacks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158466/diff/2-3/

Comment 90

[Justin Wood (:Callek)]

Comment on attachment 8887602 [details]
Bug 1381577 - Part S; Support Taskcluster win l10n repacks in mozharness scripts.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158468/diff/2-3/

Comment 91

[Justin Wood (:Callek)]

Comment on attachment 8887603 [details]
Bug 1381577 - Part T; Add mozharness configs for Taskcluster win l10n repacks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158470/diff/2-3/

Comment 92

[Justin Wood (:Callek)]

Comment on attachment 8887604 [details]
Bug 1381577 - Part U; Add tc win l10n to the taskgraph, and don't try to sign it yet.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158472/diff/2-3/

Comment 93

[Justin Wood (:Callek)]

Comment on attachment 8887605 [details]
Bug 1381577 - Part V; Remove target.complete.mar from OSX l10n signing (its signed as part of repackage) and error out if an unknown platform attempts to get signed from l10n.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158474/diff/2-3/

Comment 94

[Justin Wood (:Callek)]

Comment on attachment 8887606 [details]
Bug 1381577 - Part W; Sign windows l10n repacks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158476/diff/2-3/

Comment 95

[Justin Wood (:Callek)]

Comment on attachment 8887607 [details]
Bug 1381577 - Part X; Run mach repackage for windows l10n, and sign results of windows mach repackage.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158478/diff/2-3/

Comment 96

[Justin Wood (:Callek)]

Comment on attachment 8887638 [details]
Bug 1381577 - Part Y; Don't list host/bin/{mar,mbsdiff} in global list since windows will need the filenames with .exe appended.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158522/diff/2-3/

Comment 97

[Justin Wood (:Callek)]

Comment on attachment 8887639 [details]
Bug 1381577 - Part Z; Slight refactor to beetmover-repackage to make windows additions clearer.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158524/diff/2-3/

Comment 98

[Justin Wood (:Callek)]

Comment on attachment 8887640 [details]
Bug 1381577 - Part AA; Enable windows beetmover for en-US and l10n, side affect of enabling balrog for windows nightlies.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158526/diff/2-3/

Comment 99

[Justin Wood (:Callek)]

Comment on attachment 8887641 [details]
Bug 1381577 - Prepare release beetmover stuff (no reviewer pending rail's tests)

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158528/diff/2-3/

Comment 100

[Justin Wood (:Callek)]

(In reply to Justin Wood (:Callek) from comment #89)
> Comment on attachment 8887601 [details]
> Bug 1381577 - Build system changes to support taskcluster backed windows
> l10n repacks.
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/158466/diff/2-3/

:mshal can you give this a once over (due to the followup makefile change and the commit message)

Comment 101

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part AB; Fix typo to make windows PGO get signed.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/159014/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159014/

Comment 102

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part AC; firefox-ui-functional-local should use 'default' tier not explicitly 1 (makes it so we can add this test to not-yet-ready platforms, or non-tier-1 platforms).

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/159016/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159016/

Comment 103

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part AF; Add tests for windows PGO and windows nightly.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/159018/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159018/

Comment 104

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part AD; cleanup run on projects, to ensure things are run everywhere they are supposed to.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/159020/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159020/

Comment 105

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part AG; Rework how test platform variants are calculated for BBB buildernames.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/159022/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159022/

Comment 106

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part AH; Revert to BBB for talos, until TC's hardware worker is ready for windows.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/159024/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159024/

Comment 107

[Rob Thijssen [:grenade (EET/UTC+0300)]]

Comment on attachment 8888128 [details]
Bug 1381577 - Part AH; Revert to BBB for talos, until TC's hardware worker is ready for windows.

https://reviewboard.mozilla.org/r/159024/#review164532

Comment 108

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part AE; Don't run windows talos until flag day.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/159260/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159260/

Comment 109

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part AI; Add tests reftest-gpu, talos-quantum-pageload, and talos-xperf.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/159262/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159262/

Comment 110

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part AJ; Allow to override worker type in test definitions, supports explicitly buildbot-bridge tests.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/159264/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159264/

Comment 111

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part AK; Add support for win8 testing, will be via BBB, leave disabled until flag day.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/159266/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159266/

Comment 112

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part AL; Filter tasks based on run-on-projects for windows nightlies too.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/159268/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159268/

Comment 113

[Justin Wood (:Callek)]

Comment on attachment 8888126 [details]
Bug 1381577 - Part AD; cleanup run on projects, to ensure things are run everywhere they are supposed to.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159020/diff/1-2/

Comment 114

[Justin Wood (:Callek)]

Comment on attachment 8888125 [details]
Bug 1381577 - Part AF; Add tests for windows PGO and windows nightly.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159018/diff/1-2/

Comment 115

[Justin Wood (:Callek)]

Comment on attachment 8888127 [details]
Bug 1381577 - Part AG; Rework how test platform variants are calculated for BBB buildernames.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159022/diff/1-2/

Comment 116

[Justin Wood (:Callek)]

Comment on attachment 8888128 [details]
Bug 1381577 - Part AH; Revert to BBB for talos, until TC's hardware worker is ready for windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159024/diff/1-2/

Comment 117

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8888321 [details]
Bug 1381577 - Part AI; Add tests reftest-gpu, talos-quantum-pageload, and talos-xperf.

https://reviewboard.mozilla.org/r/159262/#review164648

we need to add perf-reftest-singletons T(ps) which was turned on last week for win7/10 only.

Comment 118

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8888124 [details]
Bug 1381577 - Part AC; firefox-ui-functional-local should use 'default' tier not explicitly 1 (makes it so we can add this test to not-yet-ready platforms, or non-tier-1 platforms).

https://reviewboard.mozilla.org/r/159016/#review164654

::: taskcluster/ci/test/tests.yml:122
(Diff revision 1)
>  firefox-ui-functional-local:
>      description: "Firefox-ui-tests functional run"
>      suite: "firefox-ui/functional local"
>      treeherder-symbol: tc-Fxfn-l(en-US)
>      max-run-time: 5400
> -    tier: 1
> +    tier: default

why not just remove the line?

Comment 119

[Michael Shal [:mshal]]

(In reply to Justin Wood (:Callek) from comment #100)
> :mshal can you give this a once over (due to the followup makefile change
> and the commit message)

Looks great - thanks for the detailed message!

Comment 120

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8888322 [details]
Bug 1381577 - Part AJ; Allow to override worker type in test definitions, supports explicitly buildbot-bridge tests.

https://reviewboard.mozilla.org/r/159264/#review164658

This looks OK, but I'm confused why the need for all of the
```
    worker-type:
        by-test-platform:
            default: null
```
since that should be the default.  Is that preparation for a later landing?

Comment 121

[Justin Wood (:Callek)]

Comment on attachment 8887184 [details]
Bug 1381577 - Part A; Support mozharness actions on windows generic worker

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157940/diff/2-3/

Comment 122

[Justin Wood (:Callek)]

Comment on attachment 8887185 [details]
Bug 1381577 - Part B; Rename the nightly win64 hook to just nightly, support win32.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157942/diff/2-3/

Comment 123

[Justin Wood (:Callek)]

Comment on attachment 8887186 [details]
Bug 1381577 - Part C; Add support for not passing MOZ_SIMPLE_PACKAGE_NAME to windows workers.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157944/diff/2-3/

Comment 124

[Justin Wood (:Callek)]

Comment on attachment 8887187 [details]
Bug 1381577 - Part D; Add support for not passing --branch and --skip-buildbot-actions to mozharness tasks on windows workers.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157946/diff/2-3/

Comment 125

[Justin Wood (:Callek)]

Comment on attachment 8887188 [details]
Bug 1381577 - Part E; Add assertion that there is no space in each action or option passed to mozharness tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157948/diff/2-3/

Comment 126

[Justin Wood (:Callek)]

Comment on attachment 8887189 [details]
Bug 1381577 - Part F; Make artifact path setting more generic for windows worker.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157950/diff/2-3/

Comment 127

[Justin Wood (:Callek)]

Comment on attachment 8887198 [details]
Bug 1381577 - Part G; Add win32 nightlies as well.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157962/diff/2-3/

Comment 128

[Justin Wood (:Callek)]

Comment on attachment 8887199 [details]
Bug 1381577 - Part H; Upload Symbols for win32.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157964/diff/2-3/

Comment 129

[Justin Wood (:Callek)]

Comment on attachment 8887200 [details]
Bug 1381577 - Part I; Win nightlies should generate and upload balrog_props.json.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157966/diff/2-3/

Comment 130

[Justin Wood (:Callek)]

Comment on attachment 8887533 [details]
Bug 1381577 - Part K; Stop using the property 'use-funsize-routes' since we can determine if we want those routes in better ways.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158398/diff/2-3/

Comment 131

[Justin Wood (:Callek)]

Comment on attachment 8887534 [details]
Bug 1381577 - Part L; Support signing windows nightlies.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158400/diff/2-3/

Comment 132

[Justin Wood (:Callek)]

Comment on attachment 8887535 [details]
Bug 1381577 - Part M; Refactor repackage taskgraph code to be more readable and make it easier to add windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158402/diff/2-3/

Comment 133

[Justin Wood (:Callek)]

Comment on attachment 8887536 [details]
Bug 1381577 - Part N; Make repackage task output its artifact to a locale included subdirectory, rather than rely on worker to publish there.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158404/diff/2-3/

Comment 134

[Justin Wood (:Callek)]

Comment on attachment 8887537 [details]
Bug 1381577 - Part O; Run mach repackage for windows nightlies.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158406/diff/3-4/

Comment 135

[Justin Wood (:Callek)]

Comment on attachment 8887599 [details]
Bug 1381577 - Part P; Sign repackaged win artifacts.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158462/diff/2-3/

Comment 136

[Justin Wood (:Callek)]

Comment on attachment 8887600 [details]
Bug 1381577 - Part Q; Enable funsize routes for windows nightly.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158464/diff/2-3/

Comment 137

[Justin Wood (:Callek)]

Comment on attachment 8887601 [details]
Bug 1381577 - Part R; Build system changes to support taskcluster backed windows l10n repacks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158466/diff/3-4/

Comment 138

[Justin Wood (:Callek)]

Comment on attachment 8887602 [details]
Bug 1381577 - Part S; Support Taskcluster win l10n repacks in mozharness scripts.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158468/diff/3-4/

Comment 139

[Justin Wood (:Callek)]

Comment on attachment 8887603 [details]
Bug 1381577 - Part T; Add mozharness configs for Taskcluster win l10n repacks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158470/diff/3-4/

Comment 140

[Justin Wood (:Callek)]

Comment on attachment 8887604 [details]
Bug 1381577 - Part U; Add tc win l10n to the taskgraph, and don't try to sign it yet.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158472/diff/3-4/

Comment 141

[Justin Wood (:Callek)]

Comment on attachment 8887605 [details]
Bug 1381577 - Part V; Remove target.complete.mar from OSX l10n signing (its signed as part of repackage) and error out if an unknown platform attempts to get signed from l10n.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158474/diff/3-4/

Comment 142

[Justin Wood (:Callek)]

Comment on attachment 8887606 [details]
Bug 1381577 - Part W; Sign windows l10n repacks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158476/diff/3-4/

Comment 143

[Justin Wood (:Callek)]

Comment on attachment 8887607 [details]
Bug 1381577 - Part X; Run mach repackage for windows l10n, and sign results of windows mach repackage.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158478/diff/3-4/

Comment 144

[Justin Wood (:Callek)]

Comment on attachment 8887638 [details]
Bug 1381577 - Part Y; Don't list host/bin/{mar,mbsdiff} in global list since windows will need the filenames with .exe appended.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158522/diff/3-4/

Comment 145

[Justin Wood (:Callek)]

Comment on attachment 8887639 [details]
Bug 1381577 - Part Z; Slight refactor to beetmover-repackage to make windows additions clearer.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158524/diff/3-4/

Comment 146

[Justin Wood (:Callek)]

Comment on attachment 8887640 [details]
Bug 1381577 - Part AA; Enable windows beetmover for en-US and l10n, side affect of enabling balrog for windows nightlies.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158526/diff/3-4/

Comment 147

[Justin Wood (:Callek)]

Comment on attachment 8888123 [details]
Bug 1381577 - Part AB; Fix typo to make windows PGO get signed.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159014/diff/1-2/

Comment 148

[Justin Wood (:Callek)]

Comment on attachment 8888124 [details]
Bug 1381577 - Part AC; firefox-ui-functional-local should use 'default' tier not explicitly 1 (makes it so we can add this test to not-yet-ready platforms, or non-tier-1 platforms).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159016/diff/1-2/

Comment 149

[Justin Wood (:Callek)]

Comment on attachment 8888126 [details]
Bug 1381577 - Part AD; cleanup run on projects, to ensure things are run everywhere they are supposed to.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159020/diff/2-3/

Comment 150

[Justin Wood (:Callek)]

Comment on attachment 8888320 [details]
Bug 1381577 - Part AE; Don't run windows talos until flag day.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159260/diff/1-2/

Comment 151

[Justin Wood (:Callek)]

Comment on attachment 8888125 [details]
Bug 1381577 - Part AF; Add tests for windows PGO and windows nightly.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159018/diff/2-3/

Comment 152

[Justin Wood (:Callek)]

Comment on attachment 8888127 [details]
Bug 1381577 - Part AG; Rework how test platform variants are calculated for BBB buildernames.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159022/diff/2-3/

Comment 153

[Justin Wood (:Callek)]

Comment on attachment 8888128 [details]
Bug 1381577 - Part AH; Revert to BBB for talos, until TC's hardware worker is ready for windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159024/diff/2-3/

Comment 154

[Justin Wood (:Callek)]

Comment on attachment 8888321 [details]
Bug 1381577 - Part AI; Add tests reftest-gpu, talos-quantum-pageload, and talos-xperf.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159262/diff/1-2/

Comment 155

[Justin Wood (:Callek)]

Comment on attachment 8888322 [details]
Bug 1381577 - Part AJ; Allow to override worker type in test definitions, supports explicitly buildbot-bridge tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159264/diff/1-2/

Comment 156

[Justin Wood (:Callek)]

Comment on attachment 8888323 [details]
Bug 1381577 - Part AK; Add support for win8 testing, will be via BBB, leave disabled until flag day.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159266/diff/1-2/

Comment 157

[Justin Wood (:Callek)]

Comment on attachment 8888324 [details]
Bug 1381577 - Part AL; Filter tasks based on run-on-projects for windows nightlies too.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159268/diff/1-2/

Comment 158

[Justin Wood (:Callek)]

Comment on attachment 8887183 [details]
Bug XXXXXX - DO NOT LAND - changes applied only to date branch

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157938/diff/2-3/

Comment 159

[Justin Wood (:Callek)]

Comment on attachment 8887186 [details]
Bug 1381577 - Part C; Add support for not passing MOZ_SIMPLE_PACKAGE_NAME to windows workers.

https://reviewboard.mozilla.org/r/157944/#review163120

> This feels a little weird to be passing configuration from transform to transform with environment variables.  I don't see where `DISABLE_SIMPLE_PACKAGE` is set, so I assume that's what's happening here..

Fixed with a new run feature

Comment 160

[Justin Wood (:Callek)]

Comment on attachment 8887187 [details]
Bug 1381577 - Part D; Add support for not passing --branch and --skip-buildbot-actions to mozharness tasks on windows workers.

https://reviewboard.mozilla.org/r/157946/#review163122

> Another one.. these could be job properties, even if they're only temporary..

Fixed with a new run feature.

Comment 161

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8887186 [details]
Bug 1381577 - Part C; Add support for not passing MOZ_SIMPLE_PACKAGE_NAME to windows workers.

https://reviewboard.mozilla.org/r/157944/#review164706

Comment 162

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8887187 [details]
Bug 1381577 - Part D; Add support for not passing --branch and --skip-buildbot-actions to mozharness tasks on windows workers.

https://reviewboard.mozilla.org/r/157946/#review164708

::: taskcluster/taskgraph/transforms/job/mozharness.py:242
(Diff revision 3)
>      mh_command.append('\\'.join([r'.\build\src\testing', run['script'].replace('/', '\\')]))
>      for cfg in run['config']:
>          mh_command.append('--config ' + cfg.replace('/', '\\'))
> +    if run['use-magic-mh-args']:
> +        # XXXCallek this is a hack to genericize the mozharness run to not
> +        # force the passing of these params

not really a hack anymore..

Comment 163

[Kim Moir [:kmoir] ET]

Comment on attachment 8888125 [details]
Bug 1381577 - Part AF; Add tests for windows PGO and windows nightly.

https://reviewboard.mozilla.org/r/159018/#review164782

Comment 164

[Kim Moir [:kmoir] ET]

Comment on attachment 8888123 [details]
Bug 1381577 - Part AB; Fix typo to make windows PGO get signed.

https://reviewboard.mozilla.org/r/159014/#review164784

Comment 165

[Kim Moir [:kmoir] ET]

Comment on attachment 8888127 [details]
Bug 1381577 - Part AG; Rework how test platform variants are calculated for BBB buildernames.

https://reviewboard.mozilla.org/r/159022/#review164786

Comment 166

[Kim Moir [:kmoir] ET]

Comment on attachment 8888320 [details]
Bug 1381577 - Part AE; Don't run windows talos until flag day.

https://reviewboard.mozilla.org/r/159260/#review164788

I think I remember seeing the extra spacve after "common-tests" are removed in another patch

Comment 167

[Kim Moir [:kmoir] ET]

Comment on attachment 8888323 [details]
Bug 1381577 - Part AK; Add support for win8 testing, will be via BBB, leave disabled until flag day.

https://reviewboard.mozilla.org/r/159266/#review164798

Comment 168

[Kim Moir [:kmoir] ET]

Comment on attachment 8888324 [details]
Bug 1381577 - Part AL; Filter tasks based on run-on-projects for windows nightlies too.

https://reviewboard.mozilla.org/r/159268/#review164806

Comment 169

[Kim Moir [:kmoir] ET]

Comment on attachment 8888126 [details]
Bug 1381577 - Part AD; cleanup run on projects, to ensure things are run everywhere they are supposed to.

https://reviewboard.mozilla.org/r/159020/#review164810

Comment 170

[Justin Wood (:Callek)]

Comment on attachment 8888321 [details]
Bug 1381577 - Part AI; Add tests reftest-gpu, talos-quantum-pageload, and talos-xperf.

https://reviewboard.mozilla.org/r/159262/#review164648

As discussed on IRC this test was backed out of the tree a day or two ago, I'm going to revisit it early next week after this patch set lands.

Comment 171

[Justin Wood (:Callek)]

Comment on attachment 8888322 [details]
Bug 1381577 - Part AJ; Allow to override worker type in test definitions, supports explicitly buildbot-bridge tests.

https://reviewboard.mozilla.org/r/159264/#review164658

Yea, its to make the addition of buildbot-bridge to these entires clearer.

Comment 172

[Justin Wood (:Callek)]

Comment on attachment 8887187 [details]
Bug 1381577 - Part D; Add support for not passing --branch and --skip-buildbot-actions to mozharness tasks on windows workers.

https://reviewboard.mozilla.org/r/157946/#review165242

::: taskcluster/taskgraph/transforms/job/mozharness.py:242
(Diff revision 3)
>      mh_command.append('\\'.join([r'.\build\src\testing', run['script'].replace('/', '\\')]))
>      for cfg in run['config']:
>          mh_command.append('--config ' + cfg.replace('/', '\\'))
> +    if run['use-magic-mh-args']:
> +        # XXXCallek this is a hack to genericize the mozharness run to not
> +        # force the passing of these params

Removed this comment

Comment 173

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part J; Sign setup.exe on windows and error if we try to sign an unknown platform.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/159894/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159894/

Comment 174

[Justin Wood (:Callek)]

Attachment: Bug 1381577 - Part AM; Make sure to properly utilize MOZ_BUILD_DATE in taskcluster windows.

Land date changes to support windows nightlies onto central

Review commit: https://reviewboard.mozilla.org/r/159896/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159896/

Comment 175

[Justin Wood (:Callek)]

Comment on attachment 8887187 [details]
Bug 1381577 - Part D; Add support for not passing --branch and --skip-buildbot-actions to mozharness tasks on windows workers.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157946/diff/3-4/

Comment 176

[Justin Wood (:Callek)]

Comment on attachment 8887188 [details]
Bug 1381577 - Part E; Add assertion that there is no space in each action or option passed to mozharness tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157948/diff/3-4/

Comment 177

[Justin Wood (:Callek)]

Comment on attachment 8887189 [details]
Bug 1381577 - Part F; Make artifact path setting more generic for windows worker.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157950/diff/3-4/

Comment 178

[Justin Wood (:Callek)]

Comment on attachment 8887198 [details]
Bug 1381577 - Part G; Add win32 nightlies as well.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157962/diff/3-4/

Comment 179

[Justin Wood (:Callek)]

Comment on attachment 8887199 [details]
Bug 1381577 - Part H; Upload Symbols for win32.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157964/diff/3-4/

Comment 180

[Justin Wood (:Callek)]

Comment on attachment 8887200 [details]
Bug 1381577 - Part I; Win nightlies should generate and upload balrog_props.json.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157966/diff/3-4/

Comment 181

[Justin Wood (:Callek)]

Comment on attachment 8887533 [details]
Bug 1381577 - Part K; Stop using the property 'use-funsize-routes' since we can determine if we want those routes in better ways.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158398/diff/3-4/

Comment 182

[Justin Wood (:Callek)]

Comment on attachment 8887534 [details]
Bug 1381577 - Part L; Support signing windows nightlies.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158400/diff/3-4/

Comment 183

[Justin Wood (:Callek)]

Comment on attachment 8887535 [details]
Bug 1381577 - Part M; Refactor repackage taskgraph code to be more readable and make it easier to add windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158402/diff/3-4/

Comment 184

[Justin Wood (:Callek)]

Comment on attachment 8887536 [details]
Bug 1381577 - Part N; Make repackage task output its artifact to a locale included subdirectory, rather than rely on worker to publish there.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158404/diff/3-4/

Comment 185

[Justin Wood (:Callek)]

Comment on attachment 8887537 [details]
Bug 1381577 - Part O; Run mach repackage for windows nightlies.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158406/diff/4-5/

Comment 186

[Justin Wood (:Callek)]

Comment on attachment 8887599 [details]
Bug 1381577 - Part P; Sign repackaged win artifacts.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158462/diff/3-4/

Comment 187

[Justin Wood (:Callek)]

Comment on attachment 8887600 [details]
Bug 1381577 - Part Q; Enable funsize routes for windows nightly.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158464/diff/3-4/

Comment 188

[Justin Wood (:Callek)]

Comment on attachment 8887601 [details]
Bug 1381577 - Part R; Build system changes to support taskcluster backed windows l10n repacks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158466/diff/4-5/

Comment 189

[Justin Wood (:Callek)]

Comment on attachment 8887602 [details]
Bug 1381577 - Part S; Support Taskcluster win l10n repacks in mozharness scripts.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158468/diff/4-5/

Comment 190

[Justin Wood (:Callek)]

Comment on attachment 8887603 [details]
Bug 1381577 - Part T; Add mozharness configs for Taskcluster win l10n repacks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158470/diff/4-5/

Comment 191

[Justin Wood (:Callek)]

Comment on attachment 8887604 [details]
Bug 1381577 - Part U; Add tc win l10n to the taskgraph, and don't try to sign it yet.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158472/diff/4-5/

Comment 192

[Justin Wood (:Callek)]

Comment on attachment 8887605 [details]
Bug 1381577 - Part V; Remove target.complete.mar from OSX l10n signing (its signed as part of repackage) and error out if an unknown platform attempts to get signed from l10n.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158474/diff/4-5/

Comment 193

[Justin Wood (:Callek)]

Comment on attachment 8887606 [details]
Bug 1381577 - Part W; Sign windows l10n repacks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158476/diff/4-5/

Comment 194

[Justin Wood (:Callek)]

Comment on attachment 8887607 [details]
Bug 1381577 - Part X; Run mach repackage for windows l10n, and sign results of windows mach repackage.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158478/diff/4-5/

Comment 195

[Justin Wood (:Callek)]

Comment on attachment 8887638 [details]
Bug 1381577 - Part Y; Don't list host/bin/{mar,mbsdiff} in global list since windows will need the filenames with .exe appended.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158522/diff/4-5/

Comment 196

[Justin Wood (:Callek)]

Comment on attachment 8887639 [details]
Bug 1381577 - Part Z; Slight refactor to beetmover-repackage to make windows additions clearer.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158524/diff/4-5/

Comment 197

[Justin Wood (:Callek)]

Comment on attachment 8887640 [details]
Bug 1381577 - Part AA; Enable windows beetmover for en-US and l10n, side affect of enabling balrog for windows nightlies.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158526/diff/4-5/

Comment 198

[Justin Wood (:Callek)]

Comment on attachment 8888123 [details]
Bug 1381577 - Part AB; Fix typo to make windows PGO get signed.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159014/diff/2-3/

Comment 199

[Justin Wood (:Callek)]

Comment on attachment 8888124 [details]
Bug 1381577 - Part AC; firefox-ui-functional-local should use 'default' tier not explicitly 1 (makes it so we can add this test to not-yet-ready platforms, or non-tier-1 platforms).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159016/diff/2-3/

Comment 200

[Justin Wood (:Callek)]

Comment on attachment 8888126 [details]
Bug 1381577 - Part AD; cleanup run on projects, to ensure things are run everywhere they are supposed to.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159020/diff/3-4/

Comment 201

[Justin Wood (:Callek)]

Comment on attachment 8888320 [details]
Bug 1381577 - Part AE; Don't run windows talos until flag day.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159260/diff/2-3/

Comment 202

[Justin Wood (:Callek)]

Comment on attachment 8888125 [details]
Bug 1381577 - Part AF; Add tests for windows PGO and windows nightly.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159018/diff/3-4/

Comment 203

[Justin Wood (:Callek)]

Comment on attachment 8888127 [details]
Bug 1381577 - Part AG; Rework how test platform variants are calculated for BBB buildernames.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159022/diff/3-4/

Comment 204

[Justin Wood (:Callek)]

Comment on attachment 8888128 [details]
Bug 1381577 - Part AH; Revert to BBB for talos, until TC's hardware worker is ready for windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159024/diff/3-4/

Comment 205

[Justin Wood (:Callek)]

Comment on attachment 8888321 [details]
Bug 1381577 - Part AI; Add tests reftest-gpu, talos-quantum-pageload, and talos-xperf.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159262/diff/2-3/

Comment 206

[Justin Wood (:Callek)]

Comment on attachment 8888322 [details]
Bug 1381577 - Part AJ; Allow to override worker type in test definitions, supports explicitly buildbot-bridge tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159264/diff/2-3/

Comment 207

[Justin Wood (:Callek)]

Comment on attachment 8888323 [details]
Bug 1381577 - Part AK; Add support for win8 testing, will be via BBB, leave disabled until flag day.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159266/diff/2-3/

Comment 208

[Justin Wood (:Callek)]

Comment on attachment 8888324 [details]
Bug 1381577 - Part AL; Filter tasks based on run-on-projects for windows nightlies too.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159268/diff/2-3/

Comment 209

[Justin Wood (:Callek)]

Comment on attachment 8887183 [details]
Bug XXXXXX - DO NOT LAND - changes applied only to date branch

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157938/diff/3-4/

Comment 210

[Kim Moir [:kmoir] ET]

Comment on attachment 8888876 [details]
Bug 1381577 - Part J; Sign setup.exe on windows and error if we try to sign an unknown platform.

https://reviewboard.mozilla.org/r/159894/#review165258

Comment 211

[Kim Moir [:kmoir] ET]

Comment on attachment 8888877 [details]
Bug 1381577 - Part AM; Make sure to properly utilize MOZ_BUILD_DATE in taskcluster windows.

https://reviewboard.mozilla.org/r/159896/#review165260

Comment 213

[Justin Wood (:Callek)]

Comment on attachment 8887184 [details]
Bug 1381577 - Part A; Support mozharness actions on windows generic worker

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157940/diff/3-4/

Comment 214

[Justin Wood (:Callek)]

Comment on attachment 8887185 [details]
Bug 1381577 - Part B; Rename the nightly win64 hook to just nightly, support win32.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157942/diff/3-4/

Comment 215

[Justin Wood (:Callek)]

Comment on attachment 8887186 [details]
Bug 1381577 - Part C; Add support for not passing MOZ_SIMPLE_PACKAGE_NAME to windows workers.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157944/diff/3-4/

Comment 216

[Justin Wood (:Callek)]

Comment on attachment 8887187 [details]
Bug 1381577 - Part D; Add support for not passing --branch and --skip-buildbot-actions to mozharness tasks on windows workers.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157946/diff/4-5/

Comment 217

[Justin Wood (:Callek)]

Comment on attachment 8887188 [details]
Bug 1381577 - Part E; Add assertion that there is no space in each action or option passed to mozharness tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157948/diff/4-5/

Comment 218

[Justin Wood (:Callek)]

Comment on attachment 8887189 [details]
Bug 1381577 - Part F; Make artifact path setting more generic for windows worker.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157950/diff/4-5/

Comment 219

[Justin Wood (:Callek)]

Comment on attachment 8887198 [details]
Bug 1381577 - Part G; Add win32 nightlies as well.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157962/diff/4-5/

Comment 220

[Justin Wood (:Callek)]

Comment on attachment 8887199 [details]
Bug 1381577 - Part H; Upload Symbols for win32.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157964/diff/4-5/

Comment 221

[Justin Wood (:Callek)]

Comment on attachment 8887200 [details]
Bug 1381577 - Part I; Win nightlies should generate and upload balrog_props.json.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157966/diff/4-5/

Comment 222

[Justin Wood (:Callek)]

Comment on attachment 8888876 [details]
Bug 1381577 - Part J; Sign setup.exe on windows and error if we try to sign an unknown platform.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159894/diff/1-2/

Comment 223

[Justin Wood (:Callek)]

Comment on attachment 8887533 [details]
Bug 1381577 - Part K; Stop using the property 'use-funsize-routes' since we can determine if we want those routes in better ways.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158398/diff/4-5/

Comment 224

[Justin Wood (:Callek)]

Comment on attachment 8887534 [details]
Bug 1381577 - Part L; Support signing windows nightlies.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158400/diff/4-5/

Comment 225

[Justin Wood (:Callek)]

Comment on attachment 8887535 [details]
Bug 1381577 - Part M; Refactor repackage taskgraph code to be more readable and make it easier to add windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158402/diff/4-5/

Comment 226

[Justin Wood (:Callek)]

Comment on attachment 8887536 [details]
Bug 1381577 - Part N; Make repackage task output its artifact to a locale included subdirectory, rather than rely on worker to publish there.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158404/diff/4-5/

Comment 227

[Justin Wood (:Callek)]

Comment on attachment 8887537 [details]
Bug 1381577 - Part O; Run mach repackage for windows nightlies.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158406/diff/5-6/

Comment 228

[Justin Wood (:Callek)]

Comment on attachment 8887599 [details]
Bug 1381577 - Part P; Sign repackaged win artifacts.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158462/diff/4-5/

Comment 229

[Justin Wood (:Callek)]

Comment on attachment 8887600 [details]
Bug 1381577 - Part Q; Enable funsize routes for windows nightly.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158464/diff/4-5/

Comment 230

[Justin Wood (:Callek)]

Comment on attachment 8887601 [details]
Bug 1381577 - Part R; Build system changes to support taskcluster backed windows l10n repacks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158466/diff/5-6/

Comment 231

[Justin Wood (:Callek)]

Comment on attachment 8887602 [details]
Bug 1381577 - Part S; Support Taskcluster win l10n repacks in mozharness scripts.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158468/diff/5-6/

Comment 232

[Justin Wood (:Callek)]

Comment on attachment 8887603 [details]
Bug 1381577 - Part T; Add mozharness configs for Taskcluster win l10n repacks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158470/diff/5-6/

Comment 233

[Justin Wood (:Callek)]

Comment on attachment 8887604 [details]
Bug 1381577 - Part U; Add tc win l10n to the taskgraph, and don't try to sign it yet.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158472/diff/5-6/

Comment 234

[Justin Wood (:Callek)]

Comment on attachment 8887605 [details]
Bug 1381577 - Part V; Remove target.complete.mar from OSX l10n signing (its signed as part of repackage) and error out if an unknown platform attempts to get signed from l10n.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158474/diff/5-6/

Comment 235

[Justin Wood (:Callek)]

Comment on attachment 8887606 [details]
Bug 1381577 - Part W; Sign windows l10n repacks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158476/diff/5-6/

Comment 236

[Justin Wood (:Callek)]

Comment on attachment 8887607 [details]
Bug 1381577 - Part X; Run mach repackage for windows l10n, and sign results of windows mach repackage.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158478/diff/5-6/

Comment 237

[Justin Wood (:Callek)]

Comment on attachment 8887638 [details]
Bug 1381577 - Part Y; Don't list host/bin/{mar,mbsdiff} in global list since windows will need the filenames with .exe appended.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158522/diff/5-6/

Comment 238

[Justin Wood (:Callek)]

Comment on attachment 8887639 [details]
Bug 1381577 - Part Z; Slight refactor to beetmover-repackage to make windows additions clearer.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158524/diff/5-6/

Comment 239

[Justin Wood (:Callek)]

Comment on attachment 8887640 [details]
Bug 1381577 - Part AA; Enable windows beetmover for en-US and l10n, side affect of enabling balrog for windows nightlies.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158526/diff/5-6/

Comment 240

[Justin Wood (:Callek)]

Comment on attachment 8888123 [details]
Bug 1381577 - Part AB; Fix typo to make windows PGO get signed.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159014/diff/3-4/

Comment 241

[Justin Wood (:Callek)]

Comment on attachment 8888124 [details]
Bug 1381577 - Part AC; firefox-ui-functional-local should use 'default' tier not explicitly 1 (makes it so we can add this test to not-yet-ready platforms, or non-tier-1 platforms).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159016/diff/3-4/

Comment 242

[Justin Wood (:Callek)]

Comment on attachment 8888126 [details]
Bug 1381577 - Part AD; cleanup run on projects, to ensure things are run everywhere they are supposed to.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159020/diff/4-5/

Comment 243

[Justin Wood (:Callek)]

Comment on attachment 8888320 [details]
Bug 1381577 - Part AE; Don't run windows talos until flag day.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159260/diff/3-4/

Comment 244

[Justin Wood (:Callek)]

Comment on attachment 8888125 [details]
Bug 1381577 - Part AF; Add tests for windows PGO and windows nightly.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159018/diff/4-5/

Comment 245

[Justin Wood (:Callek)]

Comment on attachment 8888127 [details]
Bug 1381577 - Part AG; Rework how test platform variants are calculated for BBB buildernames.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159022/diff/4-5/

Comment 246

[Justin Wood (:Callek)]

Comment on attachment 8888128 [details]
Bug 1381577 - Part AH; Revert to BBB for talos, until TC's hardware worker is ready for windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159024/diff/4-5/

Comment 247

[Justin Wood (:Callek)]

Comment on attachment 8888321 [details]
Bug 1381577 - Part AI; Add tests reftest-gpu, talos-quantum-pageload, and talos-xperf.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159262/diff/3-4/

Comment 248

[Justin Wood (:Callek)]

Comment on attachment 8888322 [details]
Bug 1381577 - Part AJ; Allow to override worker type in test definitions, supports explicitly buildbot-bridge tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159264/diff/3-4/

Comment 249

[Justin Wood (:Callek)]

Comment on attachment 8888323 [details]
Bug 1381577 - Part AK; Add support for win8 testing, will be via BBB, leave disabled until flag day.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159266/diff/3-4/

Comment 250

[Justin Wood (:Callek)]

Comment on attachment 8888324 [details]
Bug 1381577 - Part AL; Filter tasks based on run-on-projects for windows nightlies too.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159268/diff/3-4/

Comment 251

[Justin Wood (:Callek)]

Comment on attachment 8887183 [details]
Bug XXXXXX - DO NOT LAND - changes applied only to date branch

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157938/diff/4-5/

Comment 252

[Justin Wood (:Callek)]

Comment on attachment 8888877 [details]
Bug 1381577 - Part AM; Make sure to properly utilize MOZ_BUILD_DATE in taskcluster windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159896/diff/1-2/

Comment 253

[Justin Wood (:Callek)]

Comment on attachment 8887184 [details]
Bug 1381577 - Part A; Support mozharness actions on windows generic worker

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157940/diff/4-5/

Comment 254

[Justin Wood (:Callek)]

Comment on attachment 8887185 [details]
Bug 1381577 - Part B; Rename the nightly win64 hook to just nightly, support win32.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157942/diff/4-5/

Comment 255

[Justin Wood (:Callek)]

Comment on attachment 8887186 [details]
Bug 1381577 - Part C; Add support for not passing MOZ_SIMPLE_PACKAGE_NAME to windows workers.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157944/diff/4-5/

Comment 256

[Justin Wood (:Callek)]

Comment on attachment 8887187 [details]
Bug 1381577 - Part D; Add support for not passing --branch and --skip-buildbot-actions to mozharness tasks on windows workers.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157946/diff/5-6/

Comment 257

[Justin Wood (:Callek)]

Comment on attachment 8887188 [details]
Bug 1381577 - Part E; Add assertion that there is no space in each action or option passed to mozharness tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157948/diff/5-6/

Comment 258

[Justin Wood (:Callek)]

Comment on attachment 8887189 [details]
Bug 1381577 - Part F; Make artifact path setting more generic for windows worker.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157950/diff/5-6/

Comment 259

[Justin Wood (:Callek)]

Comment on attachment 8887198 [details]
Bug 1381577 - Part G; Add win32 nightlies as well.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157962/diff/5-6/

Comment 260

[Justin Wood (:Callek)]

Comment on attachment 8887199 [details]
Bug 1381577 - Part H; Upload Symbols for win32.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157964/diff/5-6/

Comment 261

[Justin Wood (:Callek)]

Comment on attachment 8887200 [details]
Bug 1381577 - Part I; Win nightlies should generate and upload balrog_props.json.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157966/diff/5-6/

Comment 262

[Justin Wood (:Callek)]

Comment on attachment 8888876 [details]
Bug 1381577 - Part J; Sign setup.exe on windows and error if we try to sign an unknown platform.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159894/diff/2-3/

Comment 263

[Justin Wood (:Callek)]

Comment on attachment 8887533 [details]
Bug 1381577 - Part K; Stop using the property 'use-funsize-routes' since we can determine if we want those routes in better ways.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158398/diff/5-6/

Comment 264

[Justin Wood (:Callek)]

Comment on attachment 8887534 [details]
Bug 1381577 - Part L; Support signing windows nightlies.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158400/diff/5-6/

Comment 265

[Justin Wood (:Callek)]

Comment on attachment 8887535 [details]
Bug 1381577 - Part M; Refactor repackage taskgraph code to be more readable and make it easier to add windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158402/diff/5-6/

Comment 266

[Justin Wood (:Callek)]

Comment on attachment 8887536 [details]
Bug 1381577 - Part N; Make repackage task output its artifact to a locale included subdirectory, rather than rely on worker to publish there.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158404/diff/5-6/

Comment 267

[Justin Wood (:Callek)]

Comment on attachment 8887537 [details]
Bug 1381577 - Part O; Run mach repackage for windows nightlies.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158406/diff/6-7/

Comment 268

[Justin Wood (:Callek)]

Comment on attachment 8887599 [details]
Bug 1381577 - Part P; Sign repackaged win artifacts.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158462/diff/5-6/

Comment 269

[Justin Wood (:Callek)]

Comment on attachment 8887600 [details]
Bug 1381577 - Part Q; Enable funsize routes for windows nightly.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158464/diff/5-6/

Comment 270

[Justin Wood (:Callek)]

Comment on attachment 8887601 [details]
Bug 1381577 - Part R; Build system changes to support taskcluster backed windows l10n repacks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158466/diff/6-7/

Comment 271

[Justin Wood (:Callek)]

Comment on attachment 8887602 [details]
Bug 1381577 - Part S; Support Taskcluster win l10n repacks in mozharness scripts.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158468/diff/6-7/

Comment 272

[Justin Wood (:Callek)]

Comment on attachment 8887603 [details]
Bug 1381577 - Part T; Add mozharness configs for Taskcluster win l10n repacks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158470/diff/6-7/

Comment 273

[Justin Wood (:Callek)]

Comment on attachment 8887604 [details]
Bug 1381577 - Part U; Add tc win l10n to the taskgraph, and don't try to sign it yet.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158472/diff/6-7/

Comment 274

[Justin Wood (:Callek)]

Comment on attachment 8887605 [details]
Bug 1381577 - Part V; Remove target.complete.mar from OSX l10n signing (its signed as part of repackage) and error out if an unknown platform attempts to get signed from l10n.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158474/diff/6-7/

Comment 275

[Justin Wood (:Callek)]

Comment on attachment 8887606 [details]
Bug 1381577 - Part W; Sign windows l10n repacks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158476/diff/6-7/

Comment 276

[Justin Wood (:Callek)]

Comment on attachment 8887607 [details]
Bug 1381577 - Part X; Run mach repackage for windows l10n, and sign results of windows mach repackage.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158478/diff/6-7/

Comment 277

[Justin Wood (:Callek)]

Comment on attachment 8887638 [details]
Bug 1381577 - Part Y; Don't list host/bin/{mar,mbsdiff} in global list since windows will need the filenames with .exe appended.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158522/diff/6-7/

Comment 278

[Justin Wood (:Callek)]

Comment on attachment 8887639 [details]
Bug 1381577 - Part Z; Slight refactor to beetmover-repackage to make windows additions clearer.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158524/diff/6-7/

Comment 279

[Justin Wood (:Callek)]

Comment on attachment 8887640 [details]
Bug 1381577 - Part AA; Enable windows beetmover for en-US and l10n, side affect of enabling balrog for windows nightlies.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158526/diff/6-7/

Comment 280

[Justin Wood (:Callek)]

Comment on attachment 8888123 [details]
Bug 1381577 - Part AB; Fix typo to make windows PGO get signed.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159014/diff/4-5/

Comment 281

[Justin Wood (:Callek)]

Comment on attachment 8888124 [details]
Bug 1381577 - Part AC; firefox-ui-functional-local should use 'default' tier not explicitly 1 (makes it so we can add this test to not-yet-ready platforms, or non-tier-1 platforms).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159016/diff/4-5/

Comment 282

[Justin Wood (:Callek)]

Comment on attachment 8888126 [details]
Bug 1381577 - Part AD; cleanup run on projects, to ensure things are run everywhere they are supposed to.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159020/diff/5-6/

Comment 283

[Justin Wood (:Callek)]

Comment on attachment 8888320 [details]
Bug 1381577 - Part AE; Don't run windows talos until flag day.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159260/diff/4-5/

Comment 284

[Justin Wood (:Callek)]

Comment on attachment 8888125 [details]
Bug 1381577 - Part AF; Add tests for windows PGO and windows nightly.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159018/diff/5-6/

Comment 285

[Justin Wood (:Callek)]

Comment on attachment 8888127 [details]
Bug 1381577 - Part AG; Rework how test platform variants are calculated for BBB buildernames.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159022/diff/5-6/

Comment 286

[Justin Wood (:Callek)]

Comment on attachment 8888128 [details]
Bug 1381577 - Part AH; Revert to BBB for talos, until TC's hardware worker is ready for windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159024/diff/5-6/

Comment 287

[Justin Wood (:Callek)]

Comment on attachment 8888321 [details]
Bug 1381577 - Part AI; Add tests reftest-gpu, talos-quantum-pageload, and talos-xperf.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159262/diff/4-5/

Comment 288

[Justin Wood (:Callek)]

Comment on attachment 8888322 [details]
Bug 1381577 - Part AJ; Allow to override worker type in test definitions, supports explicitly buildbot-bridge tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159264/diff/4-5/

Comment 289

[Justin Wood (:Callek)]

Comment on attachment 8888323 [details]
Bug 1381577 - Part AK; Add support for win8 testing, will be via BBB, leave disabled until flag day.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159266/diff/4-5/

Comment 290

[Justin Wood (:Callek)]

Comment on attachment 8888324 [details]
Bug 1381577 - Part AL; Filter tasks based on run-on-projects for windows nightlies too.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159268/diff/4-5/

Comment 291

[Justin Wood (:Callek)]

Comment on attachment 8888877 [details]
Bug 1381577 - Part AM; Make sure to properly utilize MOZ_BUILD_DATE in taskcluster windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159896/diff/2-3/

Comment 292

[Justin Wood (:Callek)]

Comment on attachment 8887183 [details]
Bug XXXXXX - DO NOT LAND - changes applied only to date branch

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157938/diff/5-6/

Comment 293

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 6c20aa72f30c -d cea58fa7bd22: rebasing 408506:6c20aa72f30c "Bug 1381577 - Part A; Support mozharness actions on windows generic worker r=dustin"
rebasing 408507:c9e3c6f3890a "Bug 1381577 - Part B; Rename the nightly win64 hook to just nightly, support win32. r=dustin"
rebasing 408508:b2d8d389b39b "Bug 1381577 - Part C; Add support for not passing MOZ_SIMPLE_PACKAGE_NAME to windows workers. r=dustin"
rebasing 408509:e5edec15decb "Bug 1381577 - Part D; Add support for not passing --branch and --skip-buildbot-actions to mozharness tasks on windows workers. r=dustin"
rebasing 408510:4a033c1f42e7 "Bug 1381577 - Part E; Add assertion that there is no space in each action or option passed to mozharness tests. r=dustin"
rebasing 408511:fb66a5d1452a "Bug 1381577 - Part F; Make artifact path setting more generic for windows worker. r=dustin"
rebasing 408512:045a60aa56d8 "Bug 1381577 - Part G; Add win32 nightlies as well. r=kmoir"
rebasing 408513:13920d4a1e56 "Bug 1381577 - Part H; Upload Symbols for win32. r=kmoir"
rebasing 408514:1a7d02fdb142 "Bug 1381577 - Part I; Win nightlies should generate and upload balrog_props.json. r=kmoir"
rebasing 408515:8ceecd16ae8b "Bug 1381577 - Part J; Sign setup.exe on windows and error if we try to sign an unknown platform. r=kmoir"
rebasing 408516:0a72808530a8 "Bug 1381577 - Part K; Stop using the property 'use-funsize-routes' since we can determine if we want those routes in better ways. r=kmoir"
rebasing 408517:b7c30f380bf4 "Bug 1381577 - Part L; Support signing windows nightlies. r=kmoir"
rebasing 408518:f6f02aafd71a "Bug 1381577 - Part M; Refactor repackage taskgraph code to be more readable and make it easier to add windows. r=kmoir"
rebasing 408519:7a78632396b0 "Bug 1381577 - Part N; Make repackage task output its artifact to a locale included subdirectory, rather than rely on worker to publish there. r=kmoir"
rebasing 408520:b599e8aecd92 "Bug 1381577 - Part O; Run mach repackage for windows nightlies. r=kmoir"
rebasing 408521:08ec062e3480 "Bug 1381577 - Part P; Sign repackaged win artifacts. r=kmoir"
rebasing 408522:c28c52d4329e "Bug 1381577 - Part Q; Enable funsize routes for windows nightly. r=kmoir"
rebasing 408523:dedfd1e7c88c "Bug 1381577 - Part R; Build system changes to support taskcluster backed windows l10n repacks. r=mshal"
rebasing 408524:df225aeed861 "Bug 1381577 - Part S; Support Taskcluster win l10n repacks in mozharness scripts. r=aki"
rebasing 408525:9b7c2d5363de "Bug 1381577 - Part T; Add mozharness configs for Taskcluster win l10n repacks. r=aki"
rebasing 408526:de30e2e35f29 "Bug 1381577 - Part U; Add tc win l10n to the taskgraph, and don't try to sign it yet. r=kmoir"
rebasing 408527:a3808e46f03c "Bug 1381577 - Part V; Remove target.complete.mar from OSX l10n signing (its signed as part of repackage) and error out if an unknown platform attempts to get signed from l10n. r=kmoir"
rebasing 408528:5f32b9e6a098 "Bug 1381577 - Part W; Sign windows l10n repacks. r=kmoir"
rebasing 408529:e3fb1d8cf2f3 "Bug 1381577 - Part X; Run mach repackage for windows l10n, and sign results of windows mach repackage. r=kmoir"
rebasing 408530:232b2815e8ba "Bug 1381577 - Part Y; Don't list host/bin/{mar,mbsdiff} in global list since windows will need the filenames with .exe appended. r=kmoir"
rebasing 408531:45c6ad313102 "Bug 1381577 - Part Z; Slight refactor to beetmover-repackage to make windows additions clearer. r=kmoir"
rebasing 408532:2067fcfbeaeb "Bug 1381577 - Part AA; Enable windows beetmover for en-US and l10n, side affect of enabling balrog for windows nightlies. r=kmoir"
rebasing 408533:31318cab8328 "Bug 1381577 - Part AB; Fix typo to make windows PGO get signed. r=kmoir"
rebasing 408534:27d7fd75d6aa "Bug 1381577 - Part AC; firefox-ui-functional-local should use 'default' tier not explicitly 1 (makes it so we can add this test to not-yet-ready platforms, or non-tier-1 platforms). r=dustin"
merging taskcluster/ci/test/tests.yml
rebasing 408535:3feb4e6f4d16 "Bug 1381577 - Part AD; cleanup run on projects, to ensure things are run everywhere they are supposed to. r=kmoir"
merging taskcluster/ci/test/tests.yml
rebasing 408536:a038315e4212 "Bug 1381577 - Part AE; Don't run windows talos until flag day. r=kmoir"
merging taskcluster/ci/test/test-platforms.yml
rebasing 408537:5ad4365dbfdc "Bug 1381577 - Part AF; Add tests for windows PGO and windows nightly. r=kmoir"
merging taskcluster/ci/test/test-platforms.yml
merging taskcluster/taskgraph/transforms/tests.py
rebasing 408538:2be6b5ca5950 "Bug 1381577 - Part AG; Rework how test platform variants are calculated for BBB buildernames. r=kmoir"
rebasing 408539:cc34dcbb2e35 "Bug 1381577 - Part AH; Revert to BBB for talos, until TC's hardware worker is ready for windows. r=grenade"
merging taskcluster/ci/test/tests.yml
rebasing 408540:e5d3f9b1c11e "Bug 1381577 - Part AI; Add tests reftest-gpu, talos-quantum-pageload, and talos-xperf. r=jmaher"
merging taskcluster/ci/test/test-sets.yml
merging taskcluster/ci/test/tests.yml
warning: conflicts while merging taskcluster/ci/test/tests.yml! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 294

[Justin Wood (:Callek)]

Comment on attachment 8887184 [details]
Bug 1381577 - Part A; Support mozharness actions on windows generic worker

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157940/diff/5-6/

Comment 295

[Justin Wood (:Callek)]

Comment on attachment 8887185 [details]
Bug 1381577 - Part B; Rename the nightly win64 hook to just nightly, support win32.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157942/diff/5-6/

Comment 296

[Justin Wood (:Callek)]

Comment on attachment 8887186 [details]
Bug 1381577 - Part C; Add support for not passing MOZ_SIMPLE_PACKAGE_NAME to windows workers.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157944/diff/5-6/

Comment 297

[Justin Wood (:Callek)]

Comment on attachment 8887187 [details]
Bug 1381577 - Part D; Add support for not passing --branch and --skip-buildbot-actions to mozharness tasks on windows workers.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157946/diff/6-7/

Comment 298

[Justin Wood (:Callek)]

Comment on attachment 8887188 [details]
Bug 1381577 - Part E; Add assertion that there is no space in each action or option passed to mozharness tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157948/diff/6-7/

Comment 299

[Justin Wood (:Callek)]

Comment on attachment 8887189 [details]
Bug 1381577 - Part F; Make artifact path setting more generic for windows worker.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157950/diff/6-7/

Comment 300

[Justin Wood (:Callek)]

Comment on attachment 8887198 [details]
Bug 1381577 - Part G; Add win32 nightlies as well.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157962/diff/6-7/

Comment 301

[Justin Wood (:Callek)]

Comment on attachment 8887199 [details]
Bug 1381577 - Part H; Upload Symbols for win32.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157964/diff/6-7/

Comment 302

[Justin Wood (:Callek)]

Comment on attachment 8887200 [details]
Bug 1381577 - Part I; Win nightlies should generate and upload balrog_props.json.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157966/diff/6-7/

Comment 303

[Justin Wood (:Callek)]

Comment on attachment 8888876 [details]
Bug 1381577 - Part J; Sign setup.exe on windows and error if we try to sign an unknown platform.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159894/diff/3-4/

Comment 304

[Justin Wood (:Callek)]

Comment on attachment 8887533 [details]
Bug 1381577 - Part K; Stop using the property 'use-funsize-routes' since we can determine if we want those routes in better ways.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158398/diff/6-7/

Comment 305

[Justin Wood (:Callek)]

Comment on attachment 8887534 [details]
Bug 1381577 - Part L; Support signing windows nightlies.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158400/diff/6-7/

Comment 306

[Justin Wood (:Callek)]

Comment on attachment 8887535 [details]
Bug 1381577 - Part M; Refactor repackage taskgraph code to be more readable and make it easier to add windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158402/diff/6-7/

Comment 307

[Justin Wood (:Callek)]

Comment on attachment 8887536 [details]
Bug 1381577 - Part N; Make repackage task output its artifact to a locale included subdirectory, rather than rely on worker to publish there.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158404/diff/6-7/

Comment 308

[Justin Wood (:Callek)]

Comment on attachment 8887537 [details]
Bug 1381577 - Part O; Run mach repackage for windows nightlies.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158406/diff/7-8/

Comment 309

[Justin Wood (:Callek)]

Comment on attachment 8887599 [details]
Bug 1381577 - Part P; Sign repackaged win artifacts.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158462/diff/6-7/

Comment 310

[Justin Wood (:Callek)]

Comment on attachment 8887600 [details]
Bug 1381577 - Part Q; Enable funsize routes for windows nightly.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158464/diff/6-7/

Comment 311

[Justin Wood (:Callek)]

Comment on attachment 8887601 [details]
Bug 1381577 - Part R; Build system changes to support taskcluster backed windows l10n repacks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158466/diff/7-8/

Comment 312

[Justin Wood (:Callek)]

Comment on attachment 8887602 [details]
Bug 1381577 - Part S; Support Taskcluster win l10n repacks in mozharness scripts.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158468/diff/7-8/

Comment 313

[Justin Wood (:Callek)]

Comment on attachment 8887603 [details]
Bug 1381577 - Part T; Add mozharness configs for Taskcluster win l10n repacks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158470/diff/7-8/

Comment 314

[Justin Wood (:Callek)]

Comment on attachment 8887604 [details]
Bug 1381577 - Part U; Add tc win l10n to the taskgraph, and don't try to sign it yet.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158472/diff/7-8/

Comment 315

[Justin Wood (:Callek)]

Comment on attachment 8887605 [details]
Bug 1381577 - Part V; Remove target.complete.mar from OSX l10n signing (its signed as part of repackage) and error out if an unknown platform attempts to get signed from l10n.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158474/diff/7-8/

Comment 316

[Justin Wood (:Callek)]

Comment on attachment 8887606 [details]
Bug 1381577 - Part W; Sign windows l10n repacks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158476/diff/7-8/

Comment 317

[Justin Wood (:Callek)]

Comment on attachment 8887607 [details]
Bug 1381577 - Part X; Run mach repackage for windows l10n, and sign results of windows mach repackage.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158478/diff/7-8/

Comment 318

[Justin Wood (:Callek)]

Comment on attachment 8887638 [details]
Bug 1381577 - Part Y; Don't list host/bin/{mar,mbsdiff} in global list since windows will need the filenames with .exe appended.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158522/diff/7-8/

Comment 319

[Justin Wood (:Callek)]

Comment on attachment 8887639 [details]
Bug 1381577 - Part Z; Slight refactor to beetmover-repackage to make windows additions clearer.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158524/diff/7-8/

Comment 320

[Justin Wood (:Callek)]

Comment on attachment 8887640 [details]
Bug 1381577 - Part AA; Enable windows beetmover for en-US and l10n, side affect of enabling balrog for windows nightlies.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158526/diff/7-8/

Comment 321

[Justin Wood (:Callek)]

Comment on attachment 8888123 [details]
Bug 1381577 - Part AB; Fix typo to make windows PGO get signed.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159014/diff/5-6/

Comment 322

[Justin Wood (:Callek)]

Comment on attachment 8888124 [details]
Bug 1381577 - Part AC; firefox-ui-functional-local should use 'default' tier not explicitly 1 (makes it so we can add this test to not-yet-ready platforms, or non-tier-1 platforms).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159016/diff/5-6/

Comment 323

[Justin Wood (:Callek)]

Comment on attachment 8888126 [details]
Bug 1381577 - Part AD; cleanup run on projects, to ensure things are run everywhere they are supposed to.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159020/diff/6-7/

Comment 324

[Justin Wood (:Callek)]

Comment on attachment 8888320 [details]
Bug 1381577 - Part AE; Don't run windows talos until flag day.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159260/diff/5-6/

Comment 325

[Justin Wood (:Callek)]

Comment on attachment 8888125 [details]
Bug 1381577 - Part AF; Add tests for windows PGO and windows nightly.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159018/diff/6-7/

Comment 326

[Justin Wood (:Callek)]

Comment on attachment 8888127 [details]
Bug 1381577 - Part AG; Rework how test platform variants are calculated for BBB buildernames.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159022/diff/6-7/

Comment 327

[Justin Wood (:Callek)]

Comment on attachment 8888128 [details]
Bug 1381577 - Part AH; Revert to BBB for talos, until TC's hardware worker is ready for windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159024/diff/6-7/

Comment 328

[Justin Wood (:Callek)]

Comment on attachment 8888321 [details]
Bug 1381577 - Part AI; Add tests reftest-gpu, talos-quantum-pageload, and talos-xperf.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159262/diff/5-6/

Comment 329

[Justin Wood (:Callek)]

Comment on attachment 8888322 [details]
Bug 1381577 - Part AJ; Allow to override worker type in test definitions, supports explicitly buildbot-bridge tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159264/diff/5-6/

Comment 330

[Justin Wood (:Callek)]

Comment on attachment 8888323 [details]
Bug 1381577 - Part AK; Add support for win8 testing, will be via BBB, leave disabled until flag day.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159266/diff/5-6/

Comment 331

[Justin Wood (:Callek)]

Comment on attachment 8888324 [details]
Bug 1381577 - Part AL; Filter tasks based on run-on-projects for windows nightlies too.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159268/diff/5-6/

Comment 332

[Justin Wood (:Callek)]

Comment on attachment 8888877 [details]
Bug 1381577 - Part AM; Make sure to properly utilize MOZ_BUILD_DATE in taskcluster windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159896/diff/3-4/

Comment 333

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5070598bdf59
Part A; Support mozharness actions on windows generic worker r=dustin
https://hg.mozilla.org/integration/autoland/rev/4a1819ae5e3c
Part B; Rename the nightly win64 hook to just nightly, support win32. r=dustin
https://hg.mozilla.org/integration/autoland/rev/f38012a5f818
Part C; Add support for not passing MOZ_SIMPLE_PACKAGE_NAME to windows workers. r=dustin
https://hg.mozilla.org/integration/autoland/rev/fdb3b53456b2
Part D; Add support for not passing --branch and --skip-buildbot-actions to mozharness tasks on windows workers. r=dustin
https://hg.mozilla.org/integration/autoland/rev/9fb0158afc85
Part E; Add assertion that there is no space in each action or option passed to mozharness tests. r=dustin
https://hg.mozilla.org/integration/autoland/rev/c0e4c46f2954
Part F; Make artifact path setting more generic for windows worker. r=dustin
https://hg.mozilla.org/integration/autoland/rev/22c130a4b9af
Part G; Add win32 nightlies as well. r=kmoir
https://hg.mozilla.org/integration/autoland/rev/9dc52e08f75f
Part H; Upload Symbols for win32. r=kmoir
https://hg.mozilla.org/integration/autoland/rev/691c30e95347
Part I; Win nightlies should generate and upload balrog_props.json. r=kmoir
https://hg.mozilla.org/integration/autoland/rev/5b547b1dc453
Part J; Sign setup.exe on windows and error if we try to sign an unknown platform. r=kmoir
https://hg.mozilla.org/integration/autoland/rev/4a2469a7216c
Part K; Stop using the property 'use-funsize-routes' since we can determine if we want those routes in better ways. r=kmoir
https://hg.mozilla.org/integration/autoland/rev/0b62fc373083
Part L; Support signing windows nightlies. r=kmoir
https://hg.mozilla.org/integration/autoland/rev/635129751d08
Part M; Refactor repackage taskgraph code to be more readable and make it easier to add windows. r=kmoir
https://hg.mozilla.org/integration/autoland/rev/8fed3841b32a
Part N; Make repackage task output its artifact to a locale included subdirectory, rather than rely on worker to publish there. r=kmoir
https://hg.mozilla.org/integration/autoland/rev/362aeaaac09c
Part O; Run mach repackage for windows nightlies. r=kmoir
https://hg.mozilla.org/integration/autoland/rev/428371d18530
Part P; Sign repackaged win artifacts. r=kmoir
https://hg.mozilla.org/integration/autoland/rev/b8a9d43c6ed1
Part Q; Enable funsize routes for windows nightly. r=kmoir
https://hg.mozilla.org/integration/autoland/rev/df5885fdcfa4
Part R; Build system changes to support taskcluster backed windows l10n repacks. r=mshal
https://hg.mozilla.org/integration/autoland/rev/c6e53b1632ec
Part S; Support Taskcluster win l10n repacks in mozharness scripts. r=aki
https://hg.mozilla.org/integration/autoland/rev/4333c1391702
Part T; Add mozharness configs for Taskcluster win l10n repacks. r=aki
https://hg.mozilla.org/integration/autoland/rev/dbc60400b054
Part U; Add tc win l10n to the taskgraph, and don't try to sign it yet. r=kmoir
https://hg.mozilla.org/integration/autoland/rev/4bbd4f39f28f
Part V; Remove target.complete.mar from OSX l10n signing (its signed as part of repackage) and error out if an unknown platform attempts to get signed from l10n. r=kmoir
https://hg.mozilla.org/integration/autoland/rev/49c740cc0289
Part W; Sign windows l10n repacks. r=kmoir
https://hg.mozilla.org/integration/autoland/rev/522efafe0e14
Part X; Run mach repackage for windows l10n, and sign results of windows mach repackage. r=kmoir
https://hg.mozilla.org/integration/autoland/rev/152bc4406fa9
Part Y; Don't list host/bin/{mar,mbsdiff} in global list since windows will need the filenames with .exe appended. r=kmoir
https://hg.mozilla.org/integration/autoland/rev/d1c0752fff04
Part Z; Slight refactor to beetmover-repackage to make windows additions clearer. r=kmoir
https://hg.mozilla.org/integration/autoland/rev/176d94a4c3d7
Part AA; Enable windows beetmover for en-US and l10n, side affect of enabling balrog for windows nightlies. r=kmoir
https://hg.mozilla.org/integration/autoland/rev/a550ce13b38d
Part AB; Fix typo to make windows PGO get signed. r=kmoir
https://hg.mozilla.org/integration/autoland/rev/c6c1ccfab9e0
Part AC; firefox-ui-functional-local should use 'default' tier not explicitly 1 (makes it so we can add this test to not-yet-ready platforms, or non-tier-1 platforms). r=dustin
https://hg.mozilla.org/integration/autoland/rev/b0e0c40ca806
Part AD; cleanup run on projects, to ensure things are run everywhere they are supposed to. r=kmoir
https://hg.mozilla.org/integration/autoland/rev/856213329beb
Part AE; Don't run windows talos until flag day. r=kmoir
https://hg.mozilla.org/integration/autoland/rev/5ce72f2d5383
Part AF; Add tests for windows PGO and windows nightly. r=kmoir
https://hg.mozilla.org/integration/autoland/rev/ab9f8745b934
Part AG; Rework how test platform variants are calculated for BBB buildernames. r=kmoir
https://hg.mozilla.org/integration/autoland/rev/b880fb43b242
Part AH; Revert to BBB for talos, until TC's hardware worker is ready for windows. r=grenade
https://hg.mozilla.org/integration/autoland/rev/3f7a10cb4224
Part AI; Add tests reftest-gpu, talos-quantum-pageload, and talos-xperf. r=jmaher
https://hg.mozilla.org/integration/autoland/rev/6033c5e29cac
Part AJ; Allow to override worker type in test definitions, supports explicitly buildbot-bridge tests. r=dustin
https://hg.mozilla.org/integration/autoland/rev/3d3bd8c4420b
Part AK; Add support for win8 testing, will be via BBB, leave disabled until flag day. r=kmoir
https://hg.mozilla.org/integration/autoland/rev/707dc7973d5a
Part AL; Filter tasks based on run-on-projects for windows nightlies too. r=kmoir
https://hg.mozilla.org/integration/autoland/rev/f5a5e055be57
Part AM; Make sure to properly utilize MOZ_BUILD_DATE in taskcluster windows. r=kmoir

Comment 334

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb16ffe9f056
Part AN - Change some near-permafailing tests to tier-3 until they can be fixed or turned off r=callek a=me CLOSED TREE

Comment 335

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5070598bdf59
https://hg.mozilla.org/mozilla-central/rev/4a1819ae5e3c
https://hg.mozilla.org/mozilla-central/rev/f38012a5f818
https://hg.mozilla.org/mozilla-central/rev/fdb3b53456b2
https://hg.mozilla.org/mozilla-central/rev/9fb0158afc85
https://hg.mozilla.org/mozilla-central/rev/c0e4c46f2954
https://hg.mozilla.org/mozilla-central/rev/22c130a4b9af
https://hg.mozilla.org/mozilla-central/rev/9dc52e08f75f
https://hg.mozilla.org/mozilla-central/rev/691c30e95347
https://hg.mozilla.org/mozilla-central/rev/5b547b1dc453
https://hg.mozilla.org/mozilla-central/rev/4a2469a7216c
https://hg.mozilla.org/mozilla-central/rev/0b62fc373083
https://hg.mozilla.org/mozilla-central/rev/635129751d08
https://hg.mozilla.org/mozilla-central/rev/8fed3841b32a
https://hg.mozilla.org/mozilla-central/rev/362aeaaac09c
https://hg.mozilla.org/mozilla-central/rev/428371d18530
https://hg.mozilla.org/mozilla-central/rev/b8a9d43c6ed1
https://hg.mozilla.org/mozilla-central/rev/df5885fdcfa4
https://hg.mozilla.org/mozilla-central/rev/c6e53b1632ec
https://hg.mozilla.org/mozilla-central/rev/4333c1391702
https://hg.mozilla.org/mozilla-central/rev/dbc60400b054
https://hg.mozilla.org/mozilla-central/rev/4bbd4f39f28f
https://hg.mozilla.org/mozilla-central/rev/49c740cc0289
https://hg.mozilla.org/mozilla-central/rev/522efafe0e14
https://hg.mozilla.org/mozilla-central/rev/152bc4406fa9
https://hg.mozilla.org/mozilla-central/rev/d1c0752fff04
https://hg.mozilla.org/mozilla-central/rev/176d94a4c3d7
https://hg.mozilla.org/mozilla-central/rev/a550ce13b38d
https://hg.mozilla.org/mozilla-central/rev/c6c1ccfab9e0
https://hg.mozilla.org/mozilla-central/rev/b0e0c40ca806
https://hg.mozilla.org/mozilla-central/rev/856213329beb
https://hg.mozilla.org/mozilla-central/rev/5ce72f2d5383
https://hg.mozilla.org/mozilla-central/rev/ab9f8745b934
https://hg.mozilla.org/mozilla-central/rev/b880fb43b242
https://hg.mozilla.org/mozilla-central/rev/3f7a10cb4224
https://hg.mozilla.org/mozilla-central/rev/6033c5e29cac
https://hg.mozilla.org/mozilla-central/rev/3d3bd8c4420b
https://hg.mozilla.org/mozilla-central/rev/707dc7973d5a
https://hg.mozilla.org/mozilla-central/rev/f5a5e055be57
https://hg.mozilla.org/mozilla-central/rev/cb16ffe9f056