Closed
Bug 1381604
Opened 7 years ago
Closed 7 years ago
soundcloud.com does not show up in Spotlight search on iPhone
Categories
(Firefox for iOS :: General, defect, P2)
Tracking
()
VERIFIED
FIXED
Iteration:
1.26
People
(Reporter: justindarc, Assigned: justindarc)
References
Details
(Whiteboard: [MobileCore][papercut])
Attachments
(1 file)
While investigating Bug 1356217, I found the following: 1. Open new tab on iPhone (not iPad) 2. Go to soundcloud.com 3. Background Fennec and open Spotlight search 4. Type "soundcloud" Expected: - A Fennec search result for soundcloud.com Actual: - No Fennec search results for soundcloud.com Note, this issue does not appear to happen if you follow the same STR on iPad. My initial investigation is leading me to believe that this never gets called in `FaviconManager`: https://github.com/mozilla-mobile/firefox-ios/blob/master/Client/Frontend/Browser/FaviconManager.swift#L132 It seems like something may be failing when trying to get the favicons which is preventing us from setting the current `NSUserActivity`: https://github.com/mozilla-mobile/firefox-ios/blob/master/Client/Helpers/SpotlightHelper.swift#L94
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → jdarcangelo
Status: NEW → ASSIGNED
tracking-fxios:
--- → 8.1+
Priority: -- → P2
See Also: → 1356217
Whiteboard: [MobileCore][papercut]
|
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8887621 -
Flags: review?(fpatel)
|
||
Updated•7 years ago
|
Attachment #8887621 -
Flags: review?(fpatel) → review+
|
|
Assignee | |
Comment 2•7 years ago
|
||
Landed on master: https://github.com/mozilla-mobile/firefox-ios/commit/e14617f7e322e8afc94862bf3d4e84cc5bcc9364
Status: ASSIGNED → RESOLVED
Iteration: --- → 1.25
Closed: 7 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•7 years ago
|
Iteration: 1.25 → 1.26
|
||
Updated•7 years ago
|
Whiteboard: [MobileCore][papercut] → [MobileCore][papercut][needsuplift]
|
|
||
Comment 4•7 years ago
|
||
Uplifted to v8.x
Whiteboard: [MobileCore][papercut][needsuplift] → [MobileCore][papercut]
|
||
Comment 5•7 years ago
|
||
Verifying as fix on 8.1(4811).
Status: RESOLVED → VERIFIED
status-fxios-v8.1:
--- → verified
You need to log in
before you can comment on or make changes to this bug.
Description
•