1381604 - soundcloud.com does not show up in Spotlight search on iPhone

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect, P2)

Description

[Justin D'Arcangelo [:justindarc]]

While investigating Bug 1356217, I found the following:

1. Open new tab on iPhone (not iPad)
2. Go to soundcloud.com
3. Background Fennec and open Spotlight search
4. Type "soundcloud"

Expected:

- A Fennec search result for soundcloud.com

Actual:

- No Fennec search results for soundcloud.com

Note, this issue does not appear to happen if you follow the same STR on iPad. My initial investigation is leading me to believe that this never gets called in `FaviconManager`:

https://github.com/mozilla-mobile/firefox-ios/blob/master/Client/Frontend/Browser/FaviconManager.swift#L132

It seems like something may be failing when trying to get the favicons which is preventing us from setting the current `NSUserActivity`:

https://github.com/mozilla-mobile/firefox-ios/blob/master/Client/Helpers/SpotlightHelper.swift#L94

Comment 1

[Justin D'Arcangelo [:justindarc]]

Attachment: GitHub Pull Request

Comment 2

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/e14617f7e322e8afc94862bf3d4e84cc5bcc9364

Comment 3

[Simon Basca [:SimonB]]

Verifying as fix on master 35383ea543.

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Uplifted to v8.x

Comment 5

[Simon Basca [:SimonB]]

Verifying as fix on 8.1(4811).