Closed Bug 1381604 Opened 2 years ago Closed 2 years ago

soundcloud.com does not show up in Spotlight search on iPhone

Categories

(Firefox for iOS :: General, defect, P2)

Other
iOS
defect

Tracking

()

VERIFIED FIXED
Iteration:
1.26
Tracking Status
fxios 8.1+ ---
fxios-v8.1 --- verified
fxios-v9.0 --- verified

People

(Reporter: justindarc, Assigned: justindarc)

References

Details

(Whiteboard: [MobileCore][papercut])

Attachments

(1 file)

While investigating Bug 1356217, I found the following:

1. Open new tab on iPhone (not iPad)
2. Go to soundcloud.com
3. Background Fennec and open Spotlight search
4. Type "soundcloud"

Expected:

- A Fennec search result for soundcloud.com

Actual:

- No Fennec search results for soundcloud.com

Note, this issue does not appear to happen if you follow the same STR on iPad. My initial investigation is leading me to believe that this never gets called in `FaviconManager`:

https://github.com/mozilla-mobile/firefox-ios/blob/master/Client/Frontend/Browser/FaviconManager.swift#L132

It seems like something may be failing when trying to get the favicons which is preventing us from setting the current `NSUserActivity`:

https://github.com/mozilla-mobile/firefox-ios/blob/master/Client/Helpers/SpotlightHelper.swift#L94
Assignee: nobody → jdarcangelo
Status: NEW → ASSIGNED
Priority: -- → P2
See Also: → 1356217
Whiteboard: [MobileCore][papercut]
Attached file GitHub Pull Request
Attachment #8887621 - Flags: review?(fpatel)
Attachment #8887621 - Flags: review?(fpatel) → review+
Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/e14617f7e322e8afc94862bf3d4e84cc5bcc9364
Status: ASSIGNED → RESOLVED
Iteration: --- → 1.25
Closed: 2 years ago
Resolution: --- → FIXED
Iteration: 1.25 → 1.26
Whiteboard: [MobileCore][papercut] → [MobileCore][papercut][needsuplift]
Verifying as fix on master 35383ea543.
Uplifted to v8.x
Whiteboard: [MobileCore][papercut][needsuplift] → [MobileCore][papercut]
Verifying as fix on 8.1(4811).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.