1356217 - [Regression] Spotlight Search still shows the last visited site even after Clear Private Data

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect, P1)

Description

[Simon Basca [:SimonB]]

Build: 58b02370e25
Device: iPad Air 2
iOS: 10.3.1

Steps to reproduce;
1. Go to a website (e.g. soundcloud.com)
2. Close the tab
3. Open Menu -> Settings -> Clear private data
4. Close Firefox
5. Swipe down on iOS screen to open Spotlight Search
6. Type soundcloud

Actual results:
- Soundcloud.com will be displayed in Spotlight Search results

See a video here: https://www.youtube.com/watch?v=12Ng96HWfpU

Note: 
- After step 5) if we repeat the steps to reproduce with a different site (e.g. youtube.com), Soundcloud will no longer be displayed in the Spotlight Search results. The newly visited site (e.g youtube.com) will be displayed instead.

Comment 1

[Aaron Train [:aaronmt]]

If we're still leaking data, we should consider disabling the feature.

Comment 3

[Simon Basca [:SimonB]]

Re-opening as this is not a duplicate of Bug 1346573, it is a case which, I think, was not covered by the patch from Bug 1346573. 

After following the STR, Clearing Private Data deletes the Spotlight search results, except the last visited site.

Comment 4

[Stephan Leroux [:sleroux]]

I think :jhugman you already had a patch for this. Is this a regression of that patch?

Comment 5

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

The Spotlight database is correctly cleared.

This bug is about the NSUserActivity that hangs around, which we should also clear with the NSUserActivity APIs. (Not part of Spotlight AFAIK)

Comment 6

[James Hugman [:jhugman] [@jhugman]]

I think this needs us to close open tabs as part of clear private data.

(once the tab is closed, the NSUserActivity is invalidated).

Comment 7

[Justin D'Arcangelo [:justindarc]]

(In reply to James Hugman [:jhugman] [@jhugman] from comment #6)
> I think this needs us to close open tabs as part of clear private data.
> 
> (once the tab is closed, the NSUserActivity is invalidated).

I think we can invalidate NSUserActivity without closing the tabs. If you Clear Private Data on desktop, it still keeps all your tabs open even though they're no longer in history.

Comment 8

[Justin D'Arcangelo [:justindarc]]

Also, if you watch the video, he closes the tab before clearing history and it still doesn't clear it from Spotlight.

Comment 9

[Justin D'Arcangelo [:justindarc]]

Attachment: GitHub Pull Request

Comment 10

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/e47b13785bd9f04638917fe9a9855722e33986ce

Comment 11

[Simon Basca [:SimonB]]

Verifying as fix on master c85027eaa0.

Comment 12

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Uplifted to v8.x

Comment 13

[Simon Basca [:SimonB]]

Verifying as fix on 8.1(4811).

Comment 14

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I have re-opened this bug and moved it to 8.2 because we are getting Core Spotlight crashes at app startup now as reported in bug 1385217.

Comment 15

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

What I forgot to mention is that I rolled back the patch for this bug in 8.1. We have never seen crashes for CoreSpotlight before, and since this patches changes that behaviour in our app, I think there is a correlation. Will ask QA to verify if their reproducible crash will go away without this patch.

Comment 16

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

See notes in bug 1385217 how this story is developing.

Comment 17

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

https://sentry.prod.mozaws.net/operations/firefox-ios-rk/issues/630648/

Comment 18

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Uplifted back into v8.x

Comment 19

[Simon Basca [:SimonB]]

Verifying as fix on beta 8.2(5120).