1381630 - Enable the new console frontend by default in dev edition

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Brian Grinstead [:bgrins]]

Right now we are guarding on NIGHTLY_BUILD to enable the new console frontend. Filing this bug to track landing the patch that changes this upon completion of the mvp work on [console-html]

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: Bug 1381630 - Enable the new console frontend by default in dev edition;

Review commit: https://reviewboard.mozilla.org/r/158020/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158020/

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8887227 [details]
Bug 1381630 - Enable the new console frontend by default in dev edition;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158020/diff/1-2/

Comment 3

[Bryan Clark (DevTools PM) [:clarkbw]]

Have we considered guarding up to DevEdition at some point before a full rollout?

Comment 4

[Brian Grinstead [:bgrins]]

(In reply to Bryan Clark (DevTools PM) [:clarkbw] from comment #3)
> Have we considered guarding up to DevEdition at some point before a full
> rollout?

We've been targeting 56 to ride along with the debugger (our tracking has projected a 56 finish as of about a month ago). Hadn't considered DevEdition/Beta, happy to discuss it though.

Comment 5

[Brian Grinstead [:bgrins]]

Comment on attachment 8887227 [details]
Bug 1381630 - Enable the new console frontend by default in dev edition;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158020/diff/2-3/

Comment 6

[Brian Grinstead [:bgrins]]

Julian, this changes a preprocessor directive in devtools.js from `#if defined(NIGHTLY_BUILD)` to `#if defined(NIGHTLY_BUILD) || defined(MOZ_DEV_EDITION)`. Will we need to update the system addon pref loader to support this directive?

Comment 7

[Julian Descottes [:jdescottes]]

(In reply to Brian Grinstead [:bgrins] from comment #6)
> Julian, this changes a preprocessor directive in devtools.js from `#if
> defined(NIGHTLY_BUILD)` to `#if defined(NIGHTLY_BUILD) ||
> defined(MOZ_DEV_EDITION)`. Will we need to update the system addon pref
> loader to support this directive?

The preferences file devtools.js is still preprocessed by the build system for now, so that's fine.
This will only work as long as we only ship as a system addon, but that's the current setup anyway.

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8887227 [details]
Bug 1381630 - Enable the new console frontend by default in dev edition;

https://reviewboard.mozilla.org/r/158020/#review166854

This looks good from what I can tell :)
I'm thinking if we should have a similar pref UI than we have in Nightly to switch back to the old console version ? http://searchfox.org/mozilla-central/source/devtools/client/framework/toolbox-options.js#307-320 
Not sure about that though.

Comment 9

[Brian Grinstead [:bgrins]]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #8)
> Comment on attachment 8887227 [details]
> Bug 1381630 - Enable the new console frontend by default in dev edition;
> 
> https://reviewboard.mozilla.org/r/158020/#review166854
> 
> This looks good from what I can tell :)
> I'm thinking if we should have a similar pref UI than we have in Nightly to
> switch back to the old console version ?
> http://searchfox.org/mozilla-central/source/devtools/client/framework/
> toolbox-options.js#307-320 
> Not sure about that though.

Maybe both of those should be expanded to Dev Edition. But let's file a new bug if we decide to do it.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3beca75b8864
Enable the new console frontend by default in dev edition;r=nchevobbe

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3beca75b8864