Closed Bug 1381630 Opened 2 years ago Closed 2 years ago

Enable the new console frontend by default in dev edition

Categories

(DevTools :: Console, enhancement, P1)

enhancement

Tracking

(firefox56 fixed)

RESOLVED FIXED
Firefox 56
Iteration:
56.4 - Aug 1
Tracking Status
firefox56 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

(Whiteboard: [console-html])

Attachments

(1 file)

Right now we are guarding on NIGHTLY_BUILD to enable the new console frontend. Filing this bug to track landing the patch that changes this upon completion of the mvp work on [console-html]
Whiteboard: [console-html] → [console-html] [triage]
Have we considered guarding up to DevEdition at some point before a full rollout?
(In reply to Bryan Clark (DevTools PM) [:clarkbw] from comment #3)
> Have we considered guarding up to DevEdition at some point before a full
> rollout?

We've been targeting 56 to ride along with the debugger (our tracking has projected a 56 finish as of about a month ago). Hadn't considered DevEdition/Beta, happy to discuss it though.
Flags: qe-verify?
Priority: -- → P2
Whiteboard: [console-html] [triage] → [console-html]
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Iteration: --- → 56.3 - Jul 24
Priority: P2 → P1
Summary: Enable the new console frontend by default in all channels → Enable the new console frontend by default in beta / dev edition
Iteration: 56.3 - Jul 24 → 56.4 - Aug 1
Summary: Enable the new console frontend by default in beta / dev edition → Enable the new console frontend by default in dev edition
Julian, this changes a preprocessor directive in devtools.js from `#if defined(NIGHTLY_BUILD)` to `#if defined(NIGHTLY_BUILD) || defined(MOZ_DEV_EDITION)`. Will we need to update the system addon pref loader to support this directive?
Flags: needinfo?(jdescottes)
(In reply to Brian Grinstead [:bgrins] from comment #6)
> Julian, this changes a preprocessor directive in devtools.js from `#if
> defined(NIGHTLY_BUILD)` to `#if defined(NIGHTLY_BUILD) ||
> defined(MOZ_DEV_EDITION)`. Will we need to update the system addon pref
> loader to support this directive?

The preferences file devtools.js is still preprocessed by the build system for now, so that's fine.
This will only work as long as we only ship as a system addon, but that's the current setup anyway.
Flags: needinfo?(jdescottes)
Comment on attachment 8887227 [details]
Bug 1381630 - Enable the new console frontend by default in dev edition;

https://reviewboard.mozilla.org/r/158020/#review166854

This looks good from what I can tell :)
I'm thinking if we should have a similar pref UI than we have in Nightly to switch back to the old console version ? http://searchfox.org/mozilla-central/source/devtools/client/framework/toolbox-options.js#307-320 
Not sure about that though.
Attachment #8887227 - Flags: review?(nchevobbe) → review+
(In reply to Nicolas Chevobbe [:nchevobbe] from comment #8)
> Comment on attachment 8887227 [details]
> Bug 1381630 - Enable the new console frontend by default in dev edition;
> 
> https://reviewboard.mozilla.org/r/158020/#review166854
> 
> This looks good from what I can tell :)
> I'm thinking if we should have a similar pref UI than we have in Nightly to
> switch back to the old console version ?
> http://searchfox.org/mozilla-central/source/devtools/client/framework/
> toolbox-options.js#307-320 
> Not sure about that though.

Maybe both of those should be expanded to Dev Edition. But let's file a new bug if we decide to do it.
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3beca75b8864
Enable the new console frontend by default in dev edition;r=nchevobbe
https://hg.mozilla.org/mozilla-central/rev/3beca75b8864
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Flags: qe-verify? → qe-verify-
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.