1381633 - Crash [@ AsyncShutdownTimeout | AddonManager: Waiting for providers to shut down. | EnvironmentAddonBuilder ]

Status: VERIFIED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Bob Clary [:bc] (inactive)]

The hang occurs after the firefox -P testprofile -silent

$ ./firefox -CreateProfile testprofile
Success: created profile 'testprofile' at '/home/bclary/.mozilla/firefox/ap8nb462.testprofile/prefs.js'

$ ./firefox -P testprofile -silent
Extension error: Data is not ready. resource://gre/modules/JSONFile.jsm:159 :: get data@resource://gre/modules/JSONFile.jsm:159:13
_get@resource://gre/modules/ExtensionPermissions.jsm:65:9
async*_getCached/<@resource://gre/modules/ExtensionPermissions.jsm:76:47
get@resource://gre/modules/ExtensionParent.jsm:1471:22
async*_getCached@resource://gre/modules/ExtensionPermissions.jsm:75:12
async*get@resource://gre/modules/ExtensionPermissions.jsm:80:12
_startup@resource://gre/modules/Extension.jsm:1101:9
async*startup@resource://gre/modules/Extension.jsm:1068:27
startup/this.startupPromise<@resource://gre/modules/LegacyExtensionsUtils.jsm:188:7
startup@resource://gre/modules/LegacyExtensionsUtils.jsm:140:27
start@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/bclary/bin/nightly/firefox/browser/features/[e-mail]!/bootstrap.js:113:3
handleStartup@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/bclary/bin/nightly/firefox/browser/features/[e-mail]!/bootstrap.js:106:5
promise callback*startup@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/bclary/bin/nightly/firefox/browser/features/[e-mail]!/bootstrap.js:75:3
callBootstrapMethod@resource://gre/modules/addons/XPIProvider.jsm:4385:11
startup@resource://gre/modules/addons/XPIProvider.jsm:2223:13
callProvider@resource://gre/modules/AddonManager.jsm:269:12
_startProvider@resource://gre/modules/AddonManager.jsm:739:5
startup@resource://gre/modules/AddonManager.jsm:906:9
startup@resource://gre/modules/AddonManager.jsm:3090:5
observe@jar:file:///home/bclary/bin/nightly/firefox/omni.ja!/components/addonManager.js:65:9

console.error: 
  Message: Error: Data is not ready.
  Stack:
    get data@resource://gre/modules/JSONFile.jsm:159:13
_get@resource://gre/modules/ExtensionPermissions.jsm:65:9
async*_getCached/<@resource://gre/modules/ExtensionPermissions.jsm:76:47
get@resource://gre/modules/ExtensionParent.jsm:1471:22
async*_getCached@resource://gre/modules/ExtensionPermissions.jsm:75:12
async*get@resource://gre/modules/ExtensionPermissions.jsm:80:12
_startup@resource://gre/modules/Extension.jsm:1101:9
async*startup@resource://gre/modules/Extension.jsm:1068:27
startup/this.startupPromise<@resource://gre/modules/LegacyExtensionsUtils.jsm:188:7
startup@resource://gre/modules/LegacyExtensionsUtils.jsm:140:27
start@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/bclary/bin/nightly/firefox/browser/features/[e-mail]!/bootstrap.js:113:3
handleStartup@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/bclary/bin/nightly/firefox/browser/features/[e-mail]!/bootstrap.js:106:5
promise callback*startup@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/bclary/bin/nightly/firefox/browser/features/[e-mail]!/bootstrap.js:75:3
callBootstrapMethod@resource://gre/modules/addons/XPIProvider.jsm:4385:11
startup@resource://gre/modules/addons/XPIProvider.jsm:2223:13
callProvider@resource://gre/modules/AddonManager.jsm:269:12
_startProvider@resource://gre/modules/AddonManager.jsm:739:5
startup@resource://gre/modules/AddonManager.jsm:906:9
startup@resource://gre/modules/AddonManager.jsm:3090:5
observe@jar:file:///home/bclary/bin/nightly/firefox/omni.ja!/components/addonManager.js:65:9

WARNING: At least one completion condition is taking too long to complete. Conditions: [{"name":"EnvironmentAddonBuilder","state":"(none)","filename":"resource://gre/modules/TelemetryEnvironment.jsm","lineNumber":479,"stack":["resource://gre/modules/TelemetryEnvironment.jsm:init:479","resource://gre/modules/TelemetryEnvironment.jsm:EnvironmentCache:841","resource://gre/modules/TelemetryEnvironment.jsm:getGlobal:59","resource://gre/modules/TelemetryEnvironment.jsm:get currentEnvironment:66","jar:file:///home/bclary/bin/nightly/firefox/omni.ja!/components/TelemetryStartup.js:annotateEnvironment:42","jar:file:///home/bclary/bin/nightly/firefox/omni.ja!/components/TelemetryStartup.js:TelemetryStartup.prototype.observe:32"]}] Barrier: AddonManager: Waiting for providers to shut down.
WARNING: At least one completion condition is taking too long to complete. Conditions: [{"name":"AddonManager: shutting down.","state":[{"name":"AddonManager: Waiting for providers to shut down.","state":[{"name":"EnvironmentAddonBuilder","state":"(none)","filename":"resource://gre/modules/TelemetryEnvironment.jsm","lineNumber":479,"stack":["resource://gre/modules/TelemetryEnvironment.jsm:init:479","resource://gre/modules/TelemetryEnvironment.jsm:EnvironmentCache:841","resource://gre/modules/TelemetryEnvironment.jsm:getGlobal:59","resource://gre/modules/TelemetryEnvironment.jsm:get currentEnvironment:66","jar:file:///home/bclary/bin/nightly/firefox/omni.ja!/components/TelemetryStartup.js:annotateEnvironment:42","jar:file:///home/bclary/bin/nightly/firefox/omni.ja!/components/TelemetryStartup.js:TelemetryStartup.prototype.observe:32"]}]},{"name":"AddonRepository: async shutdown","state":"pending"}],"filename":"resource://gre/modules/AddonManager.jsm","lineNumber":898,"stack":["resource://gre/modules/AddonManager.jsm:startup:898","resource://gre/modules/AddonManager.jsm:startup:3090","jar:file:///home/bclary/bin/nightly/firefox/omni.ja!/components/addonManager.js:observe:65"]}] Barrier: profile-before-change
*** UTM:SVC TimerManager:registerTimer called after profile-before-change notification. Ignoring timer registration for id: telemetry_modules_ping
FATAL ERROR: AsyncShutdown timeout in AddonManager: Waiting for providers to shut down. Conditions: [{"name":"EnvironmentAddonBuilder","state":"(none)","filename":"resource://gre/modules/TelemetryEnvironment.jsm","lineNumber":479,"stack":["resource://gre/modules/TelemetryEnvironment.jsm:init:479","resource://gre/modules/TelemetryEnvironment.jsm:EnvironmentCache:841","resource://gre/modules/TelemetryEnvironment.jsm:getGlobal:59","resource://gre/modules/TelemetryEnvironment.jsm:get currentEnvironment:66","jar:file:///home/bclary/bin/nightly/firefox/omni.ja!/components/TelemetryStartup.js:annotateEnvironment:42","jar:file:///home/bclary/bin/nightly/firefox/omni.ja!/components/TelemetryStartup.js:TelemetryStartup.prototype.observe:32"]}] At least one completion condition failed to complete within a reasonable amount of time. Causing a crash to ensure that we do not leave the user with an unresponsive process draining resources.
[10413] ###!!! ABORT: file resource://gre/modules/TelemetryEnvironment.jsm, line 479
[10413] ###!!! ABORT: file resource://gre/modules/TelemetryEnvironment.jsm, line 479
ExceptionHandler::GenerateDump cloned child 10562
ExceptionHandler::SendContinueSignalToChild sent continue signal to child
ExceptionHandler::WaitForContinueSignal waiting for continue signal...

Crash Report [@ AsyncShutdownTimeout | AddonManager: Waiting for providers to shut down. | EnvironmentAddonBuilder ]

bp-d10f770f-bc8c-45ac-b09f-2881e0170717
bp-c664fbc3-f11a-45aa-941e-7d68c0170717

Application Basics
------------------

Name: Firefox
Version: 56.0a1
Build ID: 20170717100212
Update Channel: nightly
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0
OS: Linux 4.11.9-300.fc26.x86_64
Multiprocess Windows: 1/1 (Enabled by default)
Stylo: false (disabled by default)
Google Key: Found
Mozilla Location Service Key: Found
Safe Mode: false

Crash Reports for the Last 3 Days
---------------------------------

Report ID: bp-c664fbc3-f11a-45aa-941e-7d68c0170717
Submitted: 2 minutes ago

Report ID: bp-d10f770f-bc8c-45ac-b09f-2881e0170717
Submitted: 3 minutes ago

All Crash Reports

Nightly Features
----------------

Name: Activity Stream
Version: 0.0.0
ID: [e-mail]

Name: Application Update Service Helper
Version: 2.0
ID: [e-mail]

Name: Click-to-Play staged rollout
Version: 1.2
ID: [e-mail]

Name: Firefox Screenshots
Version: 10.5.0
ID: [e-mail]

Name: FlyWeb
Version: 1.0.0
ID: [e-mail]

Name: Follow-on Search Telemetry
Version: 0.9.1
ID: [e-mail]

Name: Form Autofill
Version: 1.0
ID: [e-mail]

Name: Multi-process staged rollout
Version: 1.80
ID: [e-mail]

Name: Photon onboarding
Version: 0.1
ID: [e-mail]

Name: Pocket
Version: 1.0.5
ID: [e-mail]

Name: Presentation
Version: 1.0.0
ID: [e-mail]

Name: Shield Recipe Client
Version: 55
ID: [e-mail]

Name: Web Compat
Version: 1.1
ID: [e-mail]

Name: WebCompat Reporter
Version: 1.0.0
ID: [e-mail]

Extensions
----------

Graphics
--------

Features
Compositing: Basic
Asynchronous Pan/Zoom: wheel input enabled; scrollbar drag enabled
WebGL 1 Driver WSI Info: GLX 1.4 GLX_VENDOR(client): Mesa Project and SGI GLX_VENDOR(server): SGI Extensions: GLX_ARB_create_context GLX_ARB_create_context_profile GLX_ARB_fbconfig_float GLX_ARB_framebuffer_sRGB GLX_ARB_get_proc_address GLX_ARB_multisample GLX_EXT_import_context GLX_EXT_visual_info GLX_EXT_visual_rating GLX_EXT_fbconfig_packed_float GLX_EXT_framebuffer_sRGB GLX_EXT_create_context_es2_profile GLX_EXT_create_context_es_profile GLX_MESA_copy_sub_buffer GLX_MESA_multithread_makecurrent GLX_MESA_query_renderer GLX_MESA_swap_control GLX_OML_swap_method GLX_OML_sync_control GLX_SGI_make_current_read GLX_SGI_swap_control GLX_SGI_video_sync GLX_SGIS_multisample GLX_SGIX_fbconfig GLX_SGIX_pbuffer GLX_SGIX_visual_select_group GLX_EXT_texture_from_pixmap GLX_INTEL_swap_event GLX_EXT_buffer_age
WebGL 1 Driver Renderer: nouveau -- Gallium 0.4 on NVC1
WebGL 1 Driver Version: 3.0 Mesa 17.1.4
WebGL 1 Driver Extensions: GL_ARB_multisample GL_EXT_abgr GL_EXT_bgra GL_EXT_blend_color GL_EXT_blend_minmax GL_EXT_blend_subtract GL_EXT_copy_texture GL_EXT_polygon_offset GL_EXT_subtexture GL_EXT_texture_object GL_EXT_vertex_array GL_EXT_compiled_vertex_array GL_EXT_texture GL_EXT_texture3D GL_IBM_rasterpos_clip GL_ARB_point_parameters GL_EXT_draw_range_elements GL_EXT_packed_pixels GL_EXT_point_parameters GL_EXT_rescale_normal GL_EXT_separate_specular_color GL_EXT_texture_edge_clamp GL_SGIS_generate_mipmap GL_SGIS_texture_border_clamp GL_SGIS_texture_edge_clamp GL_SGIS_texture_lod GL_ARB_framebuffer_sRGB GL_ARB_multitexture GL_EXT_framebuffer_sRGB GL_IBM_multimode_draw_arrays GL_IBM_texture_mirrored_repeat GL_ARB_texture_cube_map GL_ARB_texture_env_add GL_ARB_transpose_matrix GL_EXT_blend_func_separate GL_EXT_fog_coord GL_EXT_multi_draw_arrays GL_EXT_secondary_color GL_EXT_texture_env_add GL_EXT_texture_filter_anisotropic GL_EXT_texture_lod_bias GL_INGR_blend_func_separate GL_NV_blend_square GL_NV_light_max_exponent GL_NV_texgen_reflection GL_NV_texture_env_combine4 GL_S3_s3tc GL_SUN_multi_draw_arrays GL_ARB_texture_border_clamp GL_ARB_texture_compression GL_EXT_framebuffer_object GL_EXT_texture_compression_s3tc GL_EXT_texture_env_combine GL_EXT_texture_env_dot3 GL_MESA_window_pos GL_NV_packed_depth_stencil GL_NV_texture_rectangle GL_ARB_depth_texture GL_ARB_occlusion_query GL_ARB_shadow GL_ARB_texture_env_combine GL_ARB_texture_env_crossbar GL_ARB_texture_env_dot3 GL_ARB_texture_mirrored_repeat GL_ARB_window_pos GL_ATI_fragment_shader GL_EXT_stencil_two_side GL_EXT_texture_cube_map GL_NV_depth_clamp GL_NV_fog_distance GL_APPLE_packed_pixels GL_APPLE_vertex_array_object GL_ARB_draw_buffers GL_ARB_fragment_program GL_ARB_fragment_shader GL_ARB_shader_objects GL_ARB_vertex_program GL_ARB_vertex_shader GL_ATI_draw_buffers GL_ATI_texture_env_combine3 GL_ATI_texture_float GL_EXT_depth_bounds_test GL_EXT_shadow_funcs GL_EXT_stencil_wrap GL_MESA_pack_invert GL_NV_primitive_restart GL_ARB_depth_clamp GL_ARB_fragment_program_shadow GL_ARB_half_float_pixel GL_ARB_occlusion_query2 GL_ARB_point_sprite GL_ARB_shading_language_100 GL_ARB_sync GL_ARB_texture_non_power_of_two GL_ARB_vertex_buffer_object GL_ATI_blend_equation_separate GL_EXT_blend_equation_separate GL_OES_read_format GL_ARB_color_buffer_float GL_ARB_pixel_buffer_object GL_ARB_texture_compression_rgtc GL_ARB_texture_float GL_ARB_texture_rectangle GL_ATI_texture_compression_3dc GL_EXT_packed_float GL_EXT_pixel_buffer_object GL_EXT_texture_compression_dxt1 GL_EXT_texture_compression_rgtc GL_EXT_texture_mirror_clamp GL_EXT_texture_rectangle GL_EXT_texture_sRGB GL_EXT_texture_shared_exponent GL_ARB_framebuffer_object GL_EXT_framebuffer_blit GL_EXT_framebuffer_multisample GL_EXT_packed_depth_stencil GL_ARB_vertex_array_object GL_ATI_separate_stencil GL_ATI_texture_mirror_once GL_EXT_draw_buffers2 GL_EXT_draw_instanced GL_EXT_gpu_program_parameters GL_EXT_texture_array GL_EXT_texture_compression_latc GL_EXT_texture_integer GL_EXT_texture_sRGB_decode GL_EXT_timer_query GL_OES_EGL_image GL_AMD_performance_monitor GL_ARB_copy_buffer GL_ARB_depth_buffer_float GL_ARB_draw_instanced GL_ARB_half_float_vertex GL_ARB_instanced_arrays GL_ARB_map_buffer_range GL_ARB_texture_rg GL_ARB_texture_swizzle GL_ARB_vertex_array_bgra GL_EXT_texture_swizzle GL_EXT_vertex_array_bgra GL_NV_conditional_render GL_AMD_conservative_depth GL_AMD_draw_buffers_blend GL_ARB_ES2_compatibility GL_ARB_blend_func_extended GL_ARB_debug_output GL_ARB_draw_buffers_blend GL_ARB_draw_elements_base_vertex GL_ARB_explicit_attrib_location GL_ARB_fragment_coord_conventions GL_ARB_provoking_vertex GL_ARB_sample_shading GL_ARB_sampler_objects GL_ARB_seamless_cube_map GL_ARB_shader_texture_lod GL_ARB_texture_cube_map_array GL_ARB_texture_gather GL_ARB_texture_multisample GL_ARB_texture_query_lod GL_ARB_texture_rgb10_a2ui GL_ARB_uniform_buffer_object GL_ARB_vertex_type_2_10_10_10_rev GL_EXT_provoking_vertex GL_EXT_texture_snorm GL_MESA_texture_signed_rgba GL_NV_texture_barrier GL_ARB_get_program_binary GL_ARB_robustness GL_ARB_separate_shader_objects GL_ARB_shader_bit_encoding GL_ARB_shader_precision GL_ARB_texture_compression_bptc GL_ARB_timer_query GL_ARB_transform_feedback2 GL_ARB_transform_feedback3 GL_NV_vdpau_interop GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ARB_base_instance GL_ARB_compressed_texture_pixel_storage GL_ARB_conservative_depth GL_ARB_internalformat_query GL_ARB_map_buffer_alignment GL_ARB_shader_atomic_counters GL_ARB_shader_image_load_store GL_ARB_shading_language_420pack GL_ARB_shading_language_packing GL_ARB_texture_storage GL_ARB_transform_feedback_instanced GL_EXT_framebuffer_multisample_blit_scaled GL_EXT_transform_feedback GL_AMD_shader_trinary_minmax GL_ARB_ES3_compatibility GL_ARB_arrays_of_arrays GL_ARB_clear_buffer_object GL_ARB_compute_shader GL_ARB_copy_image GL_ARB_explicit_uniform_location GL_ARB_framebuffer_no_attachments GL_ARB_invalidate_subdata GL_ARB_program_interface_query GL_ARB_robust_buffer_access_behavior GL_ARB_shader_image_size GL_ARB_shader_storage_buffer_object GL_ARB_stencil_texturing GL_ARB_texture_query_levels GL_ARB_texture_storage_multisample GL_ARB_texture_view GL_ARB_vertex_attrib_binding GL_KHR_debug GL_KHR_robustness GL_ARB_buffer_storage GL_ARB_clear_texture GL_ARB_compute_variable_group_size GL_ARB_internalformat_query2 GL_ARB_multi_bind GL_ARB_query_buffer_object GL_ARB_shader_draw_parameters GL_ARB_shader_group_vote GL_ARB_texture_mirror_clamp_to_edge GL_ARB_texture_stencil8 GL_ARB_vertex_type_10f_11f_11f_rev GL_EXT_shader_integer_mix GL_ARB_clip_control GL_ARB_conditional_render_inverted GL_ARB_cull_distance GL_ARB_derivative_control GL_ARB_get_texture_sub_image GL_ARB_pipeline_statistics_query GL_ARB_shader_texture_image_samples GL_ARB_texture_barrier GL_EXT_polygon_offset_clamp GL_KHR_context_flush_control GL_KHR_robust_buffer_access_behavior GL_ARB_shader_atomic_counter_ops GL_ARB_shader_clock GL_EXT_window_rectangles GL_MESA_shader_integer_functions
WebGL 1 Extensions: ANGLE_instanced_arrays EXT_blend_minmax EXT_color_buffer_half_float EXT_frag_depth EXT_sRGB EXT_shader_texture_lod EXT_texture_filter_anisotropic EXT_disjoint_timer_query MOZ_debug OES_element_index_uint OES_standard_derivatives OES_texture_float OES_texture_float_linear OES_texture_half_float OES_texture_half_float_linear OES_vertex_array_object WEBGL_color_buffer_float WEBGL_compressed_texture_etc WEBGL_compressed_texture_s3tc WEBGL_compressed_texture_s3tc_srgb WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_depth_texture WEBGL_draw_buffers WEBGL_lose_context MOZ_WEBGL_lose_context MOZ_WEBGL_compressed_texture_s3tc MOZ_WEBGL_depth_texture
WebGL 2 Driver WSI Info: GLX 1.4 GLX_VENDOR(client): Mesa Project and SGI GLX_VENDOR(server): SGI Extensions: GLX_ARB_create_context GLX_ARB_create_context_profile GLX_ARB_fbconfig_float GLX_ARB_framebuffer_sRGB GLX_ARB_get_proc_address GLX_ARB_multisample GLX_EXT_import_context GLX_EXT_visual_info GLX_EXT_visual_rating GLX_EXT_fbconfig_packed_float GLX_EXT_framebuffer_sRGB GLX_EXT_create_context_es2_profile GLX_EXT_create_context_es_profile GLX_MESA_copy_sub_buffer GLX_MESA_multithread_makecurrent GLX_MESA_query_renderer GLX_MESA_swap_control GLX_OML_swap_method GLX_OML_sync_control GLX_SGI_make_current_read GLX_SGI_swap_control GLX_SGI_video_sync GLX_SGIS_multisample GLX_SGIX_fbconfig GLX_SGIX_pbuffer GLX_SGIX_visual_select_group GLX_EXT_texture_from_pixmap GLX_INTEL_swap_event GLX_EXT_buffer_age
WebGL 2 Driver Renderer: nouveau -- Gallium 0.4 on NVC1
WebGL 2 Driver Version: 4.3 (Core Profile) Mesa 17.1.4
WebGL 2 Driver Extensions: GL_AMD_conservative_depth GL_AMD_draw_buffers_blend GL_AMD_performance_monitor GL_AMD_shader_trinary_minmax GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ARB_ES2_compatibility GL_ARB_ES3_1_compatibility GL_ARB_ES3_2_compatibility GL_ARB_ES3_compatibility GL_ARB_arrays_of_arrays GL_ARB_base_instance GL_ARB_blend_func_extended GL_ARB_buffer_storage GL_ARB_clear_buffer_object GL_ARB_clear_texture GL_ARB_clip_control GL_ARB_color_buffer_float GL_ARB_compressed_texture_pixel_storage GL_ARB_compute_shader GL_ARB_compute_variable_group_size GL_ARB_conditional_render_inverted GL_ARB_conservative_depth GL_ARB_copy_buffer GL_ARB_copy_image GL_ARB_cull_distance GL_ARB_debug_output GL_ARB_depth_buffer_float GL_ARB_depth_clamp GL_ARB_derivative_control GL_ARB_direct_state_access GL_ARB_draw_buffers GL_ARB_draw_buffers_blend GL_ARB_draw_elements_base_vertex GL_ARB_draw_indirect GL_ARB_draw_instanced GL_ARB_enhanced_layouts GL_ARB_explicit_attrib_location GL_ARB_explicit_uniform_location GL_ARB_fragment_coord_conventions GL_ARB_fragment_layer_viewport GL_ARB_fragment_shader GL_ARB_framebuffer_no_attachments GL_ARB_framebuffer_object GL_ARB_framebuffer_sRGB GL_ARB_get_program_binary GL_ARB_get_texture_sub_image GL_ARB_gpu_shader5 GL_ARB_gpu_shader_fp64 GL_ARB_gpu_shader_int64 GL_ARB_half_float_pixel GL_ARB_half_float_vertex GL_ARB_indirect_parameters GL_ARB_instanced_arrays GL_ARB_internalformat_query GL_ARB_internalformat_query2 GL_ARB_invalidate_subdata GL_ARB_map_buffer_alignment GL_ARB_map_buffer_range GL_ARB_multi_bind GL_ARB_multi_draw_indirect GL_ARB_occlusion_query2 GL_ARB_pipeline_statistics_query GL_ARB_pixel_buffer_object GL_ARB_point_sprite GL_ARB_program_interface_query GL_ARB_provoking_vertex GL_ARB_query_buffer_object GL_ARB_robust_buffer_access_behavior GL_ARB_robustness GL_ARB_sample_shading GL_ARB_sampler_objects GL_ARB_seamless_cube_map GL_ARB_separate_shader_objects GL_ARB_shader_atomic_counter_ops GL_ARB_shader_atomic_counters GL_ARB_shader_bit_encoding GL_ARB_shader_clock GL_ARB_shader_draw_parameters GL_ARB_shader_group_vote GL_ARB_shader_image_load_store GL_ARB_shader_image_size GL_ARB_shader_objects GL_ARB_shader_precision GL_ARB_shader_storage_buffer_object GL_ARB_shader_subroutine GL_ARB_shader_texture_image_samples GL_ARB_shader_texture_lod GL_ARB_shading_language_420pack GL_ARB_shading_language_packing GL_ARB_stencil_texturing GL_ARB_sync GL_ARB_tessellation_shader GL_ARB_texture_barrier GL_ARB_texture_buffer_object GL_ARB_texture_buffer_object_rgb32 GL_ARB_texture_buffer_range GL_ARB_texture_compression_bptc GL_ARB_texture_compression_rgtc GL_ARB_texture_cube_map_array GL_ARB_texture_float GL_ARB_texture_gather GL_ARB_texture_mirror_clamp_to_edge GL_ARB_texture_multisample GL_ARB_texture_non_power_of_two GL_ARB_texture_query_levels GL_ARB_texture_query_lod GL_ARB_texture_rectangle GL_ARB_texture_rg GL_ARB_texture_rgb10_a2ui GL_ARB_texture_stencil8 GL_ARB_texture_storage GL_ARB_texture_storage_multisample GL_ARB_texture_swizzle GL_ARB_texture_view GL_ARB_timer_query GL_ARB_transform_feedback2 GL_ARB_transform_feedback3 GL_ARB_transform_feedback_instanced GL_ARB_uniform_buffer_object GL_ARB_vertex_array_bgra GL_ARB_vertex_array_object GL_ARB_vertex_attrib_64bit GL_ARB_vertex_attrib_binding GL_ARB_vertex_shader GL_ARB_vertex_type_10f_11f_11f_rev GL_ARB_vertex_type_2_10_10_10_rev GL_ARB_viewport_array GL_ATI_blend_equation_separate GL_ATI_texture_float GL_ATI_texture_mirror_once GL_EXT_abgr GL_EXT_blend_equation_separate GL_EXT_depth_bounds_test GL_EXT_draw_buffers2 GL_EXT_draw_instanced GL_EXT_framebuffer_blit GL_EXT_framebuffer_multisample GL_EXT_framebuffer_multisample_blit_scaled GL_EXT_framebuffer_sRGB GL_EXT_packed_depth_stencil GL_EXT_packed_float GL_EXT_pixel_buffer_object GL_EXT_polygon_offset_clamp GL_EXT_provoking_vertex GL_EXT_shader_integer_mix GL_EXT_texture_array GL_EXT_texture_compression_dxt1 GL_EXT_texture_compression_rgtc GL_EXT_texture_compression_s3tc GL_EXT_texture_filter_anisotropic GL_EXT_texture_integer GL_EXT_texture_mirror_clamp GL_EXT_texture_sRGB GL_EXT_texture_sRGB_decode GL_EXT_texture_shared_exponent GL_EXT_texture_snorm GL_EXT_texture_swizzle GL_EXT_timer_query GL_EXT_transform_feedback GL_EXT_vertex_array_bgra GL_EXT_window_rectangles GL_IBM_multimode_draw_arrays GL_KHR_context_flush_control GL_KHR_debug GL_KHR_robust_buffer_access_behavior GL_KHR_robustness GL_MESA_pack_invert GL_MESA_shader_integer_functions GL_MESA_texture_signed_rgba GL_NV_conditional_render GL_NV_depth_clamp GL_NV_packed_depth_stencil GL_NV_texture_barrier GL_NV_vdpau_interop GL_OES_EGL_image GL_S3_s3tc
WebGL 2 Extensions: EXT_color_buffer_float EXT_texture_filter_anisotropic EXT_disjoint_timer_query MOZ_debug OES_texture_float_linear WEBGL_compressed_texture_etc WEBGL_compressed_texture_s3tc WEBGL_compressed_texture_s3tc_srgb WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_lose_context MOZ_WEBGL_lose_context MOZ_WEBGL_compressed_texture_s3tc
Audio Backend: pulse-rust
GPU #1
Active: Yes
Description: nouveau -- Gallium 0.4 on NVC1
Vendor ID: nouveau
Device ID: Gallium 0.4 on NVC1
Driver Version: 3.0 Mesa 17.1.4

Diagnostics
AzureCanvasAccelerated: 0
AzureCanvasBackend: skia
AzureContentBackend: skia
AzureFallbackCanvasBackend: none
CairoUseXRender: 0
Device Reset: Trigger Device Reset
Decision Log
HW_COMPOSITING:
blocked by default: Acceleration blocked by platform
OPENGL_COMPOSITING:
unavailable by default: Hardware compositing is disabled
WEBRENDER:
opt-in by default: WebRender is an opt-in feature




Important Modified Preferences
------------------------------

browser.cache.disk.capacity: 358400
browser.cache.disk.filesystem_reported: 1
browser.cache.disk.smart_size.first_run: false
browser.cache.frecency_experiment: 2
browser.places.smartBookmarksVersion: 8
browser.startup.homepage_override.buildID: 20170717100212
browser.startup.homepage_override.mstone: 56.0a1
browser.urlbar.lastSuggestionsPromptDate: 20170717
browser.urlbar.timesBeforeHidingSuggestionsHint: 0
extensions.lastAppVersion: 56.0a1
media.gmp-gmpopenh264.abi: x86_64-gcc3
media.gmp-gmpopenh264.lastUpdate: 1500325599
media.gmp-gmpopenh264.version: 1.6
media.gmp-manager.buildID: 20170717100212
media.gmp-manager.lastCheck: 1500325594
media.gmp.storage.version.observed: 1
network.cookie.prefsMigrated: true
network.predictor.cleaned-up: true
places.history.expiration.transient_current_max_pages: 104858
plugin.disable_full_page_plugin_for_types: application/pdf

Important Locked Preferences
----------------------------

Places Database
---------------

JavaScript
----------

Incremental GC: true

Accessibility
-------------

Activated: false
Prevent Accessibility: 0

Library Versions
----------------

NSPR
Expected minimum version: 4.16 Beta
Version in use: 4.16 Beta

NSS
Expected minimum version: 3.32 Beta
Version in use: 3.32 Beta

NSSSMIME
Expected minimum version: 3.32 Beta
Version in use: 3.32 Beta

NSSSSL
Expected minimum version: 3.32 Beta
Version in use: 3.32 Beta

NSSUTIL
Expected minimum version: 3.32 Beta
Version in use: 3.32 Beta

Experimental Features
---------------------

Sandbox
-------

Seccomp-BPF (System Call Filtering): true
Seccomp Thread Synchronization: true
User Namespaces: true
Content Process Sandboxing: true
Media Plugin Sandboxing: true
Content Process Sandbox Level: 2
Effective Content Process Sandbox Level: 2

Rejected System Calls
---------------------

Comment 1

[Andrew Swan [:aswan]]

This is a doozy.
At startup we load screenshots which, among other things, tries to load any dynamically granted extension permissions:
http://searchfox.org/mozilla-central/rev/88180977d79654af025158d8ebeb8c2aa11940eb/toolkit/components/extensions/ExtensionPermissions.jsm#34

That work is asynchronous so it doesn't block startup.  But since you're using -silent, the browser is immediately shut down, which triggers JSONFile's AsyncShutdown blocker:
http://searchfox.org/mozilla-central/rev/01d27fdd3946f7210da91b18fcccca01d7324fe2/toolkit/modules/JSONFile.jsm#117

That code runs quickly and invalidates the JSONFile object that ExtensionPermissions created (by setting its `dataReady` property to false).  Now, when the original permissions I/O finishes (it fails since this is a fresh profile without an extension-preferences.json file but that doesn't really matter) we get back into code that assumes we have a valid permissions JSONFile and it blows up here:
http://searchfox.org/mozilla-central/rev/88180977d79654af025158d8ebeb8c2aa11940eb/toolkit/components/extensions/ExtensionPermissions.jsm#58

This is a very specific sequence of events but I think it represents a larger problem that we can begin shutting down extensions before we finish starting them up.  My naive thought is that we could address this by having extension startup be a very early shutdown blocker.  Kris what do you think?

Comment 2

[Kris Maglione [:kmag]]

(In reply to Andrew Swan [:aswan] from comment #1)
> This is a very specific sequence of events but I think it represents a
> larger problem that we can begin shutting down extensions before we finish
> starting them up.  My naive thought is that we could address this by having
> extension startup be a very early shutdown blocker.  Kris what do you think?

We already block extension shutdown on extension startup, and we block app shutdown on extension shutdown. We also block OS.File shutdown on extension startup, but *shrug*. But Screenshots handles the startup of its WebExtension itself, and it's possible it does it after the phase of shutdown that we normally block.

Comment 3

[Brian Birtles (:birtles)]

SlimerJS (after patching a couple of other bits of breakage) also appears to be broken with more-or-less the same symptoms. 

Specifically, the part from 'WARNING: At least one completion condition is taking too long to complete. Conditions: [{"name":"EnvironmentAddonBuilder","state":"(none)","filename":"resource://gre/modules/TelemetryEnvironment.jsm"...' is the same.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

Hey Andrew, does comment 3 make you want to re-evaluate the priority?

Comment 5

[Andrew Swan [:aswan]]

(In reply to Panos Astithas [:past] (56 Regression Engineering Owner) (please ni?) from comment #4)
> Hey Andrew, does comment 3 make you want to re-evaluate the priority?

Sorry, this totally fell through the cracks when I was traveling.  This is important, to be sure, but I simply don't have the cycles to look at it right now.  I strongly suspect the issue is actually that Screenshots is doing deferred startup even when the browser is shutting down.

Ian, can you take a look?  (and I think this needs to move to github if it is in fact a Screenshots issue)

Comment 6

[Laurent Jouanneau]

Hi,

This is a blocker for SlimerJS, as Firefox is crashing during the shutting down:

```
WARNING: At least one completion condition is taking too long to complete. Conditions: [{"name":"EnvironmentAddonBuilder","state":"(none)","filename":"resource://gre/modules/TelemetryEnvironment.jsm","lineNumber":502,"stack":["resource://gre/modules/TelemetryEnvironment.jsm:init:502","resource://gre/modules/TelemetryEnvironment.jsm:EnvironmentCache:864","resource://gre/modules/TelemetryEnvironment.jsm:getGlobal:63","resource://gre/modules/TelemetryEnvironment.jsm:get currentEnvironment:70","jar:file:///home/laurent/bin/firefox/omni.ja!/components/TelemetryStartup.js:annotateEnvironment:42","jar:file:///home/laurent/bin/firefox/omni.ja!/components/TelemetryStartup.js:TelemetryStartup.prototype.observe:32"]}] Barrier: AddonManager: Waiting for providers to shut down.
WARNING: At least one completion condition is taking too long to complete. Conditions: [{"name":"AddonManager: shutting down.","state":[{"name":"AddonManager: Waiting for providers to shut down.","state":[{"name":"EnvironmentAddonBuilder","state":"(none)","filename":"resource://gre/modules/TelemetryEnvironment.jsm","lineNumber":502,"stack":["resource://gre/modules/TelemetryEnvironment.jsm:init:502","resource://gre/modules/TelemetryEnvironment.jsm:EnvironmentCache:864","resource://gre/modules/TelemetryEnvironment.jsm:getGlobal:63","resource://gre/modules/TelemetryEnvironment.jsm:get currentEnvironment:70","jar:file:///home/laurent/bin/firefox/omni.ja!/components/TelemetryStartup.js:annotateEnvironment:42","jar:file:///home/laurent/bin/firefox/omni.ja!/components/TelemetryStartup.js:TelemetryStartup.prototype.observe:32"]}]},{"name":"AddonRepository: async shutdown","state":"pending"}],"filename":"resource://gre/modules/AddonManager.jsm","lineNumber":898,"stack":["resource://gre/modules/AddonManager.jsm:startup:898","resource://gre/modules/AddonManager.jsm:startup:3090","jar:file:///home/laurent/bin/firefox/omni.ja!/components/addonManager.js:observe:65"]}] Barrier: profile-before-change
FATAL ERROR: AsyncShutdown timeout in AddonManager: Waiting for providers to shut down. Conditions: [{"name":"EnvironmentAddonBuilder","state":"(none)","filename":"resource://gre/modules/TelemetryEnvironment.jsm","lineNumber":502,"stack":["resource://gre/modules/TelemetryEnvironment.jsm:init:502","resource://gre/modules/TelemetryEnvironment.jsm:EnvironmentCache:864","resource://gre/modules/TelemetryEnvironment.jsm:getGlobal:63","resource://gre/modules/TelemetryEnvironment.jsm:get currentEnvironment:70","jar:file:///home/laurent/bin/firefox/omni.ja!/components/TelemetryStartup.js:annotateEnvironment:42","jar:file:///home/laurent/bin/firefox/omni.ja!/components/TelemetryStartup.js:TelemetryStartup.prototype.observe:32"]}] At least one completion condition failed to complete within a reasonable amount of time. Causing a crash to ensure that we do not leave the user with an unresponsive process draining resources.
WARNING: No crash reporter available
src/slimerjs : ligne 167 : 14734 Erreur de segmentation  (core dumped) "$SLIMERJSLAUNCHER" -app "$SLIMERDIR/application.ini" $PROFILE -no-remote "$@" 2> /dev/null
```

Note: all prefs about telemetry have been disabled (toolkit.telemetry.unified, toolkit.telemetry.enabled etc) in SlimerJS

Comment 7

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Two observations to add:

1. This bug seems to occur only on first run for a given test profile. On the second run, Firefox exits immediately with different terminal output:

JavaScript error: resource://gre/modules/AddonManager.jsm, line 2302: TypeError: AddonManagerInternal._getProviderByName(...) is undefined
*** UTM:SVC TimerManager:registerTimer called after profile-before-change notification. Ignoring timer registration for id: telemetry_modules_ping


2. If I disable screenshots in a new profile _before_ first run, by adding the line |user_pref("extensions.screenshots.disabled", true)| inside the profile's prefs.js, then firefox -silent still hangs, but I get a slightly different error on first run. The error seems to point to TelemetryStartup.js running after profile-before-change, but the code comments in that file assume it runs _before_ that event.

If I run the profile a second time, I get the same immediate exit + error message as given under (1) above.

Here's the slightly different error output from first run with screenshots disabled:

jhirsch-35282:git-gecko jhirsch$ ./build-artifacts/dist/Nightly.app/Contents/MacOS/firefox -P epsilon -silent
JavaScript error: resource://gre/modules/DeferredSave.jsm, line 223: TypeError: pending is null
*** UTM:SVC TimerManager:registerTimer called after profile-before-change notification. Ignoring timer registration for id: recipe-client-addon-run

WARNING: At least one completion condition is taking too long to complete. Conditions: [{"name":"EnvironmentAddonBuilder","state":"(none)","filename":"resource://gre/modules/TelemetryEnvironment.jsm","lineNumber":504,"stack":["resource://gre/modules/TelemetryEnvironment.jsm:init:504","resource://gre/modules/TelemetryEnvironment.jsm:EnvironmentCache:866","resource://gre/modules/TelemetryEnvironment.jsm:getGlobal:63","resource://gre/modules/TelemetryEnvironment.jsm:get currentEnvironment:70","file:///Users/jhirsch/codez/mozilla/git-gecko/build-artifacts/dist/Nightly.app/Contents/Resources/components/TelemetryStartup.js:annotateEnvironment:42","file:///Users/jhirsch/codez/mozilla/git-gecko/build-artifacts/dist/Nightly.app/Contents/Resources/components/TelemetryStartup.js:TelemetryStartup.prototype.observe:32"]}] Barrier: AddonManager: Waiting for providers to shut down.
WARNING: At least one completion condition is taking too long to complete. Conditions: [{"name":"AddonManager: shutting down.","state":[{"name":"AddonManager: Waiting for providers to shut down.","state":[{"name":"EnvironmentAddonBuilder","state":"(none)","filename":"resource://gre/modules/TelemetryEnvironment.jsm","lineNumber":504,"stack":["resource://gre/modules/TelemetryEnvironment.jsm:init:504","resource://gre/modules/TelemetryEnvironment.jsm:EnvironmentCache:866","resource://gre/modules/TelemetryEnvironment.jsm:getGlobal:63","resource://gre/modules/TelemetryEnvironment.jsm:get currentEnvironment:70","file:///Users/jhirsch/codez/mozilla/git-gecko/build-artifacts/dist/Nightly.app/Contents/Resources/components/TelemetryStartup.js:annotateEnvironment:42","file:///Users/jhirsch/codez/mozilla/git-gecko/build-artifacts/dist/Nightly.app/Contents/Resources/components/TelemetryStartup.js:TelemetryStartup.prototype.observe:32"]}]},{"name":"AddonRepository: async shutdown","state":"pending"}],"filename":"resource://gre/modules/AddonManager.jsm","lineNumber":889,"stack":["resource://gre/modules/AddonManager.jsm:startup:889","resource://gre/modules/AddonManager.jsm:startup:3082","file:///Users/jhirsch/codez/mozilla/git-gecko/build-artifacts/dist/Nightly.app/Contents/Resources/components/addonManager.js:observe:65"]}] Barrier: profile-before-change

FATAL ERROR: AsyncShutdown timeout in AddonManager: Waiting for providers to shut down. Conditions: [{"name":"EnvironmentAddonBuilder","state":"(none)","filename":"resource://gre/modules/TelemetryEnvironment.jsm","lineNumber":504,"stack":["resource://gre/modules/TelemetryEnvironment.jsm:init:504","resource://gre/modules/TelemetryEnvironment.jsm:EnvironmentCache:866","resource://gre/modules/TelemetryEnvironment.jsm:getGlobal:63","resource://gre/modules/TelemetryEnvironment.jsm:get currentEnvironment:70","file:///Users/jhirsch/codez/mozilla/git-gecko/build-artifacts/dist/Nightly.app/Contents/Resources/components/TelemetryStartup.js:annotateEnvironment:42","file:///Users/jhirsch/codez/mozilla/git-gecko/build-artifacts/dist/Nightly.app/Contents/Resources/components/TelemetryStartup.js:TelemetryStartup.prototype.observe:32"]}] At least one completion condition failed to complete within a reasonable amount of time. Causing a crash to ensure that we do not leave the user with an unresponsive process draining resources.
[43686, Main Thread] ###!!! ABORT: file resource://gre/modules/TelemetryEnvironment.jsm, line 504
[43686, Main Thread] ###!!! ABORT: file resource://gre/modules/TelemetryEnvironment.jsm, line 504

Comment 8

[Marcia Knous [:marcia]]

This is the top browser crash in early 57 results, with 823 crashes. We will see what happens when we increase the release population size.

Comment 9

[Andrew Swan [:aswan]]

Marcia, do crash reports include the command line?  (I don't see it in the publicly accessible metadata)
I ask since the only STR we have here are for running with -silent, I can try to get to the bottom of that but want to make sure its actually the same thing that's coming in from the field.

Comment 10

[Bob Clary [:bc] (inactive)]

It seems a number of the reports include comments about failures reading configuration files while others are on company issued machines which are locked down. Possible this is a permissions problem due to sandboxing?

Comment 11

[Marcia Knous [:marcia]]

(In reply to Andrew Swan [:aswan] from comment #9)
> Marcia, do crash reports include the command line?  (I don't see it in the
> publicly accessible metadata)
> I ask since the only STR we have here are for running with -silent, I can
> try to get to the bottom of that but want to make sure its actually the same
> thing that's coming in from the field.

I don't believe they do.

Comment 12

[Andrew Swan [:aswan]]

So this is due to the fact that at least when run with -silent, telemetry tries to do a bunch of work after the addons manager has shut down:
https://searchfox.org/mozilla-central/rev/550148ab69b2879bfb82ffa698720ede1fa626f2/toolkit/components/telemetry/TelemetryStartup.js#32

It ends up waiting forever here:
https://searchfox.org/mozilla-central/rev/550148ab69b2879bfb82ffa698720ede1fa626f2/toolkit/components/telemetry/TelemetryEnvironment.jsm#516-524

But the underlying problem is trying to use the addons manager after it has been shut down.  This is all related to the discussion back in bug 1358907 about whether telemetry needs to wait for the extensions database to load to get detailed information about installed extensions.  The only options I see are to relax that requirement so that telemetry doesn't need to be interacting with the addons manager in a shutdown blocker or to shuffle around the telemetry shutdown code to ensure that it interacts with the addons manager before the addons manager is shut down.

Comment 13

[Georg Fritzsche [:gfritzsche]]

[Tracking Requested - why for this release]:
This is a shutdown hang with non-trivial volume, affecting SlimerJS.

Comment 14

[Marcia Knous [:marcia]]

Tracking 58+ per Comment 13.

Comment 15

[Chris H-C :chutten]

On startup Telemetry wants to annotate crash reports with the full Environment. Telemetry doesn't have the full environment until the addon db loads, so we await a promise that waits for the addon db to load. (At the same time we register this as a shutdown blocker to try and make sure the AOM doesn't shut down before we get the data out of the db)

The unfortunate part comes when the addon db doesn't need to be loaded due to running some shortlived tests that don't ask for addon information. Since those tests don't care about the TelemetryEnvironment, it doesn't register a shutdown blocker and all is well.

The problem with -silent is that we need to actually do Telemetry work on this short-lived session. So we register the shutdown blocker but don't actually ever ask AOM to load the db (because we want that to happen as late as possible).

After a long and fruitful conversation with :aswan on #developers he has proposed that Telemetry ask AOM to be sure to load the db before shutdown around the same time we register the shutdown blocker so that the db does, in fact, eventually load (if only _just_ at shutdown).

This is preferable to an older idea of "always make sure the db loads at least once per session" because that idea would load the db unnecessarily during many tests.

Over to :aswan.

Comment 16

[Andrew Swan [:aswan]]

Doh this is actually much more subtle than what we talked about on IRC.

Turns out we do actually have the "always load the db once per session" behvaior:
https://searchfox.org/mozilla-central/rev/919dce54f43356c22d6ff6b81c07ef412b1bf933/toolkit/mozapps/extensions/internal/XPIProvider.jsm#2366-2371

So, with "firefox -silent", we have this call chain:
anonymous async function in EnvironmentAddonBuilder.init()
calls EnvironmentAddonBuilder._updateAddons()
calls EnvironmentAddonBuilder._getActiveAddons()

In fact what's happening is that when this code down in _getActiveAddons() runs the extensions database *is* loaded and we get full details for active extensions:
https://searchfox.org/mozilla-central/rev/919dce54f43356c22d6ff6b81c07ef412b1bf933/toolkit/components/telemetry/TelemetryEnvironment.jsm#653

However, this code is racing against the AddonManager shutdown code so by the time we get back out to this code in the anonymous init function, the AddonManager has been shut down:
https://searchfox.org/mozilla-central/rev/919dce54f43356c22d6ff6b81c07ef412b1bf933/toolkit/components/telemetry/TelemetryEnvironment.jsm#512

Since the AddonManager is shut down, isDBLoaded is false, and we wait forever.  But in this case there's no need to wait since we did in fact get detailed information about active extensions.

I suggest that EnvironmentAddonBuilder should stop calling isDBLoaded and should just directly keep track of whether it has partial or complete data on active extensions.  That means adding a flag to EnvironmentAddonBuilder and consulting that flag when deciding whether to wait for the xpi-database-loaded notification at line 512 of TelemetryEnvironment.js (see permalink above).  But that flag should also be populated by looking at the data that comes back from AddonManager.getActiveAddons() and not from a separate call to isDBLoaded since even that check has an inherent race condition.  In fact, if I remember correctly I originally implemented it this way in bug 1358907 but was asked to change that to the explicit isDBLoaded check during review.  If just looking at what properties are present in the objects that come back from getActiveAddons() is distasteful, we can change the return value of getActiveAddons to be an object something like {fullData: true|false, addons: [...]}

And for the bad news, I'm about to leave for Thanksgiving.  Chris/Rob can one of you pick this up?  (I'll have my laptop with me and can check in during the week but I won't have time to finish and fully test a complete patch, sorry for the bad timing...)

Comment 17

[Chris H-C :chutten]

Ah, I see, in bug 1358907 comment 17 :gfritzsche recommended we choose a clearer (but apparently more race-prone) isDBLoaded vs checking for anAddon.appDisabled

I'm in favour of signalling through the return whether the data is complete. Luckily for us getActiveAddons is used in only a few places, so changing its semantics should have limited fallout.

I can pick this up.

Comment 18

[Chris H-C :chutten]

Attachment: bug 1381633 - Communicate whether getActiveAddons is serving full data

getActiveAddons can either return partial or full data for use by the Telemetry
Environment. This is just a spike that communicates that difference out of
XPIProvider and into the Environment so we know whether the DB has been loaded.

Review commit: https://reviewboard.mozilla.org/r/201728/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/201728/

Comment 19

[Chris H-C :chutten]

This patch airlifts "was the db loaded" up a few layers of abstraction to the Telemetry Environment. It's simplistic, but it gets rid of the shutdown hang in the STR provided.

Comment 20

[Robert Helmer [:rhelmer]]

Comment on attachment 8930607 [details]
bug 1381633 - Communicate whether getActiveAddons is serving full data

https://reviewboard.mozilla.org/r/201728/#review207006

lgtm - I suspect we could do something a little more clever here (like having a promise that resolves when the db is loaded rather than just using a bool) but I think this is clear enough and fixes the crash now.

::: toolkit/mozapps/extensions/AddonManager.jsm:2503
(Diff revision 1)
>     * amount of information about only active addons.  Consequently, it
>     * can be implemented by providers using only immediately available
>     * data as opposed to getAddonsByTypes which may require I/O).
>     *
>     * @param  aTypes
>     *         An optional array of types to retrieve. Each type is a string name

Would you mind adding a jsdoc comment here with some info about the object this resolves with now? Thanks!

Comment 21

[Chris H-C :chutten]

Comment on attachment 8930607 [details]
bug 1381633 - Communicate whether getActiveAddons is serving full data

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/201728/diff/1-2/

Comment 22

[Alessio Placitelli [:Dexter]]

Comment on attachment 8930607 [details]
bug 1381633 - Communicate whether getActiveAddons is serving full data

https://reviewboard.mozilla.org/r/201728/#review207298

This was very subtle, good catch!

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81abb6b13cbc
Communicate whether getActiveAddons is serving full data r=Dexter,rhelmer

Comment 24

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/81abb6b13cbc

Comment 25

[Julien Cristau [:jcristau]]

Please request uplift to beta when you have a chance.

Comment 26

[Chris H-C :chutten]

Comment on attachment 8930607 [details]
bug 1381633 - Communicate whether getActiveAddons is serving full data

Approval Request Comment
[Feature/Bug causing the regression]: Unsure. Possibly bug 1358907
[User impact if declined]: firefox silent misbehaves, affects SlimerJS
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: More or less. There have been no reports of crashes by this signature on Nightly builds with the fix. It isn't the most common of crashes, though, so this isn't the strongest of evidence. I have tried to reproduce the crash on nightly myself, without luck.
[Needs manual test from QE? If yes, steps to reproduce]: Yes.
STR:
1) firefox -CreateProfile testprofile
2) Edit testprofile's pref.js to include the line `user_pref("extensions.screenshots.disabled", true);`
3) firefox -P testprofile -silent
It should not complain about completion conditions, "Data is not ready" or EnvironmentAddonBuilder
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: Not really
[Why is the change risky/not risky?]: It is possible, that if something is wrong in the patch, that some Telemetry pings may no longer contain the full addons details in their payloads. I've reviewed the pings coming from nightly builds containing the fix and they appear to be intact at roughly the same ratio as before the fix, so I think everything's fine.
[String changes made/needed]: None.

Comment 27

[Gerry Chang [:gchang]]

Comment on attachment 8930607 [details]
bug 1381633 - Communicate whether getActiveAddons is serving full data

Fix a crash. Beta58+.

Comment 28

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ea066a148edc

Comment 29

[Bogdan Maris, Desktop Test Engineering]

Reproduced the initial crash using old Nightly from 2017-07-17 and Fx 57.0.3 on Ubuntu 16.04 64bit.

Verified that the crash does not occur anymore using steps from comment 26 on Fx 58.0b13 and latest Nightly 59.0a1 across platforms (Windows 7 x86, Ubuntu 16.04 x64 and macOS 10.13).