1381704 - Extend Safe Browsing telemetry probes

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, enhancement, P2)

Description

[François Marier [:francois]]

Given that Safe Browsing telemetry probes are all within Category 1 (https://wiki.mozilla.org/Firefox/Data_Collection#Data_Collection_Categories), we'd like to extend them to cover our release population.

These performance-related are monitored via the email alerts and therefore should be permanent and opt-out:

URLCLASSIFIER_SHUTDOWN_TIME
URLCLASSIFIER_VLPS_FILELOAD_TIME
URLCLASSIFIER_VLPS_FALLOCATE_TIME
URLCLASSIFIER_VLPS_CONSTRUCT_TIME
URLCLASSIFIER_UPDATE_SERVER_RESPONSE_TIME
URLCLASSIFIER_COMPLETE_SERVER_RESPONSE_TIME

These ones are already permanent and only need to be made opt-out:

URLCLASSIFIER_PS_CONSTRUCT_TIME
URLCLASSIFIER_PS_FALLOCATE_TIME
URLCLASSIFIER_PS_FILELOAD_TIME
URLCLASSIFIER_ASYNC_CLASSIFYLOCAL_TIME
URLCLASSIFIER_CLASSIFYLOCAL_TIME
URLCLASSIFIER_CL_KEYED_UPDATE_TIME
URLCLASSIFIER_CL_CHECK_TIME
URLCLASSIFIER_LOOKUP_TIME_2

We need to find a good way to monitor these (they are currently looked at manually about once per release), but they are quite useful in terms of detecting problems with server connections so we'd like to have them permanent and opt-out:

URLCLASSIFIER_UPDATE_REMOTE_NETWORK_ERROR
URLCLASSIFIER_UPDATE_ERROR
URLCLASSIFIER_UPDATE_TIMEOUT
URLCLASSIFIER_COMPLETION_ERROR
URLCLASSIFIER_COMPLETE_TIMEOUT2

The same goes for these except they're already permanent, so we'd just need to make them opt-out:

URLCLASSIFIER_COMPLETE_REMOTE_STATUS2
URLCLASSIFIER_UPDATE_REMOTE_STATUS2

Finally, these ones are exploratory but we will be keeping a close eye on them as we roll-out the new V4 stack over the next 6-months to 1 year, therefore we'd like to have them expire in 12 months and be opt-out:

URLCLASSIFIER_VLPS_LOAD_CORRUPT
URLCLASSIFIER_VLPS_LONG_PREFIXES
URLCLASSIFIER_POSITIVE_CACHE_DURATION
URLCLASSIFIER_NEGATIVE_CACHE_DURATION

Finally, probes are now required to have someone's email attached to them so we should add [e-mail] to all of the URLCLASSIFIER and APPLICATION_REPUTATION probes.

Comment 1

[François Marier [:francois]]

These ones are already permanent but would benefit from being opt-out on release too since they allow us to monitor whether or not this feature is working in the real world:

APPLICATION_REPUTATION_SHOULD_BLOCK
APPLICATION_REPUTATION_LOCAL
APPLICATION_REPUTATION_SERVER

and this one is not particularly useful so it should be removed:

APPLICATION_REPUTATION_COUNT

Comment 2

[François Marier [:francois]]

Attachment: Bug 1381704 - Extend Safe Browsing telemetry probes.

Review commit: https://reviewboard.mozilla.org/r/171396/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/171396/

Comment 3

[François Marier [:francois]]

Attachment: Bug 1381704 - Remove unused Application Reputation telemetry probe.

Review commit: https://reviewboard.mozilla.org/r/171398/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/171398/

Comment 4

[Henry Chang [:hchang]]

Comment on attachment 8900054 [details]
Bug 1381704 - Extend Safe Browsing telemetry probes.

https://reviewboard.mozilla.org/r/171396/#review176568

Comment 5

[François Marier [:francois]]

Comment on attachment 8900055 [details]
Bug 1381704 - Remove unused Application Reputation telemetry probe.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/171398/diff/1-2/

Comment 6

[Henry Chang [:hchang]]

Comment on attachment 8900055 [details]
Bug 1381704 - Remove unused Application Reputation telemetry probe.

https://reviewboard.mozilla.org/r/171398/#review176572

Comment 7

[Chenxia Liu [:liuche]]

Comment on attachment 8900054 [details]
Bug 1381704 - Extend Safe Browsing telemetry probes.

https://reviewboard.mozilla.org/r/171396/#review176962

Comment 8

[Chenxia Liu [:liuche]]

Comment on attachment 8900055 [details]
Bug 1381704 - Remove unused Application Reputation telemetry probe.

https://reviewboard.mozilla.org/r/171398/#review176964

yes, removing probes!

Comment 9

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s c39ce985ad62 -d 4f0c2d08aa32: rebasing 415357:c39ce985ad62 "Bug 1381704 - Extend Safe Browsing telemetry probes. r=hchang,liuche"
merging toolkit/components/telemetry/Histograms.json
rebasing 415358:e39d81b9c105 "Bug 1381704 - Remove unused Application Reputation telemetry probe. r=hchang,liuche" (tip)
merging toolkit/components/downloads/test/unit/test_app_rep.js
merging toolkit/components/telemetry/Histograms.json
warning: conflicts while merging toolkit/components/downloads/test/unit/test_app_rep.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 10

[François Marier [:francois]]

Comment on attachment 8900054 [details]
Bug 1381704 - Extend Safe Browsing telemetry probes.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/171396/diff/1-2/

Comment 11

[François Marier [:francois]]

Comment on attachment 8900055 [details]
Bug 1381704 - Remove unused Application Reputation telemetry probe.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/171398/diff/2-3/

Comment 12

[François Marier [:francois]]

Comment on attachment 8900055 [details]
Bug 1381704 - Remove unused Application Reputation telemetry probe.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/171398/diff/3-4/

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1505d31ad0f
Extend Safe Browsing telemetry probes. r=hchang,liuche
https://hg.mozilla.org/integration/autoland/rev/ee32fa61c1ba
Remove unused Application Reputation telemetry probe. r=hchang,liuche

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c1505d31ad0f
https://hg.mozilla.org/mozilla-central/rev/ee32fa61c1ba