1381714 - Should disable Auto-Migration on all channels

Status: VERIFIED FIXED

(Firefox :: Migration, defect, P1)

Description

[Fischer [:Fischer]]

After discussion with the product team and the UX team, the activity stream team is doing the manual migration now [1] and we are going for the manual migration for 57 [2]. the Auto-mirgation currently is enabled on the Nightly and Early Beta[3]. Since the manual migration is coming, we should disable the Auto-mirgation for all channels in case that these 2 features affect each other.

[1] https://github.com/mozilla/activity-stream/issues/2787
[2] Bug 1374560 - [UX] Manual-migration UX Spec
[3] https://dxr.mozilla.org/mozilla-central/rev/aff336ac161daa3ea350e59a288963edbd58ed39/browser/app/profile/firefox.js#1625

Comment 1

[Fischer [:Fischer]]

Attachment: Bug 1381714 - Should disable Auto-Migration on all channels,

The activity stream team is doing the manual migration [1] and we are going for the manual migration [2]. With the coming of the manual migration, we should disable the auto-migration so these 2 features will not affect each other.

[1] https://github.com/mozilla/activity-stream/issues/2787
[2] Bug 1374560 - [UX] Manual-migration UX Spec

Review commit: https://reviewboard.mozilla.org/r/158104/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158104/

Comment 2

[Mozilla Autoland]

hg error in cmd: hg push -r . -f try: pushing to ssh://hg.mozilla.org/try
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 2 changesets with 1 changes to 1 files (+1 heads)
remote: autoland push detected
remote: recorded push in pushlog
remote: 
remote: View your changes here:
remote:   https://hg.mozilla.org/try/rev/9164d3f968eaf0a45fe9cb5244d787b0de36409c
remote:   https://hg.mozilla.org/try/rev/1a9712ff50224d0f19d0f7ee0d57ffb17fbff74a
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a9712ff50224d0f19d0f7ee0d57ffb17fbff74a
remote: recorded changegroup in replication log in 0.135s
remote: ** unknown exception encountered, please report by visiting
remote: ** https://mercurial-scm.org/wiki/BugTracker
remote: ** Python 2.7.5 (default, Nov  6 2016, 00:28:07) [GCC 4.8.5 20150623 (Red Hat 4.8.5-11)]
remote: ** Mercurial Distributed SCM (version 4.1.2)
remote: ** Extensions loaded: blackbox, clonebundles, obsolescencehacks, pushlog, serverlog, readonly, vcsreplicator
remote: Traceback (most recent call last):
remote:   File "/var/hg/venv_pash/bin/hg", line 45, in <module>
remote:     mercurial.dispatch.run()
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 63, in run
remote:     sys.exit((dispatch(request(pycompat.sysargv[1:])) or 0) & 255)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 129, in dispatch
remote:     ret = _runcatch(req)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 219, in _runcatch
remote:     return callcatch(ui, _runcatchfunc)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 227, in callcatch
remote:     return scmutil.callcatch(ui, func)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/scmutil.py", line 152, in callcatch
remote:     return func()
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 208, in _runcatchfunc
remote:     return _dispatch(req)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 811, in _dispatch
remote:     cmdpats, cmdoptions)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 563, in runcommand
remote:     ret = _runcommand(ui, options, cmd, d)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 819, in _runcommand
remote:     return cmdfunc()
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 808, in <lambda>
remote:     d = lambda: util.checksignature(func)(ui, *args, **strcmdopt)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/util.py", line 1051, in check
remote:     
remote: return func(*args, **kwargs)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/commands.py", line 5824, in serve
remote:     s.serve_forever()
remote:   File "/var/hg/version-control-tools/hgext/serverlog/__init__.py", line 320, in serve_forever
remote:     return super(sshserverwrapped, self).serve_forever()
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/sshserver.py", line 104, in serve_forever
remote:     while self.serve_one():
remote:   File "/var/hg/version-control-tools/hgext/serverlog/__init__.py", line 351, in serve_one
remote:     return super(sshserverwrapped, self).serve_one()
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/sshserver.py", line 122, in serve_one
remote:     rsp = wireproto.dispatch(self.repo, self, cmd)
remote:   File "/var/hg/version-control-tools/hgext/serverlog/__init__.py", line 343, in dispatch
remote:     return origdispatch(repo, proto, cmd)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/extensions.py", line 223, in closure
remote:     return func(*(args + a), **kw)
remote:   File "/var/hg/version-control-tools/pylib/vcsreplicator/vcsreplicator/hgext.py", line 359, in wireprotodispatch
remote:     return orig(repo, proto, command)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/wireproto.py", line 569, in dispatch
remote:     return func(repo, proto, *args)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/wireproto.py", line 982, in unbundle
remote:     proto._client())
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/exchange.py", line 1771, in unbundle
remote:     lockandtr[2].close()
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/transaction.py", line 43, in _active
remote:     return func(self, *args, **kwds)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/transaction.py", line 490, in close
remote:     self._postclosecallback[cat](self)
remote:   File "/var/hg/version-control-tools/hgext/pushlog/__init__.py", line 239, in onpostclose
remote:     conn.commit()
remote: sqlite3.OperationalError: database is locked
abort: stream ended unexpectedly (got 0 bytes, expected 4)

Comment 3

[Fischer [:Fischer]]

Comment on attachment 8887303 [details]
Bug 1381714 - Should disable Auto-Migration on all channels,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158104/diff/1-2/

Comment 4

[Fischer [:Fischer]]

(In reply to Mozilla Autoland from comment #2)
> hg error in cmd: hg push -r . -f try: pushing to ssh://hg.mozilla.org/try
> searching for changes
> remote: adding changesets
> remote: adding manifests
> remote: adding file changes
> remote: added 2 changesets with 1 changes to 1 files (+1 heads)
> remote: autoland push detected
> remote: recorded push in pushlog
> remote: 
> remote: View your changes here:
> remote:  
> https://hg.mozilla.org/try/rev/9164d3f968eaf0a45fe9cb5244d787b0de36409c
> remote:  
> https://hg.mozilla.org/try/rev/1a9712ff50224d0f19d0f7ee0d57ffb17fbff74a
> remote: 
> remote: Follow the progress of your build on Treeherder:
> remote:  
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=1a9712ff50224d0f19d0f7ee0d57ffb17fbff74a
Failed on triggering a try on Mozreview.
Here is the manual try push [1].
Could saw some failures on Windows 10 x64 debug but those shouldn't have to do with us because the same situation happne without our patch [2]

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=0f397127ad8c0b6e15107fcf842740106d714a95
[2] https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9648691955beadaa9bb11d087dd766777de22af

Comment 5

[:Gijs (he/him)]

Comment on attachment 8887303 [details]
Bug 1381714 - Should disable Auto-Migration on all channels,

https://reviewboard.mozilla.org/r/158104/#review163398

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/afe61e21c394
Should disable Auto-Migration on all channels, r=Gijs

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/afe61e21c394

Comment 8

[Justin [:JW_SoftvisionQA]]

I have verified that this is fixed.