Increase maximum size of autosized comment area

RESOLVED FIXED

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: wlach, Assigned: wlach)

Tracking

Production

Details

Attachments

(1 attachment)

The earlier maximum was 280px based loosely on github, but we should probably set it higher based on the amount of content that people frequently paste into comment areas on bugzilla-based sites.

Per the rationale here (https://bugzilla.mozilla.org/show_bug.cgi?id=1380352#c7):

"Increasing the maximum size is as easy as tweaking a number (max-height for the comment css selector). I don't really have a strong opinion on what it should be -- I semi-arbitrarily set it to 280px based on what github does, but it's possible it should be higher for bugzilla based on how people use our site. On Linux, the old default size of the comment box was about 387px when clicked (25 rows) -- that might be a sensible default here. After this patch lands, people can just resize if they want more as they did before."

I think 400px makes sense. Note that when the pr for bug 1380352 lands, users will still be able to manually resize even higher if they like.
Created attachment 8887349 [details] [review]
PR

This one at least is nice and simple.
Assignee: nobody → wlachance
Attachment #8887349 - Flags: review?(dylan)
Attachment #8887349 - Flags: review?(dylan) → review+
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Hi wlach, As arai pointed on the #bmo channel, the user is not able to manually resize the comment area beyond 400px. It kind of opposes your last statement on #c0
Flags: needinfo?(wlachance)
See Also: → bug 1383513
(In reply to Sebastin Santy [:seban] from comment #2)
> Hi wlach, As arai pointed on the #bmo channel, the user is not able to
> manually resize the comment area beyond 400px. It kind of opposes your last
> statement on #c0

I believe this is covered by bug 1383513
Flags: needinfo?(wlachance)
> I believe this is covered by bug 1383513

Yes!
You need to log in before you can comment on or make changes to this bug.