1381817 - twoPinnedWithOverflow configuration has intermittently different tabstrip scroll position

Status: RESOLVED FIXED

(Testing :: mozscreenshots, enhancement, P1)

Description

[Johann Hofmann [:johannh]]

This is basically permanently inconsistent on OSX, but I've seen it on Linux as well.

https://screenshots.mattn.ca/comparisons/mozilla-central/b8783d6fffdbebed01455743185cea68784d5367/mozilla-central/d43779e278d2e4d3e21dba2fcb585a3bf4b1288e/osx-10-10/primaryUI_098_tabsOutsideTitlebar_twoPinnedWithOverflow_normal_onlyNavBar_darkLWT.png

It's a bit too much to whitelist, I'd rather fix that programmatically by making sure we're scrolled all the way to the left in that config.

Comment 1

[Johann Hofmann [:johannh]]

Attachment: Bug 1381817 - Scroll tabstrip to the beginning in mozscreenshots twoPinnedWithOverflow config.

Review commit: https://reviewboard.mozilla.org/r/158834/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158834/

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8887928 [details]
Bug 1381817 - Scroll tabstrip to the beginning in mozscreenshots twoPinnedWithOverflow config.

https://reviewboard.mozilla.org/r/158834/#review198000

My concern (from months ago) was that this would be paving over a bug… Thoughts? Is it still happening now that stuff has stabilized?

Comment 3

[Johann Hofmann [:johannh]]

I think this has stopped, closing for now. We'll revisit if it appears again :)

Comment 4

[Johann Hofmann [:johannh]]

This has returned in full force, I've seen it very frequently on OSX and Win7 and infrequently on Win10 so far:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=f5dafe8991b323b824768bc2e9bc0979f2f7f8a8&newProject=mozilla-central&newRev=960f50c2e0a991ab2ab313132e69fb2c96cb7866&filter=twoPinned

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=0bb0f14672fdda31c19aea1ed829e050d693b9af&newProject=mozilla-central&newRev=b705100d6ca823ddafe43ba4188dce181dcd79fd&filter=twoPinned

I feel like this started again with introducing the density configurations, may also be related to bug 1354332.

It doesn't seem like a real world problem to me, but it could of course be. I'm not sure how to proceed here.

Comment 5

[Johann Hofmann [:johannh]]

I'll unassign myself from this for now until we figure out how to proceed. I'm happy to pass on ownership of this to one of the capstone students working on mozscreenshots. :)

Comment 6

[Johann Hofmann [:johannh]]

Comment on attachment 8887928 [details]
Bug 1381817 - Scroll tabstrip to the beginning in mozscreenshots twoPinnedWithOverflow config.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158834/diff/1-2/

Comment 7

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=635e14106ea9f633319079ecf89ba4fe1b8ce8c3

Comment 8

[Johann Hofmann [:johannh]]

Looking into this more I don't think it's a timing issue. The correct tabstrip position should be like this, I think:

https://public-artifacts.taskcluster.net/UbUeQ6WNSYe5OWkWIRhVXA/0/public/test_info/20171215215036-primaryUI_183_tabsInTitlebar_twoPinnedWithOverflow_maximized_onlyNavBar_noLWT_touchDensity.png

Where the second un-pinned tab is the first visible tab (because we select it and that causes scrolling to that tab). Even that screenshot is not perfect, there's a little space after the tab that looks incorrect.

A common intermittent is looking like this instead:
https://screenshots.mattn.ca/comparisons/mozilla-central/fff6ca61de4510d3ef0ad17751bd134fd576577a/mozilla-central/4398768baa23a1d1888116a484817e20f2701dcc/osx-10-10/primaryUI_183_tabsInTitlebar_twoPinnedWithOverflow_maximized_onlyNavBar_noLWT_touchDensity.png

And in that case I have no clue why it scrolls further, to the first un-pinned tab. Then there's stuff like https://screenshots.mattn.ca/comparisons/mozilla-central/22d2831cc1f41e1b3e1ebac9be5a7aff33684843/mozilla-central/57a108d1c90a9979e2b79dbf138e055ee07ed97b/osx-10-10/primaryUI_186_tabsInTitlebar_twoPinnedWithOverflow_maximized_onlyNavBar_darkLWT_touchDensity.png

which leaves me even more clueless.

In short, I think this is something we should just pave over for now. We have no indication that this is actually causing users trouble in the real world.

Comment 9

[Matthew N. [:MattN]]

Comment on attachment 8887928 [details]
Bug 1381817 - Scroll tabstrip to the beginning in mozscreenshots twoPinnedWithOverflow config.

https://reviewboard.mozilla.org/r/158834/#review214722

I'm not really convinced because it could be due to one of the other configuration changes (going from the previous setup to the current one) but I also want this intermittent to go away.

Comment 10

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 635e14106ea9 -d 63a089b7dc04: rebasing 439964:635e14106ea9 "Bug 1381817 - Scroll tabstrip to the beginning in mozscreenshots twoPinnedWithOverflow config. r=MattN" (tip)
merging browser/tools/mozscreenshots/mozscreenshots/extension/configurations/Tabs.jsm
warning: conflicts while merging browser/tools/mozscreenshots/mozscreenshots/extension/configurations/Tabs.jsm! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fcfbf4c2a330
Scroll tabstrip to the beginning in mozscreenshots twoPinnedWithOverflow config. r=MattN

Comment 12

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/fcfbf4c2a330