1382080 - stylo: Fix the rest of failure in test_system_font_serialization.html

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Xidorn Quan [:xidorn] UTC+11]

There are three failures left in that test after bug 1364286.

Two of them are because we drop the support of parsing -moz-use-system-font on font longhands. We should just bypass them for Stylo.

One of them is that we serialize the longhands in a different order than Gecko. We should fix that via ignoring the order somehow.

Should be an easy fix.

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

Attachment: Bug 1382080 - Fix remaining failures in test_system_font_serialization.html.

Review commit: https://reviewboard.mozilla.org/r/158992/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158992/

Comment 2

[Cameron McCormack (:heycam)]

According to CSSOM, shorthands should expand to to longhands in their canonical order.  css-fonts-4 defines the canonical order by reference to the grammar, although I guess that is insufficient to define the canonical order, since it doesn't say where the longhands that are reset to their initial values (like font-size-adjust) should go.  So I guess for now this is fine.

Comment 3

[Cameron McCormack (:heycam)]

Filed https://github.com/w3c/csswg-drafts/issues/1636 for that issue.

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 8888090 [details]
Bug 1382080 - Fix remaining failures in test_system_font_serialization.html.

https://reviewboard.mozilla.org/r/158992/#review165018

Comment 5

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s f338323aee4c -d a1cdfee7cb07: rebasing 408399:f338323aee4c "Bug 1382080 - Fix remaining failures in test_system_font_serialization.html. r=heycam" (tip)
merging layout/style/test/stylo-failures.md
warning: conflicts while merging layout/style/test/stylo-failures.md! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac12978e5346
Fix remaining failures in test_system_font_serialization.html. r=heycam

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ac12978e5346