Closed Bug 1382080 Opened 2 years ago Closed 2 years ago

stylo: Fix the rest of failure in test_system_font_serialization.html

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

Attachments

(1 file)

There are three failures left in that test after bug 1364286.

Two of them are because we drop the support of parsing -moz-use-system-font on font longhands. We should just bypass them for Stylo.

One of them is that we serialize the longhands in a different order than Gecko. We should fix that via ignoring the order somehow.

Should be an easy fix.
According to CSSOM, shorthands should expand to to longhands in their canonical order.  css-fonts-4 defines the canonical order by reference to the grammar, although I guess that is insufficient to define the canonical order, since it doesn't say where the longhands that are reset to their initial values (like font-size-adjust) should go.  So I guess for now this is fine.
Comment on attachment 8888090 [details]
Bug 1382080 - Fix remaining failures in test_system_font_serialization.html.

https://reviewboard.mozilla.org/r/158992/#review165018
Attachment #8888090 - Flags: review?(cam) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s f338323aee4c -d a1cdfee7cb07: rebasing 408399:f338323aee4c "Bug 1382080 - Fix remaining failures in test_system_font_serialization.html. r=heycam" (tip)
merging layout/style/test/stylo-failures.md
warning: conflicts while merging layout/style/test/stylo-failures.md! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ac12978e5346
Fix remaining failures in test_system_font_serialization.html. r=heycam
https://hg.mozilla.org/mozilla-central/rev/ac12978e5346
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.