Open Bug 1382453 Opened 7 years ago Updated 2 years ago

Intermittent testing/firefox-ui/tests/functional/sessionstore/<random> | AssertionError: Non private browsing windows should have been restored.

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Platform:
Unspecified
Windows
Type:
defect

Tracking

()

Status:
REOPENED
Tracking Flags:
Tracking Status
firefox56 --- affected

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

(Keywords: intermittent-failure) 

Maybe it was not such a great idea to only use the message for the assertions in all the tests:

>        self.assertEqual(self.convert_open_windows_to_set(), self.test_windows,
>                         msg='Non private windows and tabs should have been restored.')

As the log shows we do not really know what happened. Where no windows restored, or only the non-private browsing ones? So we might want to add that information to the message or simply get rid of it. The latter case might not be that clear but at least we would see the differences.

Erica, would you mind taking it?
Flags: needinfo?(ewright)
Btw. this is a Windows only test failure.
status-firefox56: --- → affected
OS: Unspecified → Windows
I can take it.
Flags: needinfo?(ewright)
Depends on: 1386744
Due to the latest changes on bug 1386744 the expected exception message got an unwanted carriage return. As such it is no longer printed correctly on Treeherder:

> 14:06:50 INFO - TEST-UNEXPECTED-FAIL | test_restore_windows_after_restart_and_quit.py TestSessionStoreEnabled.test_with_variety | AssertionError: Non private browsing windows should have 

Blake, is Erica still around to get this updated? Or should we find someone else?

But we have at least more information now, what's exactly failing:

14:06:50     INFO - TEST-UNEXPECTED-FAIL | test_restore_windows_after_restart_and_quit.py TestSessionStoreEnabled.test_with_variety | AssertionError: Non private browsing windows should have
14:06:50     INFO -                          been restored. Expected set([('http://127.0.0.1:64329/layout/mozilla_organizations.html', 'http://127.0.0.1:64329/layout/mozilla_community.html'), ('http://127.0.0.1:64329/layout/mozilla.html',), ('http://127.0.0.1:64329/layout/mozilla_governance.html', 'http://127.0.0.1:64329/layout/mozilla_grants.html')]), got set([(u'http://127.0.0.1:64329/layout/mozilla_organizations.html', u'http://127.0.0.1:64329/layout/mozilla_community.html'), (u'http://127.0.0.1:64329/layout/mozilla.html',), (u'about:newtab',)]).

So those are the additional windows, which are not correctly getting restored.
Flags: needinfo?(bwinton)
I'm afraid she's working on more important stuff for the next while, so we should find someone else to take a look at it.
Sorry about the change in priorities!
Flags: needinfo?(bwinton)
See Also: → 1446088

This specific failure doesn't seem to happen anymore on central, beta, and release.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Component: Firefox UI Tests → Session Restore
Product: Testing → Firefox
QA Contact: hskupin
Resolution: INCOMPLETE → ---
Summary: Intermittent test_restore_windows_after_restart_and_quit.py TestSessionStoreEnabled.test_with_variety | AssertionError: Non private windows and tabs should have been restored. → Intermittent testing/firefox-ui/tests/functional/sessionstore/<random> | AssertionError: Non private browsing windows should have been restored.
Version: Version 3 → unspecified

If there is a new perma failure you should always file a new bug given that the underlying cause is nearly all the time a new problem.

Flags: needinfo?(hskupin)

All the recent intermittents are perma failures as caused by bug 1499663. I asked to re-classify those failures and get a new bug filed.

Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.