1499663 - Build linux64-ccov with Clang

Status: RESOLVED FIXED

(Testing :: Code Coverage, enhancement)

Comment 1

[Simon Giesecke [:sg] [he/him]]

Just as a side node to this: if we stop doing ccov builds with gcc, we won't have any test executions with gcc builds anymore (only toolchain builds remain), which makes us even less aware of gcc-specific problems such as Bug 1601707.

Comment 2

[Marco Castelluccio [:marco]]

When we do this, we should check that bug 1565352 and all the bugs linked to it via See Also (and also the bugs linked to the linked bugs via their See Also) are all fixed.

Comment 3

[Marco Castelluccio [:marco]]

Attachment: Bug 1499663 - Build grcov so it's compatible with older libstdc++ versions. r=calixte

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/635691a01a7e
Build grcov so it's compatible with older libstdc++ versions. r=calixte DONTBUILD

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/635691a01a7e

Comment 6

[Calixte Denizet (:calixte)]

Attachment: Bug 1499663 - Switch to clang 11 on linux for ccov build

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eda78ac8babc
Switch to clang 11 on linux for ccov build r=marco

Comment 8

[Calixte Denizet (:calixte)]

Attachment: Bug 1499663 - Switch to clang 11 on linux fuzzing-ccov build

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c2fd9153cec
Switch to clang 11 on linux fuzzing-ccov build r=marco

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/eda78ac8babc

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4c2fd9153cec

Comment 12

[(Away)]

As part of this, maybe we should review previous skip-if = ccov settings, in case some have been fixed. What do you think? https://searchfox.org/mozilla-central/search?q=skip-if.*ccov&path=&case=false&regexp=true

Comment 13

[Calixte Denizet (:calixte)]

(In reply to :dmajor from comment #12)

As part of this, maybe we should review previous skip-if = ccov settings, in case some have been fixed. What do you think? https://searchfox.org/mozilla-central/search?q=skip-if.*ccov&path=&case=false&regexp=true

Some improvements have been made in llvm 12 around ccov instrumentation:
https://github.com/llvm/llvm-project/commit/63182c2ac0b643a60d397274e8a31166fc7243fa#diff-1facbb7775cd85de2af955bbf92eff42d4f2a9a44df09442867b46be73fbdd14
I really hope that it'll improve perf of ccov builds.
So wait for clang 12 and then we'll see if we can remove some of skip-if.

Comment 14

[(Away)]

Attachment: Move linux64-ccov builds to clang 12 rc2

Switching linux64-ccov builds to clang from gcc in bug 1499663 uncovered some performance problems that lead to test timeouts. These are addressed in clang 12. In order to ease the starring burden on sheriffs, let's give those builds a sneak preview of clang 12 even though general builds are not yet switching over.

Comment 15

[Phabricator Automation]

Comment on attachment 9206708 [details]
Move linux64-ccov builds to clang 12 rc2

Revision D107104 was moved to bug 1693288. Setting attachment 9206708 [details] to obsolete.

Comment 16

[Calixte Denizet (:calixte)]

I filed a bug about re-enabling some tests:
https://bugzilla.mozilla.org/show_bug.cgi?id=1739474