Closed Bug 1382489 Opened 2 years ago Closed 2 years ago

Handle user-entered: scheme in activity stream

Categories

(Firefox for Android :: General, enhancement)

ARM
Android
enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 56
Iteration:
1.26
Tracking Status
firefox56 --- fixed

People

(Reporter: liuche, Assigned: liuche)

Details

(Whiteboard: [MobileAS])

Attachments

(1 file)

In the current activity stream, we don't handle the user-entered: scheme and this results in a network error.
Assignee: nobody → liuche
Comment on attachment 8888580 [details]
Bug 1382489 - decode urls before opening them.

https://reviewboard.mozilla.org/r/159560/#review165336

lgtm.

I didn't know why this was necessary so I did some digging: bug 858994 added user-entered before URIs because Sync requires real URLs in the DB in order for it to work & users could pin non-URI sites with custom text which I assume would resolve to a search. bug 865299 was opened a while back to replace these user-entered:// URIs with the URIs these sites would actually resolve to and avoid this funky work-around.
Attachment #8888580 - Flags: review?(michael.l.comella) → review+
Iteration: --- → 1.26
Pushed by cliu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b75fbbd7f4a1
decode urls before opening them. r=mcomella
https://hg.mozilla.org/mozilla-central/rev/b75fbbd7f4a1
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.