1382489 - Handle user-entered: scheme in activity stream

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Chenxia Liu [:liuche]]

In the current activity stream, we don't handle the user-entered: scheme and this results in a network error.

Comment 1

[Chenxia Liu [:liuche]]

Attachment: Bug 1382489 - decode urls before opening them.

Review commit: https://reviewboard.mozilla.org/r/159560/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159560/

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8888580 [details]
Bug 1382489 - decode urls before opening them.

https://reviewboard.mozilla.org/r/159560/#review165336

lgtm.

I didn't know why this was necessary so I did some digging: bug 858994 added user-entered before URIs because Sync requires real URLs in the DB in order for it to work & users could pin non-URI sites with custom text which I assume would resolve to a search. bug 865299 was opened a while back to replace these user-entered:// URIs with the URIs these sites would actually resolve to and avoid this funky work-around.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b75fbbd7f4a1
decode urls before opening them. r=mcomella

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b75fbbd7f4a1