If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

update Private Browsing overlay and notification description

VERIFIED FIXED in Firefox 56

Status

()

Firefox
New Tab Page
P1
normal
VERIFIED FIXED
2 months ago
a month ago

People

(Reporter: gasolin, Assigned: gasolin)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 56
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [photon-onboarding])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 months ago
These string are legal approved. According to bug 1381351 comment 7 we will use these string for both v56/v57 tour

notification: Want to keep something to yourself? Use Private Browsing with Tracking Protection.

overlay: Want to keep something to yourself? Use Private Browsing with Tracking Protection and Firefox will block online trackers while you browse. Then, when you end your session, Firefox clears your search and browsing history.
(Assignee)

Updated

2 months ago
Flags: qe-verify+
Priority: -- → P2
Whiteboard: [photon-onboarding]
Target Milestone: --- → Firefox 57

Updated

2 months ago
QA Contact: jwilliams
(Assignee)

Updated

2 months ago
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
(Assignee)

Comment 2

2 months ago
Comment on attachment 8888619 [details]
Bug 1382510 - update Private Browsing overlay and notification description;

Hi gijs, could you help confirm the description in comment 1 is true, since the private browsing page discribed that Private browing does not save visited pages and searches
Attachment #8888619 - Flags: feedback?(gijskruitbosch+bugs)
(Assignee)

Comment 3

2 months ago
The sentence in concern is "Then, when you end your session, Firefox clears your search and browsing history."
Comment on attachment 8888619 [details]
Bug 1382510 - update Private Browsing overlay and notification description;

https://reviewboard.mozilla.org/r/159632/#review165050
Attachment #8888619 - Flags: review?(francesco.lodolo) → review+

Comment 5

2 months ago
Comment on attachment 8888619 [details]
Bug 1382510 - update Private Browsing overlay and notification description;

(In reply to Fred Lin [:gasolin] from comment #2)
> Comment on attachment 8888619 [details]
> Bug 1382510 - update Private Browsing overlay and notification description;
> 
> Hi gijs, could you help confirm the description in comment 1 is true, since
> the private browsing page discribed that Private browing does not save
> visited pages and searches

302 Ehsan/JDM, but this doesn't seem right to me. My understanding is that one of the 'points' of private browsing is that it doesn't save history to begin with, so it feels like "when you end your session, Firefox clears your search and browsing history" is a misrepresentation of the facts.
Attachment #8888619 - Flags: feedback?(josh)
Attachment #8888619 - Flags: feedback?(gijskruitbosch+bugs)
Attachment #8888619 - Flags: feedback?(ehsan)
(Assignee)

Comment 6

2 months ago
Verdi, please talk with Michell that we might miss-interpret the private browsing behavior, it will be nice if you can suggest proper strings here.
Flags: needinfo?(mverdi)

Comment 7

2 months ago
mozreview-review
Comment on attachment 8888619 [details]
Bug 1382510 - update Private Browsing overlay and notification description;

https://reviewboard.mozilla.org/r/159632/#review165222
Attachment #8888619 - Flags: review?(dtownsend) → review+
Comment on attachment 8888619 [details]
Bug 1382510 - update Private Browsing overlay and notification description;

https://reviewboard.mozilla.org/r/159632/#review165248

As Gijs said, this is misrepresenting what the PB mode does.
Attachment #8888619 - Flags: review-
Attachment #8888619 - Flags: feedback?(ehsan)

Updated

2 months ago
Attachment #8888619 - Flags: feedback?(josh)

Updated

2 months ago
Blocks: 1354046

Comment 9

2 months ago
Sorry - had this response written but didn't hit send.  

tl;dr here is the revised copy - Want to keep something to yourself? Use Private Browsing with Tracking Protection. Firefox will block online trackers while you browse and won't remember your history after you've ended your session. 

	


Hi - the initial line of copy was reviewed and approved by legal, but Michael and I met with Elvin this morning and investigated a bit more.  The issue hinges on how you define "save" and "history"  -  

Private browsing does save cookies and does leave clues to your history in a session. So, while it doesn't write to the History folder (if I understand correctly), it does display visited links and allows you to log in to a website and have the log in persist for a session.  It makes more sense in this case to model our messaging after what the user will experience in the product, vs. a strictly technical definition of saving history. That's why we are going with "won't remember your history" instead of erases or doesn't save.

Comment 10

2 months ago
Adding Elvin, in case there are questions.
Flags: needinfo?(mverdi) → needinfo?(ellee)

Updated

2 months ago
Priority: P2 → P1
Target Milestone: Firefox 57 → Firefox 56
Comment hidden (mozreview-request)
(Assignee)

Comment 12

2 months ago
Add Ehsan in review to make sure the string is right.
Comment on attachment 8888619 [details]
Bug 1382510 - update Private Browsing overlay and notification description;

https://reviewboard.mozilla.org/r/159632/#review166498

::: browser/extensions/onboarding/locales/en-US/onboarding.properties:32
(Diff revision 2)
>  onboarding.notification.onboarding-tour-search.message=Access all of your favorite search engines with a click. Search the whole Web or just one website right from the search box.
>  
>  onboarding.tour-private-browsing=Private Browsing
>  onboarding.tour-private-browsing.title2=Browse by yourself.
> -# LOCALIZATION NOTE(onboarding.tour-private-browsing.description2): %S is brandShortName.
> -onboarding.tour-private-browsing.description2=Want to keep something to yourself? Use Private Browsing with Tracking Protection. When you close your session, %S clears search and browsing history.
> +# LOCALIZATION NOTE(onboarding.tour-private-browsing.description3): This string will be used in the private-browsing tour description. %S is brandShortName.
> +onboarding.tour-private-browsing.description3=Want to keep something to yourself? Use Private Browsing with Tracking Protection. %S will block online trackers while you browse and won’t remember your history after you’ve ended your session.

I think this is a lot better, thanks!

Still, this could probably be reworded a bit to make it a bit clearer what really happens in private browsing mode, but since I'm not a native English speaker myself, I'm not 100% sure whether the current copy is clear enough as is or needs further refinement, so please feel free to use the below as a suggestion if you feel it's appropriate.

While Firefox does remember certain aspects of your browsing session in private browsing mode, it doesn't persist this information, so in a sense it's not "really" remembering it.  This wiki page tries to describe the distinction: https://wiki.mozilla.org/Private_Browsing (please see the Local Privacy section).  This distinction is probably way too confusing to distill in the copy here, but I wasn't sure if the usage of "remember after" here would suggest that Firefox saves your private session information during the private session but forgets it when the private session is terminated or if it's clear enough as it is.

I think it would also be a good idea to mention in the LOCALIZATION NOTE before the string that the second part of the sentence should be translated in a way that makes it clear that Firefox won't remember the user's private sesssion while they're browsing, and that it will block the trackers encountered in such sessions.  That will help localizers ensure to capture the essence of the message here in the translated versions of this text.

Thanks again!
Attachment #8888619 - Flags: review?(ehsan) → review+
(Assignee)

Comment 14

2 months ago
Thanks for review. I will add in LOCALIZATION NOTE that makes it clear that Firefox won't remember the user's private sesssion while they're browsing, and that it will block the trackers encountered in such sessions.


:mheubusch would you like to rephrase the word based on Comment 13? or its fine to use the current string?
Flags: needinfo?(mheubusch)
Comment hidden (mozreview-request)
Comment on attachment 8888619 [details]
Bug 1382510 - update Private Browsing overlay and notification description;

https://reviewboard.mozilla.org/r/159632/#review167196

::: browser/extensions/onboarding/locales/en-US/onboarding.properties:33
(Diff revisions 2 - 3)
>  
>  onboarding.tour-private-browsing=Private Browsing
>  onboarding.tour-private-browsing.title2=Browse by yourself.
>  # LOCALIZATION NOTE(onboarding.tour-private-browsing.description3): This string will be used in the private-browsing tour description. %S is brandShortName.
> +# The second part of the sentence should be translated in a way that makes it clear that Firefox won’t remember the user’s private sesssion while they’re browsing, and
> +# it will block the trackers encountered in such sessions

IMO, if that's the meaning that we want to highlight, we need to rephrase the second part in English.

As it stands, this note + the string is sending a very confusing message.
(In reply to :Ehsan Akhgari (needinfo please, extremely long backlog) from comment #13)

> I think it would also be a good idea to mention in the LOCALIZATION NOTE
> before the string that the second part of the sentence should be translated
> in a way that makes it clear that Firefox won't remember the user's private
> sesssion while they're browsing, 

The problem there is that is NOT what it says: "won't remember your history after you've ended your session" was written to purposefully be different than "won't remember the user's private session while they're browsing" because as Michelle said in comment 9 Firefox does leave clues to your history in a session (the back button works, visited links change color, logins persist, etc.). 

(In reply to Francesco Lodolo [:flod] from comment #16)
> As it stands, this note + the string is sending a very confusing message.

I agree. I think the action here is to not add the localization note and leave the string as is.

Comment 18

2 months ago
(In reply to Verdi [:verdi] from comment #17)
> (In reply to :Ehsan Akhgari (needinfo please, extremely long backlog) from
> comment #13)
> 
> > I think it would also be a good idea to mention in the LOCALIZATION NOTE
> > before the string that the second part of the sentence should be translated
> > in a way that makes it clear that Firefox won't remember the user's private
> > sesssion while they're browsing, 
> 
> The problem there is that is NOT what it says: "won't remember your history
> after you've ended your session" was written to purposefully be different
> than "won't remember the user's private session while they're browsing"
> because as Michelle said in comment 9 Firefox does leave clues to your
> history in a session (the back button works, visited links change color,
> logins persist, etc.). 
> 
> (In reply to Francesco Lodolo [:flod] from comment #16)
> > As it stands, this note + the string is sending a very confusing message.
> 
> I agree. I think the action here is to not add the localization note and
> leave the string as is.

Thank you, Michael. I agree as well - let the string stand and do not insert that localization note, which appears to contradict the string.
Flags: needinfo?(mheubusch)
Comment hidden (mozreview-request)
(Assignee)

Comment 20

2 months ago
thanks, I updated the patch to keep the string as comment 9 and remove the extra localization note.
Flags: needinfo?(ellee)
Keywords: checkin-needed

Comment 21

2 months ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/12dd4194902d
update Private Browsing overlay and notification description;r=Ehsan,flod,mossop
Keywords: checkin-needed

Comment 22

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/12dd4194902d
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
I have confirmed this fix.
Status: RESOLVED → VERIFIED
See Also: → bug 1388200
You need to log in before you can comment on or make changes to this bug.