Closed Bug 1382514 Opened 3 years ago Closed 3 years ago

Remove MOZ_PHOTON_PREFERENCES build flag which introduces in bug 1380585

Categories

(Firefox :: Preferences, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: evanxd, Assigned: rickychien)

References

(Blocks 1 open bug)

Details

(Whiteboard: [photon-preference])

Attachments

(1 file)

Remove the useless css for release 56 and the MOZ_PHOTON_PREFERENCES (Bug 1380585) build flag at some point after release 57.
Flags: qe-verify-
Priority: -- → P2
Target Milestone: Future → Firefox 57
Version: 55 Branch → Trunk
Whiteboard: [photon-preference][triage] → [photon-preference]
Per discussion from https://bugzilla.mozilla.org/show_bug.cgi?id=1361957#c57, we're going to ship Photon features without using MOZ_PHOTON_PREFERENCES flag.

It's ok to revert bug 1382514 since it's useless now.
Summary: Remove the useless css and the MOZ_PHOTON_PREFERENCES build flag. → Remove MOZ_PHOTON_PREFERENCES build flag which introduces in bug 1380585
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment on attachment 8894733 [details]
Bug 1382514 - Remove MOZ_PHOTON_PREFERENCES build flag

https://reviewboard.mozilla.org/r/165904/#review171168

::: toolkit/moz.configure:523
(Diff revision 1)
>  def photon_animations(value):
>      if value:
>          return bool(value)
>  
>  set_config('MOZ_PHOTON_ANIMATIONS', photon_animations)
>  set_define('MOZ_PHOTON_ANIMATIONS', photon_animations)

You will likely need to rebase this since bug 1385913 has already landed.
Attachment #8894733 - Flags: review?(jaws) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s ec98005fc02f -d 91b30f63e8d8: rebasing 412140:ec98005fc02f "Bug 1382514 - Remove MOZ_PHOTON_PREFERENCES build flag r=jaws" (tip)
merging toolkit/modules/AppConstants.jsm
merging toolkit/moz.configure
warning: conflicts while merging toolkit/modules/AppConstants.jsm! (edit, then use 'hg resolve --mark')
warning: conflicts while merging toolkit/moz.configure! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9b7f05a8e60b
Remove MOZ_PHOTON_PREFERENCES build flag r=jaws
https://hg.mozilla.org/mozilla-central/rev/9b7f05a8e60b
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.