1382514 - Remove MOZ_PHOTON_PREFERENCES build flag which introduces in bug 1380585

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement, P1)

Description

[Evan Tseng [:evanxd]]

Remove the useless css for release 56 and the MOZ_PHOTON_PREFERENCES (Bug 1380585) build flag at some point after release 57.

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Per discussion from https://bugzilla.mozilla.org/show_bug.cgi?id=1361957#c57, we're going to ship Photon features without using MOZ_PHOTON_PREFERENCES flag.

It's ok to revert bug 1382514 since it's useless now.

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1382514 - Remove MOZ_PHOTON_PREFERENCES build flag

Review commit: https://reviewboard.mozilla.org/r/165904/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/165904/

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8894733 [details]
Bug 1382514 - Remove MOZ_PHOTON_PREFERENCES build flag

https://reviewboard.mozilla.org/r/165904/#review171168

::: toolkit/moz.configure:523
(Diff revision 1)
>  def photon_animations(value):
>      if value:
>          return bool(value)
>  
>  set_config('MOZ_PHOTON_ANIMATIONS', photon_animations)
>  set_define('MOZ_PHOTON_ANIMATIONS', photon_animations)

You will likely need to rebase this since bug 1385913 has already landed.

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8894733 [details]
Bug 1382514 - Remove MOZ_PHOTON_PREFERENCES build flag

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/165904/diff/1-2/

Comment 5

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8894733 [details]
Bug 1382514 - Remove MOZ_PHOTON_PREFERENCES build flag

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/165904/diff/2-3/

Comment 6

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s ec98005fc02f -d 91b30f63e8d8: rebasing 412140:ec98005fc02f "Bug 1382514 - Remove MOZ_PHOTON_PREFERENCES build flag r=jaws" (tip)
merging toolkit/modules/AppConstants.jsm
merging toolkit/moz.configure
warning: conflicts while merging toolkit/modules/AppConstants.jsm! (edit, then use 'hg resolve --mark')
warning: conflicts while merging toolkit/moz.configure! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 7

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8894733 [details]
Bug 1382514 - Remove MOZ_PHOTON_PREFERENCES build flag

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/165904/diff/3-4/

Comment 8

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8894733 [details]
Bug 1382514 - Remove MOZ_PHOTON_PREFERENCES build flag

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/165904/diff/4-5/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b7f05a8e60b
Remove MOZ_PHOTON_PREFERENCES build flag r=jaws

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9b7f05a8e60b