1382689 - "Remove" button displayed while clicking "More" link from Legacy Extensions tab is not working

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Valentina Virlics [:vvalentina], VPN QA]

Attachment: remove.gif

[Affected versions]: 
Nightly 56.0a1 (2017-07-19) (64-bit)

[Affected platforms]:
Windows 7 64-bit

[Steps to reproduce]:
1. Install a legacy add-on i.e. https://addons.mozilla.org/en-us/firefox/addon/integrated-gmail/?src=hp-dl-featured
2. Set extensions.legacy.enabled to "false" and restart the browser
3. Go to about:addons "Legacy Extensions" tab
4. Click on "More"
5. Click on "Remove"

[Expected results]:
Add-on is removed.

[Actual results]:
User is redirected at Legacy Extensions tab, and the add-on is not removed.

[Additional notes]:
- may be related to https://bugzilla.mozilla.org/show_bug.cgi?id=1372645 ;
- attaching video for this issue;

Comment 1

[Andrew Swan [:aswan]]

Attachment: Bug 1382689 Fix "Remove" button on details page for a legacy extension

Also updated addon listeners in extensions.js to use Set instead of
arrays and added a way to listen to AddonListener events on any addon.

Review commit: https://reviewboard.mozilla.org/r/163186/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163186/

Comment 2

[Robert Helmer [:rhelmer]]

Comment on attachment 8892237 [details]
Bug 1382689 Fix "Remove" button on details page for a legacy extension

https://reviewboard.mozilla.org/r/163186/#review170536

Comment 3

[Andrew Swan [:aswan]]

Comment on attachment 8892237 [details]
Bug 1382689 Fix "Remove" button on details page for a legacy extension

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/163186/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/801e02613d0f
Fix "Remove" button on details page for a legacy extension r=rhelmer

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for eslint failure at toolkit/mozapps/extensions/content/extensions.js:609: ["ANY"] is better written in dot notation:

https://hg.mozilla.org/integration/autoland/rev/79cd0acfa99364d2bedd862959523d5869f8b8e9

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=801e02613d0f0a694e641eeecd947920728d4757&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=121282111&repo=autoland
> 
TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/toolkit/mozapps/extensions/content/extensions.js:609:42 | ["ANY"] is better written in dot notation. (dot-notation)

Comment 6

[Andrew Swan [:aswan]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a15bf52ecde10da99ceee3d96e2fcf6925fa7e5d
Bug 1382689 Fix "Remove" button on details page for a legacy extension

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a15bf52ecde1

Comment 8

[Valentina Virlics [:vvalentina], VPN QA]

Attachment: remove.gif

Verified as fixed on Firefox 57.0a1 (2017-08-07) (64-bit) under Windows 7 64-bit.
The "Remove" button from Legacy Extensions tab -> More link, works as expected.
Attaching postfix video.

Comment 9

[Gerry Chang [:gchang]]

Too late for 56. Mass won't fix for 56.