Closed Bug 1382888 Opened 5 years ago Closed 5 years ago
Authn objects should use [Same Object]
59 bytes, text/x-review-board-request
Most of the WebIDL objects for the current editor's draft of Web Authentication are annotated as [SameObject], which won't affect interop based on WD-05 . We should go ahead and annotate ours that way.  https://w3c.github.io/webauthn/#idl-index
Comment on attachment 8888866 [details] Bug 1382888 - WebAuthn objects should use [SameObject] https://reviewboard.mozilla.org/r/159880/#review166460
Attachment #8888866 - Flags: review?(kyle) → review+
Thanks for the review! Try runs previously looked good, so marking checkin-needed.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/811510fdb51a WebAuthn objects should use [SameObject] r=qdot
Does the implementation actually return the same object all the time? For example, PublicKeyCredential.rawId seems to end up in CryptoBuffer::ToUint8Array, which returns a new object every time it's called. Maybe I'm missing something, where do we ensure that the same object is returned?
I was assuming [SameObject] instructed the object to be cached at the JS-layer, but digging into it, I see it does not. I'm opening a follow-on that I'll tackle ASAP to make sure these are cached objects. Thanks, :peterv.
You need to log in before you can comment on or make changes to this bug.