Closed Bug 1382888 Opened 5 years ago Closed 5 years ago

WebAuthn objects should use [SameObject]

Categories

(Core :: DOM: Device Interfaces, enhancement, P2)

55 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox56 --- fixed

People

(Reporter: jcj, Assigned: jcj)

References

(Blocks 1 open bug)

Details

(Whiteboard: [webauthn] [webauthn-interop])

Attachments

(1 file)

Most of the WebIDL objects for the current editor's draft of Web Authentication are annotated as [SameObject], which won't affect interop based on WD-05 [1]. We should go ahead and annotate ours that way.

[1] https://w3c.github.io/webauthn/#idl-index
Status: NEW → ASSIGNED
Comment on attachment 8888866 [details]
Bug 1382888 - WebAuthn objects should use [SameObject]

https://reviewboard.mozilla.org/r/159880/#review166460
Attachment #8888866 - Flags: review?(kyle) → review+
Thanks for the review! Try runs previously looked good, so marking checkin-needed.
Keywords: checkin-needed
Pushed by kmachulis@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/811510fdb51a
WebAuthn objects should use [SameObject] r=qdot
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/811510fdb51a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Does the implementation actually return the same object all the time? For example, PublicKeyCredential.rawId seems to end up in CryptoBuffer::ToUint8Array, which returns a new object every time it's called. Maybe I'm missing something, where do we ensure that the same object is returned?
Flags: needinfo?(jjones)
I was assuming [SameObject] instructed the object to be cached at the JS-layer, but digging into it, I see it does not. I'm opening a follow-on that I'll tackle ASAP to make sure these are cached objects.

Thanks, :peterv.
Flags: needinfo?(jjones)
You need to log in before you can comment on or make changes to this bug.