Rename customization-uidensity-menu-button* classes and ids since these are menuitems

RESOLVED FIXED in Firefox 56

Status

()

Firefox
Toolbars and Customization
P1
normal
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 56
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [photon-visual])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

9 months ago
From bug 1379122 comment 4:

> The popup is a menu for all intents and purposes.
> That some of these popups use toolbarbuttons is an implementation detail.
(Assignee)

Updated

9 months ago
Summary: Rename customization-uidensity-menu-button* → Rename customization-uidensity-menu-button* classes and ids since these are menuitems
Comment hidden (mozreview-request)
(Assignee)

Updated

9 months ago
Flags: qe-verify-

Updated

9 months ago
Iteration: --- → 56.3 - Jul 24
Whiteboard: [reserve-photon-visual] → [photon-visual]

Comment 2

9 months ago
mozreview-review
Comment on attachment 8888755 [details]
Bug 1383031 - Rename customization-uidensity-menu-button* classes and ids since these are menuitems.

https://reviewboard.mozilla.org/r/159796/#review165264

Works for me. :)
Attachment #8888755 - Flags: review?(jhofmann) → review+

Comment 3

9 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/792565abca9e
Rename customization-uidensity-menu-button* classes and ids since these are menuitems. r=johannh
https://hg.mozilla.org/mozilla-central/rev/792565abca9e
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.