Closed
Bug 1383031
Opened 7 years ago
Closed 7 years ago
Rename customization-uidensity-menu-button* classes and ids since these are menuitems
Categories
(Firefox :: Toolbars and Customization, enhancement, P1)
Firefox
Toolbars and Customization
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
(Whiteboard: [photon-visual])
Attachments
(1 file)
|
Bug 1383031 - Rename customization-uidensity-menu-button* classes and ids since these are menuitems.
59 bytes,
text/x-review-board-request
|
johannh
:
review+
|
Details |
From bug 1379122 comment 4: > The popup is a menu for all intents and purposes. > That some of these popups use toolbarbuttons is an implementation detail.
|
Assignee | |
Updated•7 years ago
|
Summary: Rename customization-uidensity-menu-button* → Rename customization-uidensity-menu-button* classes and ids since these are menuitems
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Flags: qe-verify-
|
||
Updated•7 years ago
|
Iteration: --- → 56.3 - Jul 24
Whiteboard: [reserve-photon-visual] → [photon-visual]
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8888755 [details] Bug 1383031 - Rename customization-uidensity-menu-button* classes and ids since these are menuitems. https://reviewboard.mozilla.org/r/159796/#review165264 Works for me. :)
Attachment #8888755 -
Flags: review?(jhofmann) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/792565abca9e Rename customization-uidensity-menu-button* classes and ids since these are menuitems. r=johannh
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/792565abca9e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in
before you can comment on or make changes to this bug.
Description
•