Closed Bug 1383031 Opened 8 years ago Closed 8 years ago

Rename customization-uidensity-menu-button* classes and ids since these are menuitems

Categories

(Firefox :: Toolbars and Customization, enhancement, P1)

Product:
Firefox
Component:
Toolbars and Customization
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 56
Iteration:
56.3 - Jul 24
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

(Whiteboard: [photon-visual])

Attachments

(1 file)

Bug 1383031 - Rename customization-uidensity-menu-button* classes and ids since these are menuitems.
59 bytes, text/x-review-board-request
johannh
: review+
Details
From bug 1379122 comment 4: > The popup is a menu for all intents and purposes. > That some of these popups use toolbarbuttons is an implementation detail.
Summary: Rename customization-uidensity-menu-button* → Rename customization-uidensity-menu-button* classes and ids since these are menuitems
Flags: qe-verify-
Iteration: --- → 56.3 - Jul 24
Whiteboard: [reserve-photon-visual] → [photon-visual]
Comment on attachment 8888755 [details] Bug 1383031 - Rename customization-uidensity-menu-button* classes and ids since these are menuitems. https://reviewboard.mozilla.org/r/159796/#review165264 Works for me. :)
Attachment #8888755 - Flags: review?(jhofmann) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/792565abca9e Rename customization-uidensity-menu-button* classes and ids since these are menuitems. r=johannh
https://hg.mozilla.org/mozilla-central/rev/792565abca9e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: