[RTL] Wrong position for non-pinned tab notification on RTL builds

VERIFIED FIXED

Status

()

Firefox
Theme
P1
normal
VERIFIED FIXED
5 months ago
3 months ago

People

(Reporter: tomer, Assigned: dao)

Tracking

(Blocks: 1 bug, {rtl})

56 Branch
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox-esr52 wontfix, firefox54 wontfix, firefox55 wontfix, firefox56 wontfix, firefox57 verified)

Details

(Whiteboard: [reserve-photon-visual][p4] fixed by bug 1379052)

Attachments

(3 attachments)

(Reporter)

Description

5 months ago
Created attachment 8888957 [details]
Testcase

The tab notification has glowing effect when a tab has new notification. For LTR builds, it appears just below the favicon. On RTL builds it appears under the tab title or the tab close button.

Steps to reproduce:
a. Open the attached testcase on RTL build.
b. Switch to another tab to trigger the notification.
(Reporter)

Comment 1

5 months ago
Created attachment 8888958 [details]
Screenshot
(Reporter)

Updated

5 months ago
status-firefox54: --- → affected
status-firefox55: --- → affected
status-firefox56: --- → affected
status-firefox-esr52: --- → affected
(Reporter)

Comment 2

5 months ago
Created attachment 8888959 [details]
Screenshot (nightly)

A change that introduced by bug 1375893 makes it even more visible. I afraid that the huge notification background not created by purpose.

Comment 3

5 months ago
Though not strictly a regression from bug 1375893, I guess we should consider fixing this given how much more noticeably broken the new state looks.
Keywords: rtl
See Also: → bug 1375893
Whiteboard: [photon-visual][triage]
(Reporter)

Comment 4

5 months ago
(In reply to :Gijs from comment #3)
> Though not strictly a regression from bug 1375893, I guess we should
> consider fixing this given how much more noticeably broken the new state
> looks.

I am unable to find on the mockups [1] any mention for an attention indicator for unpinned tabs. Does unpinned tabs should have the same attention indicator although the tab length is longer than a pinned tab?


Real world scenario: 
Any tab sent to a desktop browser will have a huge attention indicator. The indicator is hidden behind the favicon on LTR and appears better better than on RTL, although I am not sure if it the correct behavior according to the specs for both LTR and RTL. 

[1]: https://mozilla.invisionapp.com/share/ENBBK0F9U#/screens/229786513

Comment 5

5 months ago
(In reply to Tomer Cohen :tomer from comment #4)
> (In reply to :Gijs from comment #3)
> > Though not strictly a regression from bug 1375893, I guess we should
> > consider fixing this given how much more noticeably broken the new state
> > looks.
> 
> I am unable to find on the mockups [1] any mention for an attention
> indicator for unpinned tabs. Does unpinned tabs should have the same
> attention indicator although the tab length is longer than a pinned tab?

They do want an attention indicator, but whether the current state is correct on LTR, I don't know. Dão, Dolske or other members of the visual team might be able to clarify this either here or on the other bug, where I see you asked a similar question.
(Assignee)

Comment 6

5 months ago
(In reply to :Gijs from comment #3)
> given how much more noticeably broken the new state looks.

That's bug 1379052.
Whiteboard: [photon-visual][triage] → [reserve-photon-visual][p4]

Updated

5 months ago
Flags: qe-verify?
Priority: -- → P3
(Assignee)

Updated

5 months ago
Flags: qe-verify? → qe-verify+

Updated

5 months ago
QA Contact: brindusa.tot
(Assignee)

Comment 7

4 months ago
Bug 1379052 will fix this.
Blocks: 1355767
Depends on: 1379052

Updated

4 months ago
Whiteboard: [reserve-photon-visual][p4] → [reserve-photon-visual][p4][high-priority]
(Assignee)

Updated

4 months ago
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Whiteboard: [reserve-photon-visual][p4][high-priority] → [reserve-photon-visual][p4] fixed by bug 1379052

Updated

4 months ago
Iteration: --- → 57.1 - Aug 15
Priority: P3 → P1

Updated

3 months ago
QA Contact: brindusa.tot → ovidiu.boca
Reproduced the issue using Beta 56.0b12 on Windows 10 x64, Ubuntu 16.04 x64

Verified fixed using the latest Nightly (2017-09-19) on Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.12
status-firefox57: --- → verified

Updated

3 months ago
Status: RESOLVED → VERIFIED
Assignee: nobody → dao+bmo
status-firefox54: affected → wontfix
status-firefox55: affected → wontfix
status-firefox56: affected → wontfix
status-firefox-esr52: affected → wontfix
You need to log in before you can comment on or make changes to this bug.