1383312 - [RTL] Wrong position for non-pinned tab notification on RTL builds

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Tomer Cohen :tomer]

Attachment: Testcase

The tab notification has glowing effect when a tab has new notification. For LTR builds, it appears just below the favicon. On RTL builds it appears under the tab title or the tab close button.

Steps to reproduce:
a. Open the attached testcase on RTL build.
b. Switch to another tab to trigger the notification.

Comment 1

[Tomer Cohen :tomer]

Attachment: Screenshot

Comment 2

[Tomer Cohen :tomer]

Attachment: Screenshot (nightly)

A change that introduced by bug 1375893 makes it even more visible. I afraid that the huge notification background not created by purpose.

Comment 3

[:Gijs (he/him)]

Though not strictly a regression from bug 1375893, I guess we should consider fixing this given how much more noticeably broken the new state looks.

Comment 4

[Tomer Cohen :tomer]

(In reply to :Gijs from comment #3)
> Though not strictly a regression from bug 1375893, I guess we should
> consider fixing this given how much more noticeably broken the new state
> looks.

I am unable to find on the mockups [1] any mention for an attention indicator for unpinned tabs. Does unpinned tabs should have the same attention indicator although the tab length is longer than a pinned tab?


Real world scenario: 
Any tab sent to a desktop browser will have a huge attention indicator. The indicator is hidden behind the favicon on LTR and appears better better than on RTL, although I am not sure if it the correct behavior according to the specs for both LTR and RTL. 

[1]: https://mozilla.invisionapp.com/share/ENBBK0F9U#/screens/229786513

Comment 5

[:Gijs (he/him)]

(In reply to Tomer Cohen :tomer from comment #4)
> (In reply to :Gijs from comment #3)
> > Though not strictly a regression from bug 1375893, I guess we should
> > consider fixing this given how much more noticeably broken the new state
> > looks.
> 
> I am unable to find on the mockups [1] any mention for an attention
> indicator for unpinned tabs. Does unpinned tabs should have the same
> attention indicator although the tab length is longer than a pinned tab?

They do want an attention indicator, but whether the current state is correct on LTR, I don't know. Dão, Dolske or other members of the visual team might be able to clarify this either here or on the other bug, where I see you asked a similar question.

Comment 6

[Dão Gottwald [:dao]]

(In reply to :Gijs from comment #3)
> given how much more noticeably broken the new state looks.

That's bug 1379052.

Comment 7

[Dão Gottwald [:dao]]

Bug 1379052 will fix this.

Comment 8

[roxleitan]

Reproduced the issue using Beta 56.0b12 on Windows 10 x64, Ubuntu 16.04 x64

Verified fixed using the latest Nightly (2017-09-19) on Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.12