Closed Bug 1383312 Opened 4 years ago Closed 4 years ago

[RTL] Wrong position for non-pinned tab notification on RTL builds

Categories

(Firefox :: Theme, defect, P1)

56 Branch
defect

Tracking

()

VERIFIED FIXED
Iteration:
57.1 - Aug 15
Tracking Status
firefox-esr52 --- wontfix
firefox54 --- wontfix
firefox55 --- wontfix
firefox56 --- wontfix
firefox57 --- verified

People

(Reporter: tomer, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Keywords: rtl, Whiteboard: [reserve-photon-visual][p4] fixed by bug 1379052)

Attachments

(3 files)

Attached file Testcase
The tab notification has glowing effect when a tab has new notification. For LTR builds, it appears just below the favicon. On RTL builds it appears under the tab title or the tab close button.

Steps to reproduce:
a. Open the attached testcase on RTL build.
b. Switch to another tab to trigger the notification.
Attached image Screenshot
Attached image Screenshot (nightly)
A change that introduced by bug 1375893 makes it even more visible. I afraid that the huge notification background not created by purpose.
Though not strictly a regression from bug 1375893, I guess we should consider fixing this given how much more noticeably broken the new state looks.
Keywords: rtl
See Also: → 1375893
Whiteboard: [photon-visual][triage]
(In reply to :Gijs from comment #3)
> Though not strictly a regression from bug 1375893, I guess we should
> consider fixing this given how much more noticeably broken the new state
> looks.

I am unable to find on the mockups [1] any mention for an attention indicator for unpinned tabs. Does unpinned tabs should have the same attention indicator although the tab length is longer than a pinned tab?


Real world scenario: 
Any tab sent to a desktop browser will have a huge attention indicator. The indicator is hidden behind the favicon on LTR and appears better better than on RTL, although I am not sure if it the correct behavior according to the specs for both LTR and RTL. 

[1]: https://mozilla.invisionapp.com/share/ENBBK0F9U#/screens/229786513
(In reply to Tomer Cohen :tomer from comment #4)
> (In reply to :Gijs from comment #3)
> > Though not strictly a regression from bug 1375893, I guess we should
> > consider fixing this given how much more noticeably broken the new state
> > looks.
> 
> I am unable to find on the mockups [1] any mention for an attention
> indicator for unpinned tabs. Does unpinned tabs should have the same
> attention indicator although the tab length is longer than a pinned tab?

They do want an attention indicator, but whether the current state is correct on LTR, I don't know. Dão, Dolske or other members of the visual team might be able to clarify this either here or on the other bug, where I see you asked a similar question.
(In reply to :Gijs from comment #3)
> given how much more noticeably broken the new state looks.

That's bug 1379052.
Whiteboard: [photon-visual][triage] → [reserve-photon-visual][p4]
Flags: qe-verify?
Priority: -- → P3
Flags: qe-verify? → qe-verify+
QA Contact: brindusa.tot
Bug 1379052 will fix this.
Blocks: photon-tabs
Depends on: 1379052
Whiteboard: [reserve-photon-visual][p4] → [reserve-photon-visual][p4][high-priority]
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Whiteboard: [reserve-photon-visual][p4][high-priority] → [reserve-photon-visual][p4] fixed by bug 1379052
Iteration: --- → 57.1 - Aug 15
Priority: P3 → P1
QA Contact: brindusa.tot → ovidiu.boca
Reproduced the issue using Beta 56.0b12 on Windows 10 x64, Ubuntu 16.04 x64

Verified fixed using the latest Nightly (2017-09-19) on Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.12
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.