Closed Bug 1383456 Opened 6 years ago Closed 6 years ago

Default Search and One-Click shows up twice in preference search result

Categories

(Firefox :: Settings UI, defect, P1)

Product:
Firefox
Component:
Settings UI
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 56
Tracking Flags:
Tracking Status
firefox56 --- verified

People

(Reporter: mkohler, Assigned: rickychien)

References

(Blocks 1 open bug)

Details

(Keywords: nightly-community, Whiteboard: [photon-preference])

Attachments

(2 files)

Screen Shot 2017-07-22 at 22.09.43.png
149.32 KB, image/png
Details
Bug 1383456 - Remove redundant Default Search and One-Click preferences search result
59 bytes, text/x-review-board-request
jaws
: review+
Details 
STR:
* Open about:preferences
* Search for "search"

Expected:
* Have a section "Default search engine" and "One click search-engine" with content


Actual:
* There are two empty sections "Default search engine" and "One click search-engine"
* The expected content is shown further below
See Also: → 1383460
Whiteboard: [photon-preference][triage]
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Has STR: --- → yes
Flags: qe-verify+
Priority: -- → P1
QA Contact: hani.yacoub
Target Milestone: --- → Firefox 56
Jared, 

The issue might be caused from reorg v2 (bug 1365133) accidentally.

Can you review this small patch for me? Thanks
Comment on attachment 8889782 [details]
Bug 1383456 - Remove redundant Default Search and One-Click preferences search result

https://reviewboard.mozilla.org/r/160874/#review166490

Can you please look through the other preference files to see what else might be duplicated?
Attachment #8889782 - Flags: review?(jaws) → review+
Yep, I've looked through all preferences panels and checked that there is no other duplicated issues. Thanks
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8a5c4e5a0a6b
Remove redundant Default Search and One-Click preferences search result r=jaws
Whiteboard: [photon-preference][triage] → [photon-preference]
https://hg.mozilla.org/mozilla-central/rev/8a5c4e5a0a6b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
I have reproduced this Bug on Nightly 56.0a1 (2017-07-22) on Windows 10, 64 bit!

The bug's fix is now verified on latest  Nightly 56.0a1

Build ID    :	20170729100254
User Agent  : 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
QA Whiteboard: [bugday-20170726]
Build ID: 20170730100307
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0

Verified as fixed on Firefox Nightly 56.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
status-firefox56: fixed → verified
You need to log in before you can comment on or make changes to this bug.