Closed Bug 1383535 Opened 3 years ago Closed 3 years ago

"Sign into sync" option in new photon hamburger panel has end-side margin even when 'sync now' is not visible (should be flush with panel end)

Categories

(Firefox :: Theme, defect, P1)

55 Branch
x86_64
Windows 7
defect

Tracking

()

VERIFIED FIXED
Firefox 56
Iteration:
56.4 - Aug 1
Tracking Status
firefox-esr52 --- unaffected
firefox54 --- unaffected
firefox55 --- disabled
firefox56 --- verified

People

(Reporter: Virtual, Assigned: Gijs)

References

Details

(Keywords: nightly-community, Whiteboard: [photon-structure])

Attachments

(3 files)

I meant that hover effect isn't complete on right side of Sync/Firefox Account option in Hamburger menu.
Summary: Use new Photon hover effect also on Sync/Firefox Account option in Hamburger menu → New Photon hover effect on Sync/Firefox Account option in Hamburger menu isn't complete
Has Regression Range: --- → irrelevant
Has STR: --- → irrelevant
Whiteboard: [photon] [triage] → [photon-structure] [triage]
Summary: New Photon hover effect on Sync/Firefox Account option in Hamburger menu isn't complete → "Sign into sync" option in new photon hamburger panel has end-side margin even when 'sync now' is not visible (should be flush with panel end)
Flags: qe-verify+
Priority: -- → P2
QA Contact: gwimberly
Whiteboard: [photon-structure] [triage] → [photon-structure]
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 56.4 - Aug 1
Priority: P2 → P1
Version: 55 Branch → Trunk
Comment on attachment 8890430 [details]
Bug 1383535 - fix margin issue with sync item when not signed in,

https://reviewboard.mozilla.org/r/161548/#review166846
Attachment #8890430 - Flags: review?(dtownsend) → review+
The rule this is overriding is here: https://dxr.mozilla.org/mozilla-central/rev/7d2e89fb92331d7e4296391213c1e63db628e046/browser/themes/shared/customizableui/panelUI.inc.css#1321

and was added in bug 1354108, which made it to m-c the same day as the sync code, but was obviously written in a separate patch which is why I thought this worked when I wrote it. :-)
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/93d48f1320f7
fix margin issue with sync item when not signed in, r=mossop
https://hg.mozilla.org/mozilla-central/rev/93d48f1320f7
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
I'm confirming that it's fixed, starting in Mozilla Firefox 56.0a1 (2017-07-27).
Thanks. I'm marking this bug as VERIFIED.
Status: RESOLVED → VERIFIED
QA Contact: gwimberly → Virtual
Version: Trunk → 55 Branch
Flags: qe-verify+
Blocks: 1387512
Blocks: 1560336
You need to log in before you can comment on or make changes to this bug.