"Sign into sync" option in new photon hamburger panel has end-side margin even when 'sync now' is not visible (should be flush with panel end)

VERIFIED FIXED in Firefox 56

Status

()

Firefox
Theme
P1
normal
VERIFIED FIXED
a month ago
20 days ago

People

(Reporter: Virtual, Assigned: Gijs)

Tracking

(Blocks: 1 bug, {nightly-community})

55 Branch
Firefox 56
x86_64
Windows 7
nightly-community
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox54 unaffected, firefox55 disabled, firefox56 verified)

Details

(Whiteboard: [photon-structure])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

Created attachment 8889166 [details]
bugged hover effect.png
Created attachment 8889167 [details]
not bugged hover effect.png
I meant that hover effect isn't complete on right side of Sync/Firefox Account option in Hamburger menu.
Summary: Use new Photon hover effect also on Sync/Firefox Account option in Hamburger menu → New Photon hover effect on Sync/Firefox Account option in Hamburger menu isn't complete
Has Regression Range: --- → irrelevant
Has STR: --- → irrelevant

Updated

a month ago
Whiteboard: [photon] [triage] → [photon-structure] [triage]
(Assignee)

Updated

a month ago
Summary: New Photon hover effect on Sync/Firefox Account option in Hamburger menu isn't complete → "Sign into sync" option in new photon hamburger panel has end-side margin even when 'sync now' is not visible (should be flush with panel end)

Updated

a month ago
Flags: qe-verify+
Priority: -- → P2
QA Contact: gwimberly
Whiteboard: [photon-structure] [triage] → [photon-structure]
Comment hidden (mozreview-request)
(Assignee)

Updated

29 days ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 56.4 - Aug 1
status-firefox55: affected → disabled
Priority: P2 → P1
Version: 55 Branch → Trunk

Comment 4

29 days ago
mozreview-review
Comment on attachment 8890430 [details]
Bug 1383535 - fix margin issue with sync item when not signed in,

https://reviewboard.mozilla.org/r/161548/#review166846
Attachment #8890430 - Flags: review?(dtownsend) → review+
(Assignee)

Comment 5

29 days ago
The rule this is overriding is here: https://dxr.mozilla.org/mozilla-central/rev/7d2e89fb92331d7e4296391213c1e63db628e046/browser/themes/shared/customizableui/panelUI.inc.css#1321

and was added in bug 1354108, which made it to m-c the same day as the sync code, but was obviously written in a separate patch which is why I thought this worked when I wrote it. :-)

Comment 6

29 days ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/93d48f1320f7
fix margin issue with sync item when not signed in, r=mossop

Comment 7

28 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/93d48f1320f7
Status: ASSIGNED → RESOLVED
Last Resolved: 28 days ago
status-firefox56: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
I'm confirming that it's fixed, starting in Mozilla Firefox 56.0a1 (2017-07-27).
Thanks. I'm marking this bug as VERIFIED.
Status: RESOLVED → VERIFIED
status-firefox56: fixed → verified
QA Contact: gwimberly → Virtual
Version: Trunk → 55 Branch

Updated

28 days ago
Flags: qe-verify+
Blocks: 1387512
You need to log in before you can comment on or make changes to this bug.