stylo: Kill a few uses of GetParentAllowServo.

RESOLVED FIXED in Firefox 56

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: emilio, Assigned: emilio)

Tracking

unspecified
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(2 attachments)

These are the easy ones.
Comment on attachment 8889317 [details]
Bug 1383634: Remove usage of GetParentAllowServo in nsRuleNode.

https://reviewboard.mozilla.org/r/160386/#review165632
Attachment #8889317 - Flags: review?(xidorn+moz) → review+
Attachment #8889318 - Flags: review?(xidorn+moz) → review?(karlt)
Not familiar with MathML... cannot tell why mStyleContext->GetParent() is equal to aForFrame->StyleContext(), so redirect to :karlt who is a peer of MathML.
Blocks: 1381844
Xidorn does https://treeherder.mozilla.org/#/jobs?repo=try&revision=bec2e1885e317201e0495e479917c8a93c84896d convince you? (see the last commit).
Flags: needinfo?(xidorn+moz)
Oh, sorry, misread as "I cannot tell if mStyleContext->GetParent() is...", instead of _why_.

If why, it's because all the callers of ResolveMathMLCharStyle pass mStyleContext to the function:

http://searchfox.org/mozilla-central/search?q=symbol:_ZN13nsMathMLFrame22ResolveMathMLCharStyleEP13nsPresContextP10nsIContentP14nsStyleContextP12nsMathMLChar&redirect=false
Hmmmm, ok, so other callsites of nsMathMLChar::SetStyleContext are all from SetAdditionalStyleContext, which is supposed to just refresh the existing style context.
Flags: needinfo?(xidorn+moz)
Attachment #8889318 - Flags: review?(karlt) → review?(xidorn+moz)
Comment on attachment 8889318 [details]
Bug 1383634: Remove usage of GetParentAllowServo in mathml code.

https://reviewboard.mozilla.org/r/160388/#review165976
Attachment #8889318 - Flags: review?(xidorn+moz) → review+
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0616e8c5f57e
Remove usage of GetParentAllowServo in nsRuleNode. r=xidorn
https://hg.mozilla.org/integration/autoland/rev/6765c694080c
Remove usage of GetParentAllowServo in mathml code. r=xidorn
https://hg.mozilla.org/mozilla-central/rev/0616e8c5f57e
https://hg.mozilla.org/mozilla-central/rev/6765c694080c
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.