1383634 - stylo: Kill a few uses of GetParentAllowServo.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

These are the easy ones.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1383634: Remove usage of GetParentAllowServo in nsRuleNode.

This is Gecko-only code, so no need to allow Servo.

Review commit: https://reviewboard.mozilla.org/r/160386/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/160386/

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1383634: Remove usage of GetParentAllowServo in mathml code.

Review commit: https://reviewboard.mozilla.org/r/160388/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/160388/

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8889317 [details]
Bug 1383634: Remove usage of GetParentAllowServo in nsRuleNode.

https://reviewboard.mozilla.org/r/160386/#review165632

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Not familiar with MathML... cannot tell why mStyleContext->GetParent() is equal to aForFrame->StyleContext(), so redirect to :karlt who is a peer of MathML.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Xidorn does https://treeherder.mozilla.org/#/jobs?repo=try&revision=bec2e1885e317201e0495e479917c8a93c84896d convince you? (see the last commit).

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Oh, sorry, misread as "I cannot tell if mStyleContext->GetParent() is...", instead of _why_.

If why, it's because all the callers of ResolveMathMLCharStyle pass mStyleContext to the function:

http://searchfox.org/mozilla-central/search?q=symbol:_ZN13nsMathMLFrame22ResolveMathMLCharStyleEP13nsPresContextP10nsIContentP14nsStyleContextP12nsMathMLChar&redirect=false

Comment 7

[Xidorn Quan [:xidorn] UTC+10]

Hmmmm, ok, so other callsites of nsMathMLChar::SetStyleContext are all from SetAdditionalStyleContext, which is supposed to just refresh the existing style context.

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8889318 [details]
Bug 1383634: Remove usage of GetParentAllowServo in mathml code.

https://reviewboard.mozilla.org/r/160388/#review165976

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0616e8c5f57e
Remove usage of GetParentAllowServo in nsRuleNode. r=xidorn
https://hg.mozilla.org/integration/autoland/rev/6765c694080c
Remove usage of GetParentAllowServo in mathml code. r=xidorn

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0616e8c5f57e
https://hg.mozilla.org/mozilla-central/rev/6765c694080c