Closed Bug 1383659 Opened 2 years ago Closed 2 years ago

nsCaret::ResetBlinking or LookAndFeel::GetInt(LookAndFeel::eIntID_CaretBlinkTime) should cache caret blink rate

Categories

(Core :: Widget: Win32, enhancement)

Unspecified
Windows
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

When profiling input.value setter or speedmeter, NtUserGetCaretBlinkTime is always showed on profile stack.

NtUserGetCaretBlinkTime seems to be slow, so we should cache caret blink time.  its cache should updated by WM_SETTINGCHANGE on parent process.
s/its cache should updated/The cache should be updated/
Comment on attachment 8890791 [details]
Bug 1383659 - LookAndFeel::GetInt(LookAndFeel::eIntID_CaretBlinkTime) should cache caret blink rate.

https://reviewboard.mozilla.org/r/161992/#review167300
Attachment #8890791 - Flags: review?(jmathies) → review+
Blocks: 1382326
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/4faf41ca4755
LookAndFeel::GetInt(LookAndFeel::eIntID_CaretBlinkTime) should cache caret blink rate. r=jimm
https://hg.mozilla.org/mozilla-central/rev/4faf41ca4755
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Assignee: nobody → m_kato
You need to log in before you can comment on or make changes to this bug.