1383988 - stylo: Image resizer in contenteditable again doesn't show up

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Cameron McCormack (:heycam)]

+++ This bug was initially created as a clone of Bug #1374999 +++

Something regressed bug 1374999's fix for contenteditable handles.

Comment 1

[Cameron McCormack (:heycam)]

Looks like it was regressed by bug 1374175.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Oh-oh, that means the image resizer needs explicit reconstruct frame damage?

Comment 3

[Cameron McCormack (:heycam)]

Yes, indeed.  At the end of HTMLEditor::CreateAnonymousElement, we call nsIPresShell::PostRecreateFramesFor, but at this point, the element is unstyled, so posting the ReconstructFrame is ignored.  I think we just need to ensure the new element for the handle is styled before that call.

Comment 4

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6765e313ace61baa50aa580143022a706b7ab837

Comment 5

[Cameron McCormack (:heycam)]

Attachment: Bug 1383988 - stylo: Ensure editor handle elements are styled before attempting to construct frames for them.

Review commit: https://reviewboard.mozilla.org/r/160852/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/160852/

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8889769 [details]
Bug 1383988 - stylo: Ensure editor handle elements are styled before attempting to construct frames for them.

https://reviewboard.mozilla.org/r/160852/#review166108

Thanks for fixing!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/946864b7ee18
stylo: Ensure editor handle elements are styled before attempting to construct frames for them. r=hiro

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/946864b7ee18