stylo: Image resizer in contenteditable again doesn't show up

RESOLVED FIXED in Firefox 56

Status

()

P2
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: heycam, Assigned: heycam)

Tracking

(Blocks: 1 bug)

Trunk
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
+++ This bug was initially created as a clone of Bug #1374999 +++

Something regressed bug 1374999's fix for contenteditable handles.
(Assignee)

Comment 1

a year ago
Looks like it was regressed by bug 1374175.
Blocks: 1374175
Oh-oh, that means the image resizer needs explicit reconstruct frame damage?
(Assignee)

Comment 3

a year ago
Yes, indeed.  At the end of HTMLEditor::CreateAnonymousElement, we call nsIPresShell::PostRecreateFramesFor, but at this point, the element is unstyled, so posting the ReconstructFrame is ignored.  I think we just need to ensure the new element for the handle is styled before that call.
(Assignee)

Updated

a year ago
Priority: -- → P2
Comment hidden (mozreview-request)

Comment 6

a year ago
mozreview-review
Comment on attachment 8889769 [details]
Bug 1383988 - stylo: Ensure editor handle elements are styled before attempting to construct frames for them.

https://reviewboard.mozilla.org/r/160852/#review166108

Thanks for fixing!
Attachment #8889769 - Flags: review?(hikezoe) → review+

Comment 7

a year ago
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/946864b7ee18
stylo: Ensure editor handle elements are styled before attempting to construct frames for them. r=hiro

Comment 8

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/946864b7ee18
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Depends on: 1384526
You need to log in before you can comment on or make changes to this bug.