1384052 - Activity Stream tile labels are too small

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Dão Gottwald [:dao]]

[Tracking Requested - why for this release]:

The tile labels significantly undercut OS default font sizes. This is problematic especially for visually impaired users.

I have zoomed this page to 133% to see stuff comfortably even though I see my screen unimpaired (I'm only slightly shortsighted).

Comment 1

[Ed Lee :Mardak]

Duping to bug 1377317 for now given that design's feedback is the same in bug 1377317 comment 11.

Comment 2

[Dão Gottwald [:dao]]

Bug 1377317 comment 11 says nothing at all about the labels, which I guess means they're supposed to stay as-is. That may be acceptable for top sites we may have high-res icons for, although that's questionable; the labels still exist as a hint besides the icons, and that hint needs to be accessible unless it's considered redundant, in which case we should probably remove the labels rather than making them illegibly small.

And then there's the extremely long tail of sites that we won't even have high-res icons for.

Comment 3

[Ed Lee :Mardak]

Separately tracking label size

Comment 4

[Aaron Benson]

I don't think they're illegibly small .. I believe they're the same size as the font used for the tab labels (11px) on macOS, which isn't an uncommon font size. That being said, we can certainly look into increasing the size as we iterate on the design.

Comment 5

[Ed Lee :Mardak]

Attachment: tab title and site label

(In reply to Aaron Benson from comment #4)
> I believe they're the same size as the font used for the tab labels (11px) on macOS
Oh indeed they are. Here's a screenshot.

Comment 6

[Dão Gottwald [:dao]]

Attachment: tab label and AS label on Linux

(In reply to Ed Lee :Mardak from comment #5)
> Created attachment 8891832 [details]
> tab title and site label
> 
> (In reply to Aaron Benson from comment #4)
> > I believe they're the same size as the font used for the tab labels (11px) on macOS
> Oh indeed they are. Here's a screenshot.

Not at all on Linux. AFAIK it's significantly smaller than the default font size on Windows too.

Comment 7

[Ed Lee :Mardak]

On Linux, looks like the computed size of tab label is 14.6667px from intl.css top level window font-size: 3mm.
https://searchfox.org/mozilla-central/source/toolkit/locales/en-US/chrome/global/intl.css

Although using 3mm in activity stream content page results in a computed 11.3333px because of the different font.

Looks like it's because tabs use `font: message-box`

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked for 57 for now as we still have a few weeks before we enter Beta. As such I'd not consider this a 57 blocker and might drop tracking late Beta if we don't have a fix ready for uplift by then.

Comment 9

[Dão Gottwald [:dao]]

(In reply to Ed Lee :Mardak from comment #7)
> Looks like it's because tabs use `font: message-box`

Can we do the same in activity stream?

Comment 10

[Ed Lee :Mardak]

Attachment: font: message-box

bbell: Here's a screenshot of setting "font: message-box" on Linux. If I do the same on Mac, there's no difference. Looks okay?

Comment 11

[Ed Lee :Mardak]

Fixed by https://github.com/mozilla/activity-stream/pull/3129 to be uplifted via bug 1387746.