Closed Bug 1384078 Opened 3 years ago Closed 3 years ago
Enter closes Web
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36 OPR/46.0.2597.57 Steps to reproduce: Reproduced on Firefox Nightly 56.0a1 20170724030204. Not reproduced on official 54.0.1 20170628075643. Can be reproduced on any extension, for example "Emoji Keyboard" from suggested addons. Steps: 1) Click on extension button to show extension's popup 2) Select any text field in extension's popup 3) Press "Enter" Actual results: Extension's popup got closed Expected results: Extension's popup is not closed
This is bad if popup has multiline text fields and really bad if popup has login form that needs to be submitted on Enter
Can confirm with 57.0a1 (2017-08-04) (64-bit), using the bitwarden extension. I press Enter to submit password and the extension popup closes.
I've experienced this behavior as well (57.0a1 (2017-08-11) (64-bit) Win 10), especially with bitwarden. This doesn't seem to happen on Chrome (v60 Win10).
Confirm with bitwarden as well. Cannot login using enter key and must use mouse to click the button button.
I have the same problem with bitwarden on 56 beta and 57 nightly.
This might be because of the CustomizableUI code that is supposed to deal with this (but was written for old-style XUL panels only) being confused by iframes and/or HTML. See https://dxr.mozilla.org/mozilla-central/rev/37824bf5c5b08afa7e689fceb935b8f457ebd9eb/browser/components/customizableui/CustomizableUI.jsm#1714 and related code.
Where is the regression window, and what's the regressing bug?
(In reply to :Gijs (queue backed up, slow) from comment #9) > Where is the regression window, and what's the regressing bug? extensions.webextensions.remote to true.
The regression window for bug 1394832 (which was closed as a duplicate of this bug) is: Last good revision: 392ed89ec2730a48d10b1cec741e86a242d28aa3 First bad revision: a625a2e9b3333a8e76982ea65f077cfded6ac224 Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=392ed89ec2730a48d10b1cec741e86a242d28aa3&tochange=a625a2e9b3333a8e76982ea65f077cfded6ac224
Andy, how likely are we to get a fix for 56 at this point?
Oh wait, sorry, you said Firefox 56. That depends on the complexity of the patch and the risk. 56 is unlikely, 57 is very likely.
We are about to build 56 RC today and it's too late for 56. Mark 56 won't fix.
Comment on attachment 8910043 [details] Bug 1384078: Prevent enter key from closing extension panels. https://reviewboard.mozilla.org/r/181512/#review186794
Attachment #8910043 - Flags: review?(gijskruitbosch+bugs) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ea61fd5fecd6d6af93c8177e4deebb470e0c093 Bug 1384078: Prevent enter key from closing extension panels. r=Gijs
Comment on attachment 8910043 [details] Bug 1384078: Prevent enter key from closing extension panels. Approval Request Comment [Feature/Bug causing the regression]: Bug 1357486 [User impact if declined]: This causes extension popups to be closed prematurely when the enter key is pressed, breaking expected functionality. [Is this code covered by automated tests?]: The popup code in general is, but there is currently no test for this behavior. [Has the fix been verified in Nightly?]: No. [Needs manual test from QE? If yes, steps to reproduce]: Listed in comment 0. [List of other uplifts needed for the feature/fix]: None. [Is the change risky?]: No. [Why is the change risky/not risky?]: It simply sets an attribute which tells the code that is currently closing the popup that it should be ignored. [String changes made/needed]: None.
Attachment #8910043 - Flags: approval-mozilla-release?
Comment on attachment 8910043 [details] Bug 1384078: Prevent enter key from closing extension panels. Annoying sounding regression, we said we wouldn't fix it for 56 but the patch looks simple. Let's uplift the fix for 56 RC2.
Attachment #8910043 - Flags: approval-mozilla-release? → approval-mozilla-release+
This issue is verified as fixed on Firefox DevEdition 57.0b2 (20170921191414) and DevEdition 56.0 (20170921234614) under Wind 7 64-bit and Ubuntu 16.04 32-bit. If you press the “Enter” key from the keyboard in the text field that is inside of a pop-up, it will not close it. Extensions used for the testing: https://addons.mozilla.org/en-US/firefox/addon/emojikeyboard/developers https://addons.mozilla.org/en-US/firefox/search/?q=bitwarden&appver=57.0&platform=windows https://addons.mozilla.org/en-US/firefox/addon/aeropost-plug-in/?src=search https://addons.mozilla.org/en-US/firefox/addon/weather-extension/?src=search https://addons.mozilla.org/en-US/firefox/addon/voucher-codes/?src=search Please see the attached video.
You need to log in before you can comment on or make changes to this bug.