1384307 - WebAuthn PublicKeyCredential object's "id" and "type" fields must be set

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect, P1)

Description

[J.C. Jones [:jcj] (he/him)]

The "PublicKeyCredential" WebIDL object's "id", "discovery", and "type" fields are blank in Firefox Nightly. 

Both of those fields are inherited from Credential Management's WebIDL "Credential" type. [1]

"id" should be set to the base64url encoding of the data in "rawId".
"type" should be the literal "public-key"
"discovery" should be the literal "remote", but as an "internal slot" it doesn't appear in the WebIDL, nor have a Getter. So that might be a follow-up to resolve.

[1] https://www.w3.org/TR/webauthn/#publickeycredential

Comment 1

[J.C. Jones [:jcj] (he/him)]

Attachment: Bug 1384307 - Set WebAuthn PublicKeyCredential's "id" and "type" fields

The Web Authentication PublicKeyCredential object has two fields currently
unpopulated which, to be spec-compliant, must be set. These fields duplicate
available data.

  [PublicKeyCredential.id] must be set to the base64url encoding with omitted
  padding of whatever data is in "rawId".

  [PublicKeyCredential.type] must be the literal "public-key".

Review commit: https://reviewboard.mozilla.org/r/161200/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/161200/

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8890115 [details]
Bug 1384307 - Set WebAuthn PublicKeyCredential's "id" and "type" fields

https://reviewboard.mozilla.org/r/161200/#review166546

Cool - lgtm.

::: dom/webauthn/tests/test_webauthn_loopback.html:54
(Diff revision 1)
>           - attestationObject: CBOR object
>           - clientDataJSON: serialized JSON
>         - clientExtensionResults: (not yet supported)
>      */
>  
> +    is(aCredInfo.type, "public-key", "Credential type must be public-key")

nit: to me it makes sense to check these in the same order as the comment, but no big deal

Comment 3

[J.C. Jones [:jcj] (he/him)]

Thanks for the review, David!

Marking checkin-needed.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42013738df2a
Set WebAuthn PublicKeyCredential's "id" and "type" fields r=keeler

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/42013738df2a