Closed Bug 1384402 Opened 4 years ago Closed 4 years ago
Fix broken about:preferences link after reorg v2
59 bytes, text/x-review-board-request
When EME is in use, there is a "linked chain" icon in the URL bar that indicates "Some audio or video on this site uses DRM...", followed by a "Configure" button. Clicking on the button opens a tab with a location of "about:preferences#privacy", although this preferences pane contains no DRM- or EME-related information. The "about:preferences#content" does contain a DRM-related checkbox; it would presumably be a better choice.
Jared, this seems like it's potentially a regression from the preference reorg work?
Component: General → Preferences
Yes, that sounds like it got broken with the recent preference reorg work. Ricky, can you take this?
Flags: needinfo?(jaws) → needinfo?(rchien)
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Flags: needinfo?(rchien) → qe-verify+
Priority: -- → P1
Below links are linking to broken about:preference#hash after scanning all source code. https://searchfox.org/mozilla-central/source/browser/base/content/utilityOverlay.js#809 https://searchfox.org/mozilla-central/source/browser/components/newtab/NewTabSearchProvider.jsm#74 https://searchfox.org/mozilla-central/source/browser/modules/ContentSearch.jsm#422 This patch will also fix all broken links.
Summary: Clicking on "Configure" on the EME doorhanger goes to the wrong place → Fix broken about:preferences link after reorg v2
> https://searchfox.org/mozilla-central/source/browser/base/content/utilityOverlay.js#809 Note that the change of this is unnecessary since all openAdvancedPreferences() are invoked in preferences old organization.
Target Milestone: --- → Firefox 56
Comment on attachment 8890660 [details] Bug 1384402 - Fix broken about:preferences link after reorg v2 https://reviewboard.mozilla.org/r/161832/#review167576
Attachment #8890660 - Flags: review?(jaws) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/4e072fd859ee Fix broken about:preferences link after reorg v2 r=jaws
Whiteboard: [photon-preference][triage] → [photon-preference]
You need to log in before you can comment on or make changes to this bug.