Fix broken about:preferences link after reorg v2

RESOLVED FIXED in Firefox 56

Status

()

Firefox
Preferences
P1
normal
RESOLVED FIXED
29 days ago
27 days ago

People

(Reporter: abr, Assigned: rickychien)

Tracking

unspecified
Firefox 56
Points:
---
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [photon-preference][triage])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

29 days ago
When EME is in use, there is a "linked chain" icon in the URL bar that indicates "Some audio or video on this site uses DRM...", followed by a "Configure" button. Clicking on the button opens a tab with a location of "about:preferences#privacy", although this preferences pane contains no DRM- or EME-related information.

The "about:preferences#content" does contain a DRM-related checkbox; it would presumably be a better choice.

Comment 1

29 days ago
Jared, this seems like it's potentially a regression from the preference reorg work?
Component: General → Preferences
Flags: needinfo?(jaws)
Yes, that sounds like it got broken with the recent preference reorg work. Ricky, can you take this?
Blocks: 1365133
Flags: needinfo?(jaws) → needinfo?(rchien)
Whiteboard: [photon-preference][triage]
(Assignee)

Updated

29 days ago
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Flags: needinfo?(rchien) → qe-verify+
Priority: -- → P1
Comment hidden (mozreview-request)
(Assignee)

Comment 4

28 days ago
Below links are linking to broken about:preference#hash after scanning all source code.

https://searchfox.org/mozilla-central/source/browser/base/content/utilityOverlay.js#809
https://searchfox.org/mozilla-central/source/browser/components/newtab/NewTabSearchProvider.jsm#74
https://searchfox.org/mozilla-central/source/browser/modules/ContentSearch.jsm#422

This patch will also fix all broken links.
Summary: Clicking on "Configure" on the EME doorhanger goes to the wrong place → Fix broken about:preferences link after reorg v2
Comment hidden (mozreview-request)
(Assignee)

Comment 6

28 days ago
> https://searchfox.org/mozilla-central/source/browser/base/content/utilityOverlay.js#809

Note that the change of this is unnecessary since all openAdvancedPreferences() are invoked in preferences old organization.
Target Milestone: --- → Firefox 56

Comment 7

27 days ago
mozreview-review
Comment on attachment 8890660 [details]
Bug 1384402 - Fix broken about:preferences link after reorg v2

https://reviewboard.mozilla.org/r/161832/#review167576
Attachment #8890660 - Flags: review?(jaws) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 10

27 days ago
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4e072fd859ee
Fix broken about:preferences link after reorg v2 r=jaws

Updated

27 days ago
Duplicate of this bug: 1384068

Comment 12

27 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4e072fd859ee
Status: ASSIGNED → RESOLVED
Last Resolved: 27 days ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.