1384402 - Fix broken about:preferences link after reorg v2

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Adam Roach [:abr]]

When EME is in use, there is a "linked chain" icon in the URL bar that indicates "Some audio or video on this site uses DRM...", followed by a "Configure" button. Clicking on the button opens a tab with a location of "about:preferences#privacy", although this preferences pane contains no DRM- or EME-related information.

The "about:preferences#content" does contain a DRM-related checkbox; it would presumably be a better choice.

Comment 1

[:Gijs (out for now; he/him)]

Jared, this seems like it's potentially a regression from the preference reorg work?

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Yes, that sounds like it got broken with the recent preference reorg work. Ricky, can you take this?

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1384402 - Fix broken about:preferences link after reorg v2

Review commit: https://reviewboard.mozilla.org/r/161832/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/161832/

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Below links are linking to broken about:preference#hash after scanning all source code.

https://searchfox.org/mozilla-central/source/browser/base/content/utilityOverlay.js#809
https://searchfox.org/mozilla-central/source/browser/components/newtab/NewTabSearchProvider.jsm#74
https://searchfox.org/mozilla-central/source/browser/modules/ContentSearch.jsm#422

This patch will also fix all broken links.

Comment 5

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8890660 [details]
Bug 1384402 - Fix broken about:preferences link after reorg v2

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/161832/diff/1-2/

Comment 6

[Ricky Chien [:rickychien] (inactive)]

> https://searchfox.org/mozilla-central/source/browser/base/content/utilityOverlay.js#809

Note that the change of this is unnecessary since all openAdvancedPreferences() are invoked in preferences old organization.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8890660 [details]
Bug 1384402 - Fix broken about:preferences link after reorg v2

https://reviewboard.mozilla.org/r/161832/#review167576

Comment 8

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8890660 [details]
Bug 1384402 - Fix broken about:preferences link after reorg v2

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/161832/diff/2-3/

Comment 9

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8890660 [details]
Bug 1384402 - Fix broken about:preferences link after reorg v2

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/161832/diff/3-4/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e072fd859ee
Fix broken about:preferences link after reorg v2 r=jaws

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4e072fd859ee