1384068 - Wrong Change search settings redirection from about:newtab and about:home after preferences v2 reorg

Status: RESOLVED DUPLICATE of bug 1384402

(Firefox :: Settings UI, defect, P1)

Description

[Petruta Horea [:phorea], Desktop QA]

Attachment: about:preferences#general is empty

+++ This bug was initially created as a clone of Bug #1378136 +++

[Note]:
- Does not reproduce when the button is selected from search bar or url bar with one-off

[Affected versions]:
- Nightly 56.0a1 2017-07-24

[Affected platforms]:
- Win 10 64-bit
- Mac OS X 10.12.5
- Ubuntu 14.04 64-bit

[Steps to reproduce]:
1. Open about:newtab and about:home
2. Enter some text in Search field to open dropdown
3. Select "Change Search Settings" button

[Expected result]:
- about:preferences#search page is opened

[Actual result]:
- about:preferences#general page opens and it has no content

[Regression range]:
- Regressed by bug 1365133 (about:preferences reorg v2)

Comment 1

[Evan Tseng [:evanxd]]

Attachment: Bug 1384068 - Clicking search settings should redirect to about:preferences#search in old and new org since new org move search section into an independent pane.

Review commit: https://reviewboard.mozilla.org/r/161212/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/161212/

Comment 2

[Evan Tseng [:evanxd]]

Comment on attachment 8890131 [details]
Bug 1384068 - Clicking search settings should redirect to about:preferences#search in old and new org since new org move search section into an independent pane.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/161212/diff/1-2/

Comment 3

[Evan Tseng [:evanxd]]

Hi Jared,

Could you help review the patch?

Thank you.

Comment 4

[Evan Tseng [:evanxd]]

Comment on attachment 8890131 [details]
Bug 1384068 - Clicking search settings should redirect to about:preferences#search in old and new org since new org move search section into an independent pane.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/161212/diff/2-3/

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8890131 [details]
Bug 1384068 - Clicking search settings should redirect to about:preferences#search in old and new org since new org move search section into an independent pane.

https://reviewboard.mozilla.org/r/161212/#review166766

Can you please add a test for this? We shouldn't have silently broken it.

Comment 6

[Evan Tseng [:evanxd]]

Comment on attachment 8890131 [details]
Bug 1384068 - Clicking search settings should redirect to about:preferences#search in old and new org since new org move search section into an independent pane.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/161212/diff/3-4/

Comment 7

[Evan Tseng [:evanxd]]

Comment on attachment 8890131 [details]
Bug 1384068 - Clicking search settings should redirect to about:preferences#search in old and new org since new org move search section into an independent pane.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/161212/diff/4-5/

Comment 8

[Evan Tseng [:evanxd]]

Comment on attachment 8890131 [details]
Bug 1384068 - Clicking search settings should redirect to about:preferences#search in old and new org since new org move search section into an independent pane.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/161212/diff/5-6/

Comment 9

[Evan Tseng [:evanxd]]

Comment on attachment 8890131 [details]
Bug 1384068 - Clicking search settings should redirect to about:preferences#search in old and new org since new org move search section into an independent pane.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/161212/diff/6-7/

Comment 10

[Evan Tseng [:evanxd]]

Comment on attachment 8890131 [details]
Bug 1384068 - Clicking search settings should redirect to about:preferences#search in old and new org since new org move search section into an independent pane.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/161212/diff/7-8/

Comment 11

[Evan Tseng [:evanxd]]

This issue is already fixed by Bug 1384402.