138442 - LDAP needs a real 'make install' target

Status: RESOLVED FIXED

(Directory :: LDAP C SDK, defect)

Description

[cls]

Currently, the LDAP 5.0 client branch has a compatibility 'install' target.  The
LDAP 4.0 branch had an actual 'real_install' target, by way of NSPR, that
actually installed the build on the user's machine in the specified @prefix@
directory.  We need that target back so that we can do a real 'make install'
from the Mozilla tree.

Comment 1

[hacker formerly known as [e-mail]]

Attachment: Resurect real_install target

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

I'm a little concerned that these changes (specifically, defining RELEASE_*
variables inside the Makefile.in files) might confuse any build scripts that Sun
or Netscape uses, making these changes not entirely agreeable for checkin as-is
on the trunk.  I _think_ they're probably ok, but I'd appreciate it if mhein/mcs
could weigh in with an opinion here.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 79969 [details] [diff] [review]
Resurect real_install target 

Also, we need to be sure ldap-standard.h gets generated and installed by the
real_install target, which it doesn't appear to currently.

Comment 4

[hacker formerly known as [e-mail]]

Attachment: real_install v2

Comment 5

[Mark Smith [:mcs]]

Comment on attachment 80536 [details] [diff] [review]
real_install v2

I do not think these changes will cause any problems for the Sun and Netscape
standalone LDAP C SDK builds.

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 80536 [details] [diff] [review]
real_install v2

r=dmose

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

Checked in on ldapcsdk_50_client_branch (which is the branch used by the Mozilla
trunk).  Next I need to check it on the C SDK trunk, but first I have to get
autoconf working there again (bug 139917).

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

Checked in on the LDAP C SDK trunk.  Now this only remains to be checked in on
the Mozilla 1.0 branch, which undoubtedly ADT will want us to delay until
Netscape branches off of that branch.

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 80536 [details] [diff] [review]
real_install v2

a=[e-mail] (make sure it's in trunk too)

Comment 10

[hacker formerly known as [e-mail]]

The patch has been checked into the  moz1.0.0 branch.

Comment 11

[Frankie]

Spam for bug 129472