1384422 - Migrate clang to toolchain dependencies

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Mike Hommey [:glandium] OoO until Dec 30]

Data for the migration helper attached to bug 1313111:
KNOWN_TOOLCHAINS = {
    'linux64-clang': '52f3fc23f0f5',
    'win32-clang': '44dee70d525e',
    'win64-clang': 'cd3ed31acefd',
}

This leaves out fuzzing and static analysis builds, that are using, respectively, clang 4.0.1 and clang 3.8.

Comment 2

[Mike Hommey [:glandium] OoO until Dec 30]

Err, same player shoot again:
KNOWN_TOOLCHAINS = {
    'linux64-clang': '52f3fc23f0f5',
    'win32-clang-cl': 'cd3ed31acefd',
    'win64-clang-cl': '44dee70d525e',
}

Comment 3

[Mike Hommey [:glandium] OoO until Dec 30]

Attachment: Bug 1384422 - Use toolchain dependencies for clang.

This leaves out fuzzing and linux static analysis builds, which are
using, respectively, clang 4.0.1 and clang 3.8, while linux64-clang
produces a 3.9 and win*-clang a 5.0

Review commit: https://reviewboard.mozilla.org/r/161328/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/161328/

Comment 4

[Mike Hommey [:glandium] OoO until Dec 30]

Attachment: Bug 1384422 - Remove clang entries from tooltool manifests.

Except for fuzzing and linux static analysis.

Review commit: https://reviewboard.mozilla.org/r/161330/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/161330/

Comment 5

[Mike Hommey [:glandium] OoO until Dec 30]

Comment on attachment 8890225 [details]
Bug 1384422 - Use toolchain dependencies for clang.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/161328/diff/1-2/

Comment 6

[Mike Hommey [:glandium] OoO until Dec 30]

Comment on attachment 8890226 [details]
Bug 1384422 - Remove clang entries from tooltool manifests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/161330/diff/1-2/

Comment 7

[Mike Hommey [:glandium] OoO until Dec 30]

Comment on attachment 8890226 [details]
Bug 1384422 - Remove clang entries from tooltool manifests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/161330/diff/2-3/

Comment 8

[Gregory Szorc [:gps]]

Comment on attachment 8890225 [details]
Bug 1384422 - Use toolchain dependencies for clang.

https://reviewboard.mozilla.org/r/161328/#review167096

::: taskcluster/ci/toolchain/linux.yml
(Diff revision 2)
>              - 'build/build-clang/**'
>              - 'taskcluster/scripts/misc/tooltool-download.sh'
>          toolchain-artifact: public/build/clang.tar.xz
>      toolchains:
>          - linux64-gcc
> -        - linux64-sccache

This hunk feels out of place. I trust you to triage appropriately before landing.

Comment 9

[Gregory Szorc [:gps]]

Comment on attachment 8890226 [details]
Bug 1384422 - Remove clang entries from tooltool manifests.

https://reviewboard.mozilla.org/r/161330/#review167098

Comment 10

[Mike Hommey [:glandium] OoO until Dec 30]

Comment on attachment 8890225 [details]
Bug 1384422 - Use toolchain dependencies for clang.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/161328/diff/2-3/

Comment 11

[Mike Hommey [:glandium] OoO until Dec 30]

Comment on attachment 8890226 [details]
Bug 1384422 - Remove clang entries from tooltool manifests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/161330/diff/3-4/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc2502e91e16
Use toolchain dependencies for clang. r=gps
https://hg.mozilla.org/integration/autoland/rev/9ea98e47b682
Remove clang entries from tooltool manifests. r=gps

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cc2502e91e16
https://hg.mozilla.org/mozilla-central/rev/9ea98e47b682