1380171 - Enable stylo on thunderbird.

Status: RESOLVED FIXED

(Thunderbird :: Build Config, enhancement)

Description

[Tom Prince [:tomprince]]

Bug 1379339 enabled stylo builds on OSX for firefox. The build currently hangs for Thunderbird when building with stylo.

We should investigate and fix this. In the meantime, disable the stylo builds.

Comment 1

[Tom Prince [:tomprince]]

Attachment: Bug 1380171 - Disable stylo builds for thunderbird.

Review commit: https://reviewboard.mozilla.org/r/156350/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156350/

Comment 2

[Tom Prince [:tomprince]]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=dba99bcc676d1a055febb9f61b9af2000896382c

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: rb156350.patch - Disable stylo [landed in comment #4]

I still prefer the old way of attaching patches since I'm not so familiar with reviewboard. Also, it gives me the opportunity to apply certain tweaks before landing.

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 8885840 [details] [diff] [review]
rb156350.patch - Disable stylo [landed in comment #4]

https://hg.mozilla.org/comm-central/rev/b8853a304067656d5b43ecf9aeb572475adb09b4

Comment 5

[Jorg K (CEST = GMT+2)]

Hmm, that patch made the try run better
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=dba99bcc676d1a055febb9f61b9af2000896382c
but it didn't work on C-C:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=b8853a304067656d5b43ecf9aeb572475adb09b4

Comment 6

[Tom Prince [:tomprince]]

I'm not sure what is going on, since this doesn't seem to be disabling stylo on comm-central. I'll continue to investigate that. The test failures on OSX are due to Bug 1380236 which can be landed on mozilla, but I don't currently have permissions to do that.

Comment 7

[Jorg K (CEST = GMT+2)]

You can set "checkin-needed" and a sheriff will check it in for you (done in bug 1380236).

I'm a bit confused here. I thought we wanted to disable stylo on Mac to (temporarily) get rid of those test failures. If they're unrelated I just back out this patch and we're done here?

Comment 8

[Tom Prince [:tomprince]]

> You can set "checkin-needed" and a sheriff will check it in for you (done in bug 1380236).

Good to know, thanks.

> I'm a bit confused here. I thought we wanted to disable stylo on Mac to (temporarily) get rid of those test failures. If they're unrelated I just back out this patch and we're done here?

There are also intermittent build failures on OSX (such as https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=873ddce7e8e6f9b9272789154752207cb6556652) which don't really have enough information to diagnose. Stylo was one guess, but perhaps that is mistaken.

Comment 9

[Jorg K (CEST = GMT+2)]

Right, I forgot those other failures. Anyway, this patch here does not harm, let me know your findings and I'll back it out in due course.

Comment 10

[Jorg K (CEST = GMT+2)]

I've backed this out
https://hg.mozilla.org/comm-central/rev/b61e73be467cef8a7231c42c0aba1a82ddfffada
since it didn't fix the
command timed out: 10800 seconds without output running ['make', '-f', 'client.mk', 'build', u'MOZ_BUILD_DATE=20170713024920'], attempting to kill
we've been seeing lately.

Should this bug be closed since stylo builds are enabled on macOS?

Comment 11

[Tom Prince [:tomprince]]

Stylo didn't appear to be causing any issues and is enabled.

Comment 12

[Tom Prince [:tomprince]]

As per https://bugzilla.mozilla.org/show_bug.cgi?id=1380844#c5 I've disabled stylo again. We should reenable it once it is actually being used in firefox, rather than just building. (And figure out why it is causing builds to timeout)

Comment 13

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/db4917476acb50edbc625638112f8e22c65e025d

Comment 14

[Tom Prince [:tomprince]]

Since Bug 1384422 we don't have LLVM on windows either. I'm disabling stylo their until we migrate to taskcluster, rather than diverging further (see Bug 1385085) in our tooltool manifests.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3749d8c1fa1b
Disable stylo builds; rs=bustage-fix

Comment 16

[Frank-Rainer Grahl (:frg)]

Tom,

on OSX you put the stylo config in  $topsrcdir/build/macosx/mozconfig.common

Why did you change the Linux and Windows configs individually?

Comment 17

[Tom Prince [:tomprince]]

We keep `build/*` synced with mozilla-central's copy of the corresponding files.

mozilla-central's build/macosx/mozconfig.common refers to mozconfig.style (https://dxr.mozilla.org/comm-central/source/mozilla/build/macosx/mozconfig.common#7) but the linux/windows ones don't.

Comment 18

[Frank-Rainer Grahl (:frg)]

Thanks. Looks like an oversight on the Mozilla side then.

Comment 19

[Boris Zbarsky [:bzbarsky]]

The option to --disable-stylo is going to go away in the near future (likely in the 59 timeframe).  At this point stylo is shipping in Firefox on all platforms, so hopefully the gecko-side bits are all sorted out.  Would be good to make progress on this bug before the configure flag is removed and Thunderbird builds break.

Comment 20

[Jorg K (CEST = GMT+2)]

Hi Boris, we've added --disable-stylo in bug 1350011 comment #10 (and a few comments down) due to an incompatibility on those buildbot machines. Since we're moving to TaskCluster RSN(TM) (I believe it's already working for Linux), I don't think this will be an issue. Thanks for the heads-up. Tom is the man to talk to here.

Comment 21

[Tom Prince [:tomprince]]

I'm working hard to get thunderbird off buildbot and onto taskcluster, at which point the environment incompatibilities will go away. I really how that everything will be ready by the time 59 branches, but I don't know how far in advance of that I'll be able to complete things.

Comment 22

[Chris Peterson [:cpeterson]]

status-firefox57=wontfix unless someone thinks this bug should block 57

Comment 23

[Emilio Cobos Álvarez (:emilio)]

(Not sure why the tracking flags were updated, I just edited the cc field, shrug)

Comment 24

[Tom Prince [:tomprince]]

Trunk builds are now on taskcluster with stylo.