1384610 - Complete theme remains enabled and installed after setting extensions.legacy.enabled to false

Status: RESOLVED INVALID

(Toolkit :: Add-ons Manager, defect)

Description

[Vasilica Tamas, QA [:vtamas]]

Attachment: Animation1.gif

[Note]: 
This is a follow-up for Bug 1373449

[Affected versions]:
Firefox 56.0a1 (2017-07-26)

[Affected platforms]:
Windows 10 64-bit
Mac OS X 10.12.3

[Steps to reproduce]:
1.Launch Firefox with a clean profile.
2.Install the following complete theme: https://addons.mozilla.org/en-US/firefox/addon/lavafox-v1/?src=cb-dl-users
3.Restart the browser.
4.Navigate to about:config and toggle "extensions.legacy.enabled” pref to false.
5.Restart the browser.
6.Go to about:addons and check the complete theme status.


[Expected Results]:
Complete theme is automatically uninstalled and displayed in Legacy Extensions tab.


[Actual Results]:
- At step 4 in about:addons -> Extensions appears the following message for the installed complete theme “LavaFox V2 will be disabled after you restart Nightly”
- The complete theme remains installed after restarting the browser. It is displayed as disabled in “Recent Updates” tab together with the “LavaFox V2 has been disabled since it is not multiprocess compatible”
- See attached screencast.

Comment 1

[Andrew Swan [:aswan]]

This is the same issue as described in https://bugzilla.mozilla.org/show_bug.cgi?id=1385251#c1
In short, the browser does not re-evaluate compatibility restart with a pref flip.  So I don't believe this will be a problem during the upgrade-to-57 cycle (though that could be verified with the builds in bug 1385964).  And then after 57, support for complete themes will go away and this will no longer be an issue.