Don't add --artifact flag in `mach try` if outgoing has native changes

NEW
Unassigned

Status

Testing
General
5 months ago
5 months ago

People

(Reporter: kmag, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Too often, I wind up accidentally running `mach try` from a shell with an artifact mozconfig when I have native changes to test. If I'm lucky, I notice it immediately. More often, I only notice when the tests fail.

I switched my default mozconfig to a non-artifact config in order to avoid this, but it still happens far too often.

It should be fairly easy for us to check the outgoing draft patches for native changes (probably at least C++ or rust), and either skip adding the --artifact flag, or bail out unless --artifact or --no-artifact is explicitly present.
Blocks: 1315032, 1278699
No longer depends on: 1315032
You need to log in before you can comment on or make changes to this bug.