Closed
Bug 1315032
Opened 8 years ago
Closed 7 years ago
Mach try should automatically provide the --artifact flag if we see --enable-artifact-builds locally
Categories
(Testing :: General, defect)
Tracking
(firefox54 fixed)
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: chmanchester, Unassigned)
References
(Depends on 1 open bug, Blocks 2 open bugs)
Details
Attachments
(1 file)
We'd like to convert at least the people using artifact builds locally to get in the habit of using them on try to save end-to-end time. gps noted in a meeting earlier we can detect this pretty reliably by noticing someone has specified --enable-artifact-builds in their mozconfig locally.
Comment hidden (mozreview-request) |
Reporter | ||
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8812613 [details] Bug 1315032 - Make |mach try| set --artifact flag when --enable-artifact-builds is set. https://reviewboard.mozilla.org/r/94276/#review94722 This seems like the way to achieve this. Unfortunately we really can't turn this on as an automatic thing until bug 1278699 is dealt with.
Attachment #8812613 -
Flags: review?(cmanchester)
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8812613 [details] Bug 1315032 - Make |mach try| set --artifact flag when --enable-artifact-builds is set. https://reviewboard.mozilla.org/r/94276/#review94946
Attachment #8812613 -
Flags: review?(mjzffr)
Comment 4•7 years ago
|
||
(In reply to Maja Frydrychowicz (:maja_zf) from comment #3) > Comment on attachment 8812613 [details] > Bug 1315032 - Make |mach try| set --artifact flag when > --enable-artifact-builds is set. > > https://reviewboard.mozilla.org/r/94276/#review94946 maja_zf: I see you canceled your review without comment. Are you deferring to chmanchester? Are happy with this patch, modulo that we can't land it due to #c2?
Depends on: 1278699
Flags: needinfo?(mjzffr)
Comment 5•7 years ago
|
||
It would be nice to enable this for Android front-end developers. I could guard with `MOZ_APPLICATION == mobile/android` with a note about the failing tests; Android front-end devs probably never care about this tests.
Yes (deferring) and yes (happy).
Flags: needinfo?(mjzffr)
Reporter | ||
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8812613 [details] Bug 1315032 - Make |mach try| set --artifact flag when --enable-artifact-builds is set. https://reviewboard.mozilla.org/r/94276/#review117580
Attachment #8812613 -
Flags: review+
Reporter | ||
Comment 8•7 years ago
|
||
Now that artifact builds are mostly green I think this is good to land as is assuming it still applies. It gives instructions on how to turn off the behavior (--no-artifact), and if we find something else that makes this undesirable we can re-visit the approach.
Pushed by cmanchester@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/48c662cadc6f Make |mach try| set --artifact flag when --enable-artifact-builds is set. r=chmanchester
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/48c662cadc6f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Updated•7 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•