Mach try should automatically provide the --artifact flag if we see --enable-artifact-builds locally

RESOLVED FIXED in Firefox 54

Status

Testing
General
RESOLVED FIXED
a year ago
6 months ago

People

(Reporter: chmanchester, Unassigned)

Tracking

(Depends on: 2 bugs, Blocks: 2 bugs)

Version 3
mozilla54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a year ago
We'd like to convert at least the people using artifact builds locally to get in the habit of using them on try to save end-to-end time. gps noted in a meeting earlier we can detect this pretty reliably by noticing someone has specified --enable-artifact-builds in their mozconfig locally.
Comment hidden (mozreview-request)
(Reporter)

Comment 2

a year ago
mozreview-review
Comment on attachment 8812613 [details]
Bug 1315032 - Make |mach try| set --artifact flag when --enable-artifact-builds is set.

https://reviewboard.mozilla.org/r/94276/#review94722

This seems like the way to achieve this. Unfortunately we really can't turn this on as an automatic thing until bug 1278699 is dealt with.
Attachment #8812613 - Flags: review?(cmanchester)

Comment 3

a year ago
mozreview-review
Comment on attachment 8812613 [details]
Bug 1315032 - Make |mach try| set --artifact flag when --enable-artifact-builds is set.

https://reviewboard.mozilla.org/r/94276/#review94946
Attachment #8812613 - Flags: review?(mjzffr)
(In reply to Maja Frydrychowicz (:maja_zf) from comment #3)
> Comment on attachment 8812613 [details]
> Bug 1315032 - Make |mach try| set --artifact flag when
> --enable-artifact-builds is set.
> 
> https://reviewboard.mozilla.org/r/94276/#review94946

maja_zf: I see you canceled your review without comment.  Are you deferring to chmanchester?  Are happy with this patch, modulo that we can't land it due to #c2?
Depends on: 1278699
Flags: needinfo?(mjzffr)
It would be nice to enable this for Android front-end developers.  I could guard with `MOZ_APPLICATION == mobile/android` with a note about the failing tests; Android front-end devs probably never care about this tests.
Yes (deferring) and yes (happy).
Flags: needinfo?(mjzffr)
(Reporter)

Comment 7

11 months ago
mozreview-review
Comment on attachment 8812613 [details]
Bug 1315032 - Make |mach try| set --artifact flag when --enable-artifact-builds is set.

https://reviewboard.mozilla.org/r/94276/#review117580
Attachment #8812613 - Flags: review+
(Reporter)

Comment 8

11 months ago
Now that artifact builds are mostly green I think this is good to land as is assuming it still applies. It gives instructions on how to turn off the behavior (--no-artifact), and if we find something else that makes this undesirable we can re-visit the approach.

Comment 9

11 months ago
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/48c662cadc6f
Make |mach try| set --artifact flag when --enable-artifact-builds is set. r=chmanchester

Comment 10

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/48c662cadc6f
Status: NEW → RESOLVED
Last Resolved: 11 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
(Reporter)

Updated

11 months ago
Depends on: 1344117
(Reporter)

Updated

11 months ago
Depends on: 1344281

Updated

10 months ago
Blocks: 1348266
No longer blocks: 1384711
Depends on: 1384711
You need to log in before you can comment on or make changes to this bug.