1384813 - Going to about:preferences#privacy-reports, there is no header for the content.

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Evan Tseng [:evanxd]]

Attachment: screenshot.png

Going to about:preferences#privacy-reports, there is no header for the content.

STR:
1. Go to about:preferences#privacy-reports

Actual:
There is no header for the content. (see it in the attachment)

Expected
We might need to have a header for the content.

Comment 1

[Evan Tseng [:evanxd]]

It might be a P3 bug, but let's triage it.

Comment 2

[Evan Tseng [:evanxd]]

Attachment: Bug 1384813 - Show a header for "about:preferences#privacy-reports" content since we would like to show every content with a header.

Review commit: https://reviewboard.mozilla.org/r/162420/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/162420/

Comment 3

[Evan Tseng [:evanxd]]

Attachment: ux-review-screenshot.png

Comment 4

[Evan Tseng [:evanxd]]

Comment on attachment 8891194 [details]
Bug 1384813 - Show a header for "about:preferences#privacy-reports" content since we would like to show every content with a header.

Hi Tina,

Could you help review the UI change? See the change at the screenshot[1].

Thank you.

[1]: https://bug1384813.bmoattachments.org/attachment.cgi?id=8891195

Comment 5

[Evan Tseng [:evanxd]]

Hi Mike,

Could you help review the patch?

Thank you.

Comment 6

[Tina Hsieh[:Tina_Hsieh] UX]

Comment on attachment 8891194 [details]
Bug 1384813 - Show a header for "about:preferences#privacy-reports" content since we would like to show every content with a header.

Hey Evan,
Thanks for adding the header back! The header looks good to me.
However, I've noticed that the two Learn more position seems a bit weird to me. 

I'll r+ this UI review for the header part. Thank you!

Comment 7

[Evan Tseng [:evanxd]]

Sure, we've already fixed that at Bug 1384812.

Thank you for reviewing, Tina.

Comment 8

[Mike Conley (:mconley) (:⚙️) (PTO Dec 22 - Jan 2)]

Comment on attachment 8891194 [details]
Bug 1384813 - Show a header for "about:preferences#privacy-reports" content since we would like to show every content with a header.

https://reviewboard.mozilla.org/r/162420/#review167834

Thanks!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e94c43d92f18
Show a header for "about:preferences#privacy-reports" content since we would like to show every content with a header. r=mconley

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e94c43d92f18

Comment 11

[Sayed [:LiquidO2]]

I have reproduced this bug in Nightly 56.0a1 (2017-07-26) (64-bit) in Linux(64bit).

I can verify that this bug is fixed in latest Nightly. 

Build ID 	20170731100325
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0

Comment 12

[Saheda Reza [:Antora]]

I have reproduced this bug on Nightly according to (2017-07-26)

Fixing bug is verified on latest Beta--
Build ID 	20170808170225
User Agent 	Mozilla/5.0 (Windows NT 6.1; WOW64; rv:56.0) Gecko/20100101 Firefox/56.0

Tested OS-- Windows7 32bit

Comment 13

[Sayed [:LiquidO2]]

As this bug is verified as fixed in both linux(comment 11) and windows(comment 12), I am marking this bug as verified fixed.