1384955 - Add "Edit and Retrigger" option to the ... drop down

Status: RESOLVED FIXED

(Tree Management :: Treeherder, enhancement)

Description

[Andrew Halberstadt [:ahal]]

I think this is pretty low-hanging fruit with a lot of potential. Taskcluster already has the ability to edit and create (aka retrigger) a task. Given a task id, simply visit this url:
https://tools.taskcluster.net/tasks/cHhlvS9CRaGifFnUcQ381Q/create

Treeherder could provide a link to there in the ... drop down, and call it 'Edit and Retrigger' or something like that. Then developers would have a way of controlling the environment variables the task uses, as well as the command the task runs.

We could eventually take this further and put the actual harness command line in the task definition so they could control that too.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] tojon:1384955-create-task-menu > mozilla:master

Comment 2

[Jonathan French (:jfrench)]

In case you guys decide to do it, the PR is there.

Comment 3

[Jonathan French (:jfrench)]

Comment on attachment 8893850 [details] [review]
[treeherder] tojon:1384955-create-task-menu > mozilla:master

Adding camd for review and kwierso for feedback on the naming.

Comment 4

[Andrew Halberstadt [:ahal]]

Thanks jfrench, this looks good to me!

I sort of prefer "Edit and Retrigger" as developers might not understand why "Create Task" would be useful (i.e that it's pre-populated with this task's definition). But I'm happy with Create Task too if you guys like it better.

Comment 5

[Jonathan French (:jfrench)]

Ya, I'm just for UI consistency across platforms, but I defer to you guys if there's good reasons for it to deviate. It was just confusing to me to select a menu that said Edit and Retrigger, and end up on a page (in TC) that says Create Task. If the TC page title had been Edit Task or Retrigger Task, that would have made sense to me.

But again I defer to you guys, and I'll name it accordingly. :)

Comment 6

[Cameron Dawson [:camd]]

Naming is so hard...  :)  I wonder if "Custom Retrigger" would work?  I must admit I prefer "Edit and Retrigger" myself as well.  But I haven't reviewed the code yet...

Comment 7

[Jonathan French (:jfrench)]

Well, there's two votes from two awesome dudes so I'll change it to Edit and Retrigger you've reviewed it, unless you arrive at something you like more. Maybe TC could improve the wording on their side eventually for their page since it seems to me the task already exists - therefore in TC one doesn't appear to me to be 'creating' it - at first glance anyway.

Comment 8

[Jonathan French (:jfrench)]

Ok, the name change is there and everything seems fine in UI testing.

Comment 9

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/a5f0fadf29ec605f96681d3df9897faf189915ab
Bug 1384955 - Add 'Edit and Retrigger' to job action menu

Comment 10

[Cameron Dawson [:camd]]

Comment on attachment 8893850 [details] [review]
[treeherder] tojon:1384955-create-task-menu > mozilla:master

Thanks Jon!

Comment 11

[Jonathan French (:jfrench)]

Thanks for the feedback and review sirs! Verified fixed on Stage.