1502142 - Add back in the "Edit and Retrigger" option in treeherder

Status: RESOLVED WONTFIX

(Tree Management :: Treeherder, enhancement, P3)

Description

[Andrew Halberstadt [:ahal]]

In bug 1384955 we added in option to "Edit and Retrigger" a task. This just linked to taskcluster's task creator, but it was really handy for doing things like running a task with a new environment variable (or performing other modifications to the task definition).

It looks like this was removed here during a refactor:
https://github.com/mozilla/treeherder/commit/15721f009c325256b754bd3f8ce29c16041478af#diff-785d18b1ec6858c43b406520d1d7d478L127

I'm not sure if it was accidental or on purpose, but I think this option was pretty useful and low maintenance to have.

Comment 1

[Ed Morley [:emorley]]

The feature was moved to another file in that commit - the actual removal occurred later, in bug 1470622:
https://github.com/mozilla/treeherder/pull/3980/files#diff-f4110e276b889847eb2a5cfd91faffdfL348

```
treeherder $ git-content-search 'Edit and Retrigger'
c8998982c Bug 1470622 - Convert actions to use hook-based actions (#3980)
M       ui/job-view/details/summary/ActionBar.jsx
15721f009 Bug 1450022 - Convert the rest of Details Panel to ReactJS (#3621)
A       ui/job-view/details/summary/ActionBar.jsx
D       ui/plugins/pluginpanel.html
a5f0fadf2 Bug 1384955 - Add 'Edit and Retrigger' to job action menu
M       ui/plugins/pluginpanel.html
```
(that alias uses the trick here: https://gist.github.com/lyoshenka/8251914)

The removal was mentioned in passing here:

(In reply to Dustin J. Mitchell [:dustin] pronoun: he from bug 1470622 comment #5)
> > > * edit & retrigger
> > 
> > We probably won't support this anymore..
> 
> *definitely* won't support this anymore

I believe it has something to do with the permissions being locked down, so certain workflows are no longer going to be supported.

Dustin, could you advise? :-)

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Well, task-creator isn't going away, but the scopes for it are.  At least, that's been the plan.  That's certainly meeting a lot of resistance, so there's a chance that we'll just decide to accept the risk to firefox security and keep the current arrangement.  That decision is above my pay-grade :)

Comment 3

[Andrew Halberstadt [:ahal]]

Yeah, if the scopes required to use task-creator are going away, then I guess there's no point in adding this back in. Then again if they aren't (or this is going to be in limbo for years), then it might be worth it. I guess it depends how much work adding the button back would be. We can certainly wait a bit to see what happens.

Comment 4

[Ed Morley [:emorley]]

(In reply to Dustin J. Mitchell [:dustin] pronoun: he from comment #2)

Well, task-creator isn't going away, but the scopes for it are. At least,
that's been the plan. That's certainly meeting a lot of resistance, so
there's a chance that we'll just decide to accept the risk to firefox
security and keep the current arrangement

Do you know if a decision has been made on this?
Should we wontfix this bug?

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

It remains the plan, so I think WONTFIX is good.