Closed
Bug 1385035
Opened 7 years ago
Closed 7 years ago
Turn on HSTS priming only in early beta or earlier
Categories
(Core :: DOM: Security, defect)
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: kmckinley, Assigned: kmckinley)
References
Details
Attachments
(1 file)
2.96 KB,
patch
|
ckerschb
:
review+
jcristau
:
feedback+
|
Details | Diff | Splinter Review |
Since the RELEASE macro never gets defined, change to EARLY_BETA_OR_EARLIER.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8891025 -
Flags: review?(ckerschb)
Comment 2•7 years ago
|
||
Comment on attachment 8891025 [details] [diff] [review]
Change the condition to use the EARLY_BETA_OR_EARLIER macro
Review of attachment 8891025 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm, but just to make sure I would like to consult :jcristau.
Attachment #8891025 -
Flags: review?(jcristau)
Attachment #8891025 -
Flags: review?(ckerschb)
Attachment #8891025 -
Flags: review+
Comment 3•7 years ago
|
||
Comment on attachment 8891025 [details] [diff] [review]
Change the condition to use the EARLY_BETA_OR_EARLIER macro
looks good to me, thanks!
Attachment #8891025 -
Flags: review?(jcristau) → feedback+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a42d8f96f27
Turn on HSTS priming in EARLY_BETA_OR_EARLIER. r=ckerschb
Keywords: checkin-needed
Comment 5•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•