Closed Bug 1385035 Opened 7 years ago Closed 7 years ago

Turn on HSTS priming only in early beta or earlier

Categories

(Core :: DOM: Security, defect)

56 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: kmckinley, Assigned: kmckinley)

References

Details

Attachments

(1 file)

Since the RELEASE macro never gets defined, change to EARLY_BETA_OR_EARLIER.
Blocks: 1374453
Comment on attachment 8891025 [details] [diff] [review]
Change the condition to use the EARLY_BETA_OR_EARLIER macro

Review of attachment 8891025 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, but just to make sure I would like to consult :jcristau.
Attachment #8891025 - Flags: review?(jcristau)
Attachment #8891025 - Flags: review?(ckerschb)
Attachment #8891025 - Flags: review+
Comment on attachment 8891025 [details] [diff] [review]
Change the condition to use the EARLY_BETA_OR_EARLIER macro

looks good to me, thanks!
Attachment #8891025 - Flags: review?(jcristau) → feedback+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a42d8f96f27
Turn on HSTS priming in EARLY_BETA_OR_EARLIER. r=ckerschb
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1a42d8f96f27
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.