1385141 - stylo: Fail to reject multi-value easing (ease-in-out, ease-out) when parsing easing

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P2)

Description

[Brian Birtles (:birtles, Feb 26~ parental leave)]

In testing/web-platform/tests/web-animations/interfaces/KeyframeEffect/constructor.html the following two tests still fail:

  #1: Invalid easing [a multi-value easing] in keyframe sequence should be thrown
  #2: Invalid KeyframeEffectReadOnly option by a multi-value easing

These are both failing because we don't throw when we get 'ease-in-out, ease-out' as a value for `easing`. Presumably when we parse this with stylo we're allowing lists of values (since lists are permitted for CSS animations/transitions) even though lists are not allowed when using the Web Animations API.

Comment 1

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Bug 1385141 - Update test expectations for web-animations/interfaces/KeyframeEffect/constructor.html;

Review commit: https://reviewboard.mozilla.org/r/166354/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166354/

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8895196 [details]
Bug 1385141 - Update test expectations for web-animations/interfaces/KeyframeEffect/constructor.html;

https://reviewboard.mozilla.org/r/166354/#review171522

Comment 3

[Anthony Ramine [:nox]]

You could do `parser.parse_entirely(|p| ...::parse(&context, p))` instead.

Comment 4

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Comment on attachment 8895196 [details]
Bug 1385141 - Update test expectations for web-animations/interfaces/KeyframeEffect/constructor.html;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166354/diff/1-2/

Comment 5

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Attachment: Servo PR #18036

Comment 6

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Comment on attachment 8895196 [details]
Bug 1385141 - Update test expectations for web-animations/interfaces/KeyframeEffect/constructor.html;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166354/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4839ba8b065
Update test expectations for web-animations/interfaces/KeyframeEffect/constructor.html; r=hiro

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a4839ba8b065