Closed
Bug 1385179
Opened 7 years ago
Closed 7 years ago
Unhide addresses sync engine by default
Categories
(Firefox :: Sync, enhancement, P1)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 57
People
(Reporter: markh, Assigned: markh)
References
Details
(Whiteboard: [form autofill:M3])
Attachments
(1 file)
We should enable the "addresses" engine by default. Credit-cards will be enabled at a later time.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8891192 [details] Bug 1385179 - Enable addresses sync engine as formautofill initializes. https://reviewboard.mozilla.org/r/162410/#review167660 ::: services/sync/services-sync.js:35 (Diff revision 1) > // The addresses and CC engines might not actually be available at all. > -pref("services.sync.engine.addresses.available", false); > +pref("services.sync.engine.addresses.available", true); IIUC we're supposed to only flip these based on the geolocation data of what country the profile is from so I don't think we want this to ride the trains unconditionally true. I thought you were wanting to put it in #ifdef NIGHTLY_BUILD for testing.
Attachment #8891192 -
Flags: review?(MattN+bmo)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → markh
Priority: -- → P2
Summary: Enable addresses sync engine by default → Unhide addresses sync engine by default
Updated•7 years ago
|
Priority: P2 → P1
Assignee | ||
Comment 3•7 years ago
|
||
From IRC, we will rely on bug 1385196, which will arrange to early-return from bootstrap.js if the feature is disabled, so we can unconditionally flip the sync preference at this time. Matt also suggested we reset the pref if we find the feature is disabled, just incase we turned the entire feature off after it was previously enabled.
Depends on: 1385196
Comment hidden (mozreview-request) |
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8891192 [details] Bug 1385179 - Enable addresses sync engine as formautofill initializes. https://reviewboard.mozilla.org/r/162410/#review171038
Attachment #8891192 -
Flags: review?(MattN+bmo) → review+
Whiteboard: [form autofill:M3]
Comment hidden (mozreview-request) |
Pushed by mhammond@skippinet.com.au: https://hg.mozilla.org/integration/autoland/rev/5d879d2d7730 Enable addresses sync engine as formautofill initializes. r=MattN
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5d879d2d7730
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment 9•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/52fbfd0cdb8a
status-firefox56:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•